On 17/01/2023 23:59, Adam Dinwoodie wrote:
On Fri, Jan 13, 2023 at 01:22:44PM +0000, Jon Turney via Cygwin-apps wrote:
[1] https://cygwin.com/packaging-package-files.html
I just spotted [0] in the Cygport documentation, and was reminded of
this conversation. According to that, the version string is explicitly
allowed to include hyphens! I suspect that's fundamentally a
documentanion bug these days, and should just be expunged...
[0]: https://cygwin.github.io/cygport/syntax_cygpart.html#VERSION
Quick patch below; I can submit this properly as a GitHub PR or with
`git send-email` or otherwise if that'd be useful...
diff --git a/lib/syntax.cygpart b/lib/syntax.cygpart
index 4a400a71..6b992031 100644
--- a/lib/syntax.cygpart
+++ b/lib/syntax.cygpart
@@ -316,7 +316,7 @@ __target_is_embedded() {
#****v* Globals/VERSION
# DESCRIPTION
# The upstream package version number. PV must begin with a digit 0-9, and
-# subsequent characters can be a digit, letter, dot, hyphen, or underscore.
+# subsequent characters can be a digit, letter, dot, or underscore.
#****
#****v* Globals/RELEASE
# DESCRIPTION
Thanks. But that's not quite right either, since we currently allow '+'
in version.
I revised [1] a bit to mention what I think the valid character set is,
and disallow a hyphen in version. It might make sense to point to that
from NAME, VERSION, RELEASE in the cygport documentation, rather than
repeat it.
(That's assuming I've got the intersection of what's valid in cygport,
calm and setup correct, of course)
