Re: [PATCH] Bigger Chooser 2

2003-04-01 Thread Max Bowsher
Gary R. Van Sickle wrote: Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! - int i; - for (i = 0; i NumPropPages; i++) + unmixed int i; + for (i = 0; i PropertyPages.size(); i++) Gary, what is an unmixed int? :-) I think it's a C99-ism. Not a moment too soon

Re: [PATCH] Bigger Chooser 2

2003-03-31 Thread Max Bowsher
Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! - int i; - for (i = 0; i NumPropPages; i++) + unmixed int i; + for (i = 0; i PropertyPages.size(); i++) Gary, what is an unmixed int? :-) Max.

Re: [PATCH] Bigger Chooser 2

2003-03-31 Thread Max Bowsher
Max Bowsher wrote: Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! - int i; - for (i = 0; i NumPropPages; i++) + unmixed int i; + for (i = 0; i PropertyPages.size(); i++) Gary, what is an unmixed int? :-) Gary, and everyone, please ignore me. I guess I should

Re: [PATCH] Bigger Chooser 2

2003-03-31 Thread Christopher Faylor
On Mon, Mar 31, 2003 at 11:53:50PM +0100, Max Bowsher wrote: Max Bowsher wrote: Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! - int i; - for (i = 0; i NumPropPages; i++) + unmixed int i; + for (i = 0; i PropertyPages.size(); i++) Gary, what is an unmixed int? :-)

RE: [PATCH] Bigger Chooser 2

2003-03-31 Thread Gary R. Van Sickle
Gary - you sound like you're beginning to become somewhat frustrated with this process. Am I that transparent? ;-) Yeah, there's definite frustration here. I'm one of those sickos that do this sort of thing for fun. Battling over the size of a patch ain't fun. It ain't even work - I've

RE: [PATCH] Bigger Chooser 2

2003-03-31 Thread Gary R. Van Sickle
Max Bowsher wrote: Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! - int i; - for (i = 0; i NumPropPages; i++) + unmixed int i; + for (i = 0; i PropertyPages.size(); i++) Gary, what is an unmixed int? :-) Gary, and everyone, please ignore me. I

RE: [PATCH] Bigger Chooser 2

2003-03-31 Thread Gary R. Van Sickle
Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! - int i; - for (i = 0; i NumPropPages; i++) + unmixed int i; + for (i = 0; i PropertyPages.size(); i++) Gary, what is an unmixed int? :-) I think it's a C99-ism. Not a moment too soon either, I hate it when my ints

RE: [PATCH] Bigger Chooser 2

2003-03-30 Thread Gary R. Van Sickle
This is the first-take review: rectcc.h contains a class RECTPP. I *think* I posted my preference here for file names - that is after the class. I don't recall that, though I certainly could have missed it. So: RECTPP.h would be the correct name. Having said that RECTPP is not any of

RE: [PATCH] Bigger Chooser 2

2003-03-30 Thread Robert Collins
On Sun, 2003-03-30 at 18:20, Gary R. Van Sickle wrote: So: RECTPP.h would be the correct name. Having said that RECTPP is not any of the ok naming conventions for classes. A quick recap: The GNU standards are acceptable, even though I think their application to C++ is less than

Re: [PATCH] Bigger Chooser 2

2003-03-30 Thread Charles Wilson
Gary - you sound like you're beginning to become somewhat frustrated with this process. I just wanted to encourage you to keep at it; your contributions are valuable and I look forward (eventually g) to seeing them integrated into setup. --Chuck

RE: [PATCH] Bigger Chooser 2

2003-03-29 Thread Gary R. Van Sickle
On Sat, 2003-03-29 at 17:24, Gary R. Van Sickle wrote: it's too big for a single commit. I'd like you to start sending in the bits that you can, in a single-patch-does-a-single-conceptual-change style. Those I can review and approve for Max or I to checkin. Are you

RE: [PATCH] Bigger Chooser 2

2003-03-29 Thread Robert Collins
On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote: Yes. I've never liked 100K patches, even when I do them. The source patch plus the new source file is only 50k total, at least 31k of which is solely bigger-chooser (primarily res.rc, proppage.{cc,h}, propsheet.{cc,h}, Window.{cc,h})

Re: [PATCH] Bigger Chooser 2

2003-03-29 Thread Robert Collins
This is the first-take review: rectcc.h contains a class RECTPP. I *think* I posted my preference here for file names - that is after the class. So: RECTPP.h would be the correct name. Having said that RECTPP is not any of the ok naming conventions for classes. A quick recap: The GNU standards

RE: [PATCH] Bigger Chooser 2

2003-03-29 Thread Gary R. Van Sickle
On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote: Yes. I've never liked 100K patches, even when I do them. The source patch plus the new source file is only 50k total, at least 31k of which is solely bigger-chooser (primarily res.rc, proppage.{cc,h}, propsheet.{cc,h},

Re: [PATCH] Bigger Chooser 2

2003-03-28 Thread Robert Collins
On Fri, 2003-03-28 at 17:44, Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! Changes from the last patch: - Finish problem fixed. - Back button on splash page disabled again. - Bonus: two new icon resolutions! Only known problem is the bottom separator line still goes

RE: [PATCH] Bigger Chooser 2

2003-03-28 Thread Gary R. Van Sickle
On Fri, 2003-03-28 at 17:44, Gary R. Van Sickle wrote: Bigger and better than ever baby YEAH! Changes from the last patch: - Finish problem fixed. - Back button on splash page disabled again. - Bonus: two new icon resolutions! Only known problem is the bottom separator line

RE: [PATCH] Bigger Chooser 2

2003-03-28 Thread Robert Collins
On Sat, 2003-03-29 at 17:24, Gary R. Van Sickle wrote: it's too big for a single commit. I'd like you to start sending in the bits that you can, in a single-patch-does-a-single-conceptual-change style. Those I can review and approve for Max or I to checkin. Are you saying you