RE: [PATCH] High priority bugfix for setup.exe

Original Message >From: Max Bowsher >Sent: 18 April 2005 12:07 > Dave Korn wrote: >> Original Message >>> From: Max Bowsher >>> Sent: 18 April 2005 11:45 >> >>> >>> Second, the bug is only present on trunk, not on the release branch. >>> >> >> Release branch? Is that the setu

Re: [PATCH] High priority bugfix for setup.exe

Dave Korn wrote: Original Message From: Max Bowsher Sent: 18 April 2005 11:45 Second, the bug is only present on trunk, not on the release branch. Release branch? Is that the setup-200205 branch? You mean there's three years-worth of development that isn't getting released? Including a

RE: [PATCH] High priority bugfix for setup.exe

Original Message >From: Max Bowsher >Sent: 18 April 2005 11:45 > > Second, the bug is only present on trunk, not on the release branch. > Release branch? Is that the setup-200205 branch? You mean there's three years-worth of development that isn't getting released? Including all yo

Re: [PATCH] High priority bugfix for setup.exe

Max Bowsher wrote: Dave Korn wrote: Heh, guess how nicely this:- virtual void visitFile(String const &basePath, const WIN32_FIND_DATA *theFile) { String fileName(theFile->cFileName); if (fileName.substr(fileName.size() - 5) == ".done") return; bit of code plays with the file /

RE: [PATCH] High priority bugfix for setup.exe

Original Message >From: Max Bowsher >Sent: 18 April 2005 10:27 > Dave Korn wrote: >> Heh, guess how nicely this:- >> >> virtual void visitFile(String const &basePath, const WIN32_FIND_DATA >>*theFile) { >> String fileName(theFile->cFileName); >> if (fileName.substr(fileNam

Re: [PATCH] High priority bugfix for setup.exe

Dave Korn wrote: Heh, guess how nicely this:- virtual void visitFile(String const &basePath, const WIN32_FIND_DATA *theFile) { String fileName(theFile->cFileName); if (fileName.substr(fileName.size() - 5) == ".done") return; bit of code plays with the file /etc/postinstall/d.s

RE: [PATCH] High priority bugfix for setup.exe

Original Message >From: Igor Pechtchanski >Sent: 18 April 2005 05:26 > On Mon, 18 Apr 2005, Dave Korn wrote: >> >> * postinstall.cc (RunFindVisitor::visitFile): Don't index off front >> of string if it's too short to possibly contain ".done". > > FYI:

Re: [PATCH] High priority bugfix for setup.exe

On Mon, 18 Apr 2005, Dave Korn wrote: > Heh, guess how nicely this:- > > virtual void visitFile(String const &basePath, const WIN32_FIND_DATA > *theFile) > { > String fileName(theFile->cFileName); > if (fileName.substr(fileName.size() - 5) == ".done") > return; > > bit

[PATCH] High priority bugfix for setup.exe

Heh, guess how nicely this:- virtual void visitFile(String const &basePath, const WIN32_FIND_DATA *theFile) { String fileName(theFile->cFileName); if (fileName.substr(fileName.size() - 5) == ".done") return; bit of code plays with the file /etc/postinstall/d.sh? (Hi