Re: [PATCH] In gcc 13, -Wall turns on -Woverloaded-virtual

2024-02-08 Thread Corinna Vinschen via Cygwin-apps
On Feb 8 16:07, Jon Turney via Cygwin-apps wrote: > On 07/02/2024 10:46, Corinna Vinschen via Cygwin-apps wrote: > > Also fix ambiguous method declaration by dropping a default parameter. > > --- > > Hi Jon, > > > > I'm not sure removing virtual from all Create methods really fits the > > bill

Re: [PATCH] In gcc 13, -Wall turns on -Woverloaded-virtual

2024-02-08 Thread Jon Turney via Cygwin-apps
On 07/02/2024 10:46, Corinna Vinschen via Cygwin-apps wrote: Also fix ambiguous method declaration by dropping a default parameter. --- Hi Jon, I'm not sure removing virtual from all Create methods really fits the bill in all cases, are you? I had a go at fixing this while keeping the

[PATCH] In gcc 13, -Wall turns on -Woverloaded-virtual

2024-02-07 Thread Corinna Vinschen via Cygwin-apps
Also fix ambiguous method declaration by dropping a default parameter. --- Hi Jon, I'm not sure removing virtual from all Create methods really fits the bill in all cases, are you? I had a go at fixing this while keeping the virtuality of the methods intact. While at it it also occured to me