Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3

2003-03-25 Thread Igor Pechtchanski
On Tue, 25 Mar 2003, Max Bowsher wrote: > > On 25 Mar 2003, Robert Collins wrote: > > > >> Max, can you please check this in? > > Done. Thanks. > Igor: One very, very, very minor point - please put *2* spaces between your > name and email address in ChangeLogs. > > Thanks, > Max. Sure. Didn't

Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3

2003-03-25 Thread Max Bowsher
Igor Pechtchanski wrote: > On 25 Mar 2003, Robert Collins wrote: > >> + for (i = packages.begin (); i != packages.end (); ++i) >> +{ >> + packagemeta & pkg = **i; >> + for_each (pkg.installed.scripts().begin(), >> pkg.installed.scripts().end(), + RunScript(pkg.name, >>

Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3

2003-03-25 Thread Igor Pechtchanski
On 25 Mar 2003, Robert Collins wrote: > + for (i = packages.begin (); i != packages.end (); ++i) > +{ > + packagemeta & pkg = **i; > + for_each (pkg.installed.scripts().begin(), pkg.installed.scripts().end(), > + RunScript(pkg.name, pkg.installed.scripts().size())); >

Re: [PATCH] Run postinstall scripts in a thread with progress bars- take 3

2003-03-25 Thread Robert Collins
+ for (i = packages.begin (); i != packages.end (); ++i) +{ + packagemeta & pkg = **i; + for_each (pkg.installed.scripts().begin(), pkg.installed.scripts().end(), + RunScript(pkg.name, pkg.installed.scripts().size())); + ++k; + Progress.SetBar2 (k, numpkg); +

Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3

2003-03-24 Thread Igor Pechtchanski
On Mon, 24 Mar 2003, Igor Pechtchanski wrote: > On 25 Mar 2003, Robert Collins wrote: > > > On Tue, 2003-03-25 at 11:00, Igor Pechtchanski wrote: > > > > run_package_scripts cries our for a helper class IMO. > > > > > > > > i.e. ScriptRunner with > > > > a) constructor > > > > b) destructor > > >

Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3

2003-03-24 Thread Igor Pechtchanski
On 25 Mar 2003, Robert Collins wrote: > On Tue, 2003-03-25 at 11:00, Igor Pechtchanski wrote: > > > > 3) reused in RunFindVisitor. > > > > No. In fact, the code currently in RunFindVisitor is broken and will not > > work if there are subdirectories under /etc/postinstall. What I would > > like t

Re: [PATCH] Run postinstall scripts in a thread with progress bars- take 3

2003-03-24 Thread Robert Collins
On Tue, 2003-03-25 at 11:00, Igor Pechtchanski wrote: > > 3) reused in RunFindVisitor. > > No. In fact, the code currently in RunFindVisitor is broken and will not > work if there are subdirectories under /etc/postinstall. What I would > like to do (in a separate patch) is change FindVisitor s

Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3

2003-03-24 Thread Igor Pechtchanski
On 25 Mar 2003, Robert Collins wrote: > On Tue, [EMAIL PROTECTED]:48, Igor Pechtchanski wrote: > > On 21 Mar 2003, Robert Collins wrote: > > Rob, > > > > I wanted (and still want) to keep the two bar progress on this. The > > second bar would show progress through packages, and the first - progre

Re: [PATCH] Run postinstall scripts in a thread with progress bars- take 3

2003-03-24 Thread Robert Collins
On Tue, 2003-03-25 at 09:48, Igor Pechtchanski wrote: > On 21 Mar 2003, Robert Collins wrote: > Rob, > > I wanted (and still want) to keep the two bar progress on this. The > second bar would show progress through packages, and the first - progress > through the scripts *in the current package*.

Re: [PATCH] Run postinstall scripts in a thread with progress bars - take 3

2003-03-24 Thread Igor Pechtchanski
On 21 Mar 2003, Robert Collins wrote: > On Fri, 2003-03-21 at 08:49, Igor Pechtchanski wrote: > > On 21 Mar 2003, Robert Collins wrote: > > > > > On Fri, 2003-03-21 at 04:49, Igor Pechtchanski wrote: > > > > > > > Same as above, but regenerated against HEAD. ChangeLog is the same. > > > > The onl