Re: [PATCH] peflags: add support for IMAGE_DLLCHARACTERISTICS_GUARD_CF

2023-04-17 Thread Corinna Vinschen via Cygwin-apps
Hi Christoph, your patch looks good and I'm happy to merge it into peflags, but... On Apr 17 09:48, Christoph Reiter via Cygwin-apps wrote: > Jeremy noted that an option already exists in genpeimage [0] but with > a different name, which I wasn't aware of: -c/control-flow-guard, > instead of

Re: [PATCH] peflags: add support for IMAGE_DLLCHARACTERISTICS_GUARD_CF

2023-04-17 Thread Christoph Reiter via Cygwin-apps
Jeremy noted that an option already exists in genpeimage [0] but with a different name, which I wasn't aware of: -c/control-flow-guard, instead of -g/guard-cf which I used here. I'm open to making them match. [0]

[PATCH] peflags: add support for IMAGE_DLLCHARACTERISTICS_GUARD_CF

2023-04-16 Thread Christoph Reiter via Cygwin-apps
This allows for setting, clearing, and displaying the value of the "control flow guard" dll characteristics flag. For the option naming something like cfguard would probably be easier to understand, but the MSVC flag is "/guard:cf" and the macro contains GUARD_CF, so use "guard-cf" for