Re: [PATCH] setup: add Size column to chooser (take 2)

2005-06-19 Thread Max Bowsher
Igor Pechtchanski wrote: Here's a new iteration of this patch. It incorporates Max's review and adds comments in the size computation logic. The size is now computed as follows: if the binary or the source package is selected, the total size of the selected packages is used. Otherwise, the

Re: [PATCH] setup: add Size column to chooser (take 2)

2005-06-19 Thread Igor Pechtchanski
On Mon, 20 Jun 2005, Max Bowsher wrote: Igor Pechtchanski wrote: Here's a new iteration of this patch. It incorporates Max's review and adds comments in the size computation logic. The size is now computed as follows: if the binary or the source package is selected, the total size of

Re: [PATCH] setup: add Size column to chooser

2005-05-24 Thread Max Bowsher
Igor Pechtchanski wrote: As promised earlier, here's a patch against the current CVS that adds the Size column to the setup chooser screen, showing the size of the package tarball(s). It seems to work well for me. Two caveats: since the size information is extracted from setup.ini, if a

Re: [PATCH] setup: add Size column to chooser

2005-05-24 Thread Igor Pechtchanski
On Tue, 24 May 2005, Max Bowsher wrote: Igor Pechtchanski wrote: As promised earlier, here's a patch against the current CVS that adds the Size column to the setup chooser screen, showing the size of the package tarball(s). It seems to work well for me. Two caveats: since the size

[PATCH] setup: add Size column to chooser (take 2)

2005-05-24 Thread Igor Pechtchanski
Here's a new iteration of this patch. It incorporates Max's review and adds comments in the size computation logic. The size is now computed as follows: if the binary or the source package is selected, the total size of the selected packages is used. Otherwise, the size of the binary package is

Re: [PATCH] setup: add Size column to chooser

2005-05-24 Thread Christopher Faylor
On Tue, May 24, 2005 at 12:12:33PM +0100, Max Bowsher wrote: I've wondered sometimes if perhaps source handling should be removed entirely from the main package picker. I think it would be a good idea to move it to another screen or even to provide a URL and let the user download it manually.

[PATCH] setup: add Size column to chooser

2005-05-23 Thread Igor Pechtchanski
As promised earlier, here's a patch against the current CVS that adds the Size column to the setup chooser screen, showing the size of the package tarball(s). It seems to work well for me. Two caveats: since the size information is extracted from setup.ini, if a package is not in setup.ini, the