Re: [PATCH] src_postinst.cygpart: Sanitize binary data in bash command subst

2017-01-17 Thread Yaakov Selkowitz
On 2016-12-16 15:09, Eric Blake wrote: On 12/16/2016 02:40 PM, Eric Blake wrote: bash 4.4 now warns about skipping NUL bytes in $(command), since command substitution is only well-formed for commands that output text, but NUL bytes are not text. Silence the warning by removing NUL bytes from th

Re: [PATCH] src_postinst.cygpart: Sanitize binary data in bash command subst

2017-01-15 Thread Achim Gratz
Eric Blake writes: > On 12/16/2016 02:40 PM, Eric Blake wrote: > And of course, reading this in isolation, we could shave a process or > two by merging the two case statements into one, if you want to go one > step further as a micro-optimization: I've rolled to two patches into one and applied on

Re: [PATCH] src_postinst.cygpart: Sanitize binary data in bash command subst

2016-12-16 Thread Eric Blake
On 12/16/2016 02:40 PM, Eric Blake wrote: > bash 4.4 now warns about skipping NUL bytes in $(command), since > command substitution is only well-formed for commands that output > text, but NUL bytes are not text. Silence the warning by removing > NUL bytes from the stream before bash can see them.

Re: [PATCH] src_postinst.cygpart: Sanitize binary data in bash command subst

2016-12-16 Thread Eric Blake
On 12/16/2016 02:40 PM, Eric Blake wrote: > bash 4.4 now warns about skipping NUL bytes in $(command), since > command substitution is only well-formed for commands that output > text, but NUL bytes are not text. Silence the warning by removing > NUL bytes from the stream before bash can see them.

[PATCH] src_postinst.cygpart: Sanitize binary data in bash command subst

2016-12-16 Thread Eric Blake
bash 4.4 now warns about skipping NUL bytes in $(command), since command substitution is only well-formed for commands that output text, but NUL bytes are not text. Silence the warning by removing NUL bytes from the stream before bash can see them. --- lib/src_postinst.cygpart | 4 ++-- 1 file ch