Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-28 Thread Ken Brown
On 11/28/2017 7:58 AM, Ken Brown wrote: On 11/27/2017 9:14 PM, Ken Brown wrote: On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-28 Thread Ken Brown
On 11/27/2017 9:14 PM, Ken Brown wrote: On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage at the end of the "extrakeys" setting tha

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-27 Thread Ken Brown
On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage at the end of the "extrakeys" setting that was written into setup.rc.  Fix this by

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-27 Thread Jon Turney
On 27/11/2017 21:35, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL. This led to garbage at the What...?!? /* * It stores them all in a contiguous memory buffer. Each is one line of * ASCII text terminated b

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-27 Thread Ken Brown
On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL. This led to garbage at the end of the "extrakeys" setting that was written into setup.rc. Fix this by replacing the final LF by NUL before cal

[PATCH setup] Don't write garbage into the "extrakeys" user setting

2017-11-27 Thread Ken Brown
The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL. This led to garbage at the end of the "extrakeys" setting that was written into setup.rc. Fix this by replacing the final LF by NUL before calling set(). --- KeysSetting.cc | 6 +-