Re: [PATCH setup] site.cc, site.h: code cleanup

2017-11-23 Thread Ken Brown
On 11/22/2017 12:02 PM, Jon Turney wrote: On 20/11/2017 01:26, Ken Brown wrote: Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Please tell me we're not actually using a placement new for these things :S Add a bool member 'is_official' to the site_

Re: [PATCH setup] site.cc, site.h: code cleanup

2017-11-22 Thread Jon Turney
On 20/11/2017 01:26, Ken Brown wrote: Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Please tell me we're not actually using a placement new for these things :S Add a bool member 'is_official' to the site_list_type class. Use it to distinguish off

[PATCH setup] site.cc, site.h: code cleanup

2017-11-19 Thread Ken Brown
Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Add a bool member 'is_official' to the site_list_type class. Use it to distinguish official mirrors (listed in mirrors.lst) from user-added sites. This replaces the (undocumented) use of site_list_type::s