Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-05-03 Thread Brian Inglis via Cygwin-apps
On 2023-04-30 12:25, Jon Turney wrote: On 28/04/2023 06:51, Brian Inglis wrote: On 2023-04-27 10:11, Jon Turney wrote: [...] I think this functionality needs to exist in setup as well, though, as calm can't possibly have knowledge of packages you might be installing from 3rd party overlay

Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-04-30 Thread Jon Turney via Cygwin-apps
On 28/04/2023 06:51, Brian Inglis via Cygwin-apps wrote: On 2023-04-27 10:11, Jon Turney via Cygwin-apps wrote: [...] I think this functionality needs to exist in setup as well, though, as calm can't possibly have knowledge of packages you might be installing from 3rd party overlay package

Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-04-27 Thread Brian Inglis via Cygwin-apps
On 2023-04-27 10:11, Jon Turney via Cygwin-apps wrote: On 24/04/2023 19:16, Achim Gratz via Cygwin-apps wrote: Corinna Vinschen via Cygwin-apps writes: Calm could create a database containing all the files from the tar archives it uploads, and compare that against the newly uploaded files on

Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-04-27 Thread Jon Turney via Cygwin-apps
On 24/04/2023 19:16, Achim Gratz via Cygwin-apps wrote: Corinna Vinschen via Cygwin-apps writes: Calm could create a database containing all the files from the tar archives it uploads, and compare that against the newly uploaded files on the fly. That already exists as the basis for package

Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-04-24 Thread Achim Gratz via Cygwin-apps
Corinna Vinschen via Cygwin-apps writes: > Calm could create a database containing all the files from the tar > archives it uploads, and compare that against the newly uploaded files > on the fly. That already exists as the basis for package grep, albeit in the form of a buiinch of text files.

Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-04-24 Thread Corinna Vinschen via Cygwin-apps
Hi Jon, On Apr 23 15:43, Jon Turney via Cygwin-apps wrote: > This is a woefully underoptimized implementation of detecting filename > collisions between packages, so it's hidden behind the command line option > '--collisions' to enable it. > > A good implementation probably (i) collects the

[PATCH setup 0/2] Detect filename collisions between packages

2023-04-23 Thread Jon Turney via Cygwin-apps
This is a woefully underoptimized implementation of detecting filename collisions between packages, so it's hidden behind the command line option '--collisions' to enable it. A good implementation probably (i) collects the filenames at the same time as checksumming the archive, or has them