Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-17 Thread Jon Turney
On 16/05/17 18:05, Åke Rehnman wrote: On 2017-05-16 16:00, Jon Turney wrote: I am a bit confused about the behaviour I'm seeing, though. I'm expecting "file:///c:/path" and "file://host/path" to work, but they don't seem to. Same behavior here... Since those are apparently the correct form o

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-16 Thread Jon Turney
On 04/05/2017 11:11, Jon Turney wrote: On 03/05/2017 18:08, Åke Rehnman wrote: On 2017-05-03 18:37, Jon Turney wrote: * Allow wininet to handle file:// URLs I'm a little bit concerned that there may be current uses which rely on the incorrect parsing we do of file:// URLs to work. Otoh, this

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-04 Thread Jon Turney
On 03/05/2017 18:08, Åke Rehnman wrote: On 2017-05-03 18:37, Jon Turney wrote: Thanks for the patch. So there are a few separate things here: * Pass unknown protocols to wininet This seems a fine idea, but isn't what this patch does. Yea, I know, I tested a few different solutions but it was

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-03 Thread Jon Turney
On 02/05/2017 20:29, Åke Rehnman wrote: One thought though, why not let wininet take care of file:// URL's as well? Or actually don't try to parse the url string at all and just pass it down to NETIO_IE5 unfiltered? The advantage is setup would be able to I'd be happy to look at a separate patc

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-03 Thread Jon Turney
On 03/05/2017 08:22, Brian Inglis wrote: On 2017-05-02 05:05, Jon Turney wrote: On 02/05/2017 08:28, Åke Rehnman wrote: On 2017-05-01 22:45, Jon Turney wrote: I'm pretty sure I've done that in the past, so I think it already works. The form of file: URL required might not be strictly correct,

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-03 Thread Brian Inglis
On 2017-05-02 05:05, Jon Turney wrote: > On 02/05/2017 08:28, Åke Rehnman wrote: >> On 2017-05-01 22:45, Jon Turney wrote: > I'm pretty sure I've done that in the past, so I think it already > works. The form of file: URL required might not be strictly correct, > though, (I think file:server/

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-02 Thread Åke Rehnman
Hi, One thought though, why not let wininet take care of file:// URL's as well? Or actually don't try to parse the url string at all and just pass it down to NETIO_IE5 unfiltered? The advantage is setup would be able to I'd be happy to look at a separate patch to do this. See proposed increme

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-02 Thread Jon Turney
On 02/05/2017 08:28, Åke Rehnman wrote: Hello all, On 2017-05-01 22:45, Jon Turney wrote: It seems this could be an existing bug which could have been triggered the proxy case. The attached incremental patch fixed this for me. Seem to work fine for https and ftp now, I don't have the means t

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-02 Thread Åke Rehnman
Hello all, On 2017-05-01 22:45, Jon Turney wrote: It seems this could be an existing bug which could have been triggered the proxy case. The attached incremental patch fixed this for me. Seem to work fine for https and ftp now, I don't have the means to test ftps yet. One thought though,

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-01 Thread Jon Turney
On 01/05/2017 16:30, Åke Rehnman wrote: Hello, I tested with my repo and it seem to fail if there is no setup.xz but only setup.ini. It does quickly realize there are no setup.xz and setup.xz.sig but then it takes forever to get past setup.bz2 etc and fails to download setup.ini These tests wer

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-01 Thread Åke Rehnman
Hello, I tested with my repo and it seem to fail if there is no setup.xz but only setup.ini. It does quickly realize there are no setup.xz and setup.xz.sig but then it takes forever to get past setup.bz2 etc and fails to download setup.ini These tests were done with -X flag. I will email th

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-05-01 Thread Jon Turney
On 29/04/2017 11:53, Jon Turney wrote: On 28/04/2017 16:33, Åke Rehnman wrote: On 2017-04-28 14:12, Jon Turney wrote: From the discussion in [1], I was somewhat surprised to learn that setup doesn't support https or ftps. For the same exact reason I've just recently patched in curl I'd b

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-04-29 Thread Jon Turney
On 28/04/2017 16:33, Åke Rehnman wrote: On 2017-04-28 14:12, Jon Turney wrote: From the discussion in [1], I was somewhat surprised to learn that setup doesn't support https or ftps. For the same exact reason I've just recently patched in curl I'd be very interested to see that patch :)

Re: [PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-04-28 Thread Åke Rehnman
Hi, On 2017-04-28 14:12, Jon Turney wrote: From the discussion in [1], I was somewhat surprised to learn that setup doesn't support https or ftps. For the same exact reason I've just recently patched in curl Problems with this patch: No progress feedback as we download. We just get han

[PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

2017-04-28 Thread Jon Turney
>From the discussion in [1], I was somewhat surprised to learn that setup doesn't support https or ftps. Switch to using wininet for fetching URLs in the direct (non-proxy) case, as well. (It's already used in proxy case). This allows https and ftps protocols to be used. For the moment, we keep a