Curious code in Installer::installOneSource

2003-04-05 Thread Max Bowsher
I'm working in this area to implement the MD5-on-install feature. Is there any reason why I should not simplify this: char msg[64]; strcpy (msg, "Installing"); Progress.SetText1 (msg); log (LOG_PLAIN, String (msg) + " " + source.Cached ()); To this: char msg[] = "Installing"; Progress.SetText1 (m

Re: Curious code in Installer::installOneSource

2003-04-05 Thread Igor Pechtchanski
On Sat, 5 Apr 2003, Max Bowsher wrote: > I'm working in this area to implement the MD5-on-install feature. Is there > any reason why I should not simplify this: > > char msg[64]; > strcpy (msg, "Installing"); > Progress.SetText1 (msg); > log (LOG_PLAIN, String (msg) + " " + source.Cached ()); > >

Re: Curious code in Installer::installOneSource

2003-04-05 Thread Robert Collins
On Sun, 2003-04-06 at 08:38, Max Bowsher wrote: > I'm working in this area to implement the MD5-on-install feature. Is there > any reason why I should not simplify this: From memory there was either a const correctness issue, or a funny optimiser bug. Lets keep non-related bugfixes to HEAD though.