On Fri, 2003-03-28 at 17:44, Gary R. Van Sickle wrote:
> Bigger and better than ever baby YEAH!
>
> Changes from the last patch:
> - Finish problem fixed.
> - "Back" button on splash page disabled again.
> - Bonus: two new icon resolutions!
>
> Only known problem is the bottom separator line stil
> On Fri, 2003-03-28 at 17:44, Gary R. Van Sickle wrote:
> > Bigger and better than ever baby YEAH!
> >
> > Changes from the last patch:
> > - Finish problem fixed.
> > - "Back" button on splash page disabled again.
> > - Bonus: two new icon resolutions!
> >
> > Only known problem is the bottom s
On Sat, 2003-03-29 at 17:24, Gary R. Van Sickle wrote:
> >
> > it's too big for a single commit. I'd like you to start sending in the
> > bits that you can, in a
> > single-patch-does-a-single-conceptual-change style.
> >
> > Those I can review and approve for Max or I to checkin.
> >
>
> Are
> On Sat, 2003-03-29 at 17:24, Gary R. Van Sickle wrote:
> > >
>
> > > it's too big for a single commit. I'd like you to start sending in the
> > > bits that you can, in a
> > > single-patch-does-a-single-conceptual-change style.
> > >
> > > Those I can review and approve for Max or I to checkin.
>
On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote:
> > Yes. I've never liked 100K patches, even when I do them.
> >
>
> The source patch plus the new source file is only 50k total, at least 31k of
> which is solely bigger-chooser (primarily res.rc, proppage.{cc,h},
> propsheet.{cc,h}, Window.
This is the first-take review:
rectcc.h contains a class RECTPP. I *think* I posted my preference here
for file names - that is after the class.
So:
RECTPP.h would be the correct name.
Having said that RECTPP is not any of the ok naming conventions for
classes.
A quick recap:
The GNU standards
On Sun, 2003-03-30 at 16:20, Gary R. Van Sickle wrote:
> > On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote:
> >
> > > > Yes. I've never liked 100K patches, even when I do them.
> > > >
> > >
> > > The source patch plus the new source file is only 50k total, at least 31k of
> > > which is sole
> On Sat, 2003-03-29 at 19:30, Gary R. Van Sickle wrote:
>
> > > Yes. I've never liked 100K patches, even when I do them.
> > >
> >
> > The source patch plus the new source file is only 50k total, at least 31k of
> > which is solely bigger-chooser (primarily res.rc, proppage.{cc,h},
> > propsheet.{
> This is the first-take review:
>
> rectcc.h contains a class RECTPP. I *think* I posted my preference here
> for file names - that is after the class.
>
I don't recall that, though I certainly could have missed it.
> So:
> RECTPP.h would be the correct name.
>
> Having said that RECTPP is not a
On Sun, 2003-03-30 at 18:20, Gary R. Van Sickle wrote:
> > So:
> > RECTPP.h would be the correct name.
> >
> > Having said that RECTPP is not any of the ok naming conventions for
> > classes.
> >
> > A quick recap:
> > The GNU standards are acceptable, even though I think their application
> > to
Gary -
you sound like you're beginning to become somewhat frustrated with this
process. I just wanted to encourage you to keep at it; your
contributions are valuable and I look forward (eventually ) to seeing
them integrated into setup.
--Chuck
Gary R. Van Sickle wrote:
> Bigger and better than ever baby YEAH!
- int i;
- for (i = 0; i < NumPropPages; i++)
+ unmixed int i;
+ for (i = 0; i < PropertyPages.size(); i++)
Gary, what is an unmixed int? :-)
Max.
Max Bowsher wrote:
> Gary R. Van Sickle wrote:
>> Bigger and better than ever baby YEAH!
>
> - int i;
> - for (i = 0; i < NumPropPages; i++)
> + unmixed int i;
> + for (i = 0; i < PropertyPages.size(); i++)
>
> Gary, what is an unmixed int? :-)
Gary, and everyone, please ignore me.
I guess I
On Mon, Mar 31, 2003 at 11:53:50PM +0100, Max Bowsher wrote:
>Max Bowsher wrote:
>> Gary R. Van Sickle wrote:
>>> Bigger and better than ever baby YEAH!
>>
>> - int i;
>> - for (i = 0; i < NumPropPages; i++)
>> + unmixed int i;
>> + for (i = 0; i < PropertyPages.size(); i++)
>>
>> Gary, what i
> Gary -
>
> you sound like you're beginning to become somewhat frustrated with this
> process.
Am I that transparent? ;-)
Yeah, there's definite frustration here. I'm one of those sickos that do this
sort of thing for fun. Battling over the size of a patch ain't fun. It ain't
even work - I've
> Max Bowsher wrote:
> > Gary R. Van Sickle wrote:
> >> Bigger and better than ever baby YEAH!
> >
> > - int i;
> > - for (i = 0; i < NumPropPages; i++)
> > + unmixed int i;
> > + for (i = 0; i < PropertyPages.size(); i++)
> >
> > Gary, what is an unmixed int? :-)
>
> Gary, and everyone, plea
> Gary R. Van Sickle wrote:
> > Bigger and better than ever baby YEAH!
>
> - int i;
> - for (i = 0; i < NumPropPages; i++)
> + unmixed int i;
> + for (i = 0; i < PropertyPages.size(); i++)
>
> Gary, what is an unmixed int? :-)
I think it's a C99-ism. Not a moment too soon either, I hate it w
Gary R. Van Sickle wrote:
>> Gary R. Van Sickle wrote:
>>> Bigger and better than ever baby YEAH!
>>
>> - int i;
>> - for (i = 0; i < NumPropPages; i++)
>> + unmixed int i;
>> + for (i = 0; i < PropertyPages.size(); i++)
>>
>> Gary, what is an unmixed int? :-)
>
> I think it's a C99-ism. Not
18 matches
Mail list logo
