Re: Zstandard support for setup

2018-10-14 Thread Achim Gratz
Jon Turney writes: > Applied. > > I removed the commented out logging, updated build instructions and > build prerequisites installed in CI Great, thank you very much. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf rackAttack

Re: Zstandard support for setup

2018-10-13 Thread Jon Turney
On 10/10/2018 19:36, Achim Gratz wrote: Jon Turney writes: This should check for ztd in configure.ac using PKG_CHECK_MODULES, rather than just assuming -lzstd is going to work. Done. + using namespace std; Please don't Done.

Re: Zstandard support for setup

2018-10-10 Thread Achim Gratz
Jon Turney writes: > This should check for ztd in configure.ac using PKG_CHECK_MODULES, > rather than just assuming -lzstd is going to work. Done. > + using namespace std; > > Please don't Done. https://repo.or.cz/cygwin-setup/local.git/patch/fff4b1448072efe5ebb6549cfe04bc15344a3973 >

Re: Zstandard support for setup

2018-10-09 Thread Achim Gratz
Jon Turney writes: > On 02/09/2018 09:29, Achim Gratz wrote: >> Jon Turney writes: >>> This should check for ztd in configure.ac using PKG_CHECK_MODULES, >>> rather than just assuming -lzstd is going to work. >> >> Sure. Waiting for your patch to actually use pkg_config to rebase it >> onto. > >

Re: Zstandard support for setup

2018-10-09 Thread Achim Gratz
Jon Turney writes: > On 02/09/2018 18:02, Achim Gratz wrote: >> What an unholy mess… Here's that patch, only lightly tested: >> http://repo.or.cz/cygwin-setup/local.git/patch/e9802f50304f66984f6aad5544def465e9f8033b > > Yeah. Thanks, and sorry for the delay. No sweat and thanks. Regards, Achim.

Re: Zstandard support for setup

2018-10-07 Thread Jon Turney
On 02/09/2018 09:29, Achim Gratz wrote: Jon Turney writes: This should check for ztd in configure.ac using PKG_CHECK_MODULES, rather than just assuming -lzstd is going to work. Sure. Waiting for your patch to actually use pkg_config to rebase it onto. This is applied now. The setup

Re: Zstandard support for setup

2018-10-07 Thread Jon Turney
On 02/09/2018 18:02, Achim Gratz wrote: Achim Gratz writes: + using namespace std; Please don't That's a copy from the compress_xz files and it's used in many files elsewhere. Care to explain why you'd want it removed? If there's a good reason I'd tend to move this to a clean-up commit

Re: Zstandard support for setup

2018-09-02 Thread Achim Gratz
Achim Gratz writes: >> + using namespace std; >> >> Please don't > > That's a copy from the compress_xz files and it's used in many files > elsewhere. Care to explain why you'd want it removed? If there's a > good reason I'd tend to move this to a clean-up commit that touches all > those files.

Re: Zstandard support for setup

2018-09-02 Thread Achim Gratz
Jon Turney writes: > This should check for ztd in configure.ac using PKG_CHECK_MODULES, > rather than just assuming -lzstd is going to work. Sure. Waiting for your patch to actually use pkg_config to rebase it onto. > The setup executables are cross-built on Fedora, so a >

Re: Zstandard support for setup

2018-08-29 Thread Jon Turney
On 11/08/2018 20:52, Achim Gratz wrote: [...] The current code is available here: http://repo.or.cz/w/cygwin-setup/local.git Some comments: This should check for ztd in configure.ac using PKG_CHECK_MODULES, rather than just assuming -lzstd is going to work. The setup executables are

Re: Zstandard support for setup

2018-08-23 Thread Achim Gratz
[…] Here's a bit of support scaffolding for anybody who wants to play with this (if the looks of the scripts scare you, stay away from it :-), obviously you'll also need to compile yourself a setup.exe with the patches to use with. It assumes the Cygwin local repo files / cache in a directory

Re: Zstandard support for setup

2018-08-22 Thread Achim Gratz
Achim Gratz writes: > I've had 16 cores to run that on and those stayed at 2.8GHz all the > time, so it didn't take too long. Here at home I've tasked two slower > 4-core machines with it, so they were running a few hours of wall-time. > I might try long-range matching to get even better

Re: Zstandard support for setup

2018-08-20 Thread Achim Gratz
Marco Atzeri writes: > memory and time requirements seem not so appealing to me > as my machine has only 8GiB and already the debuginfo on 32bit is > a time consuming effort That happens only with ultra compression and long-range matching enabled. I've not run out of 6GiB memory across two

Re: Zstandard support for setup

2018-08-20 Thread Marco Atzeri
Am 17.08.2018 um 20:49 schrieb Achim Gratz: While it seems like I'm talking to myself, in case anybody is listening: I've had 16 cores to run that on and those stayed at 2.8GHz all the time, so it didn't take too long. Here at home I've tasked two slower 4-core machines with it, so they were

Re: Zstandard support for setup

2018-08-17 Thread Achim Gratz
While it seems like I'm talking to myself, in case anybody is listening: With the "normal" maximum compression level of 19 the package archive for my installation (including sources and debuginfo) got about 10% larger, taking about the same time as Xz for compression. Using the "ultra"

Re: Zstandard support for setup

2018-08-12 Thread Achim Gratz
Achim Gratz writes: > I've finally implemented ZStandard support for setup and tested it today > with a fresh install on a Celeron 1037U dual-core machine from and to > local SSD. The archive extraction part of setup went from taking 23 > minutes to about 14 minutes. This morning I'

Zstandard support for setup

2018-08-11 Thread Achim Gratz
I've finally implemented ZStandard support for setup and tested it today with a fresh install on a Celeron 1037U dual-core machine from and to local SSD. The archive extraction part of setup went from taking 23 minutes to about 14 minutes. A (much) faster machine at work did the same install