Re: src/winsup/w32api ChangeLog include/wingdi.h

2001-12-20 Thread Danny Smith
--- [EMAIL PROTECTED] wrote: > CVSROOT: /cvs/src > Module name: src > Changes by: [EMAIL PROTECTED]2001-12-20 22:53:57 > > Modified files: > winsup/w32api : ChangeLog > winsup/w32api/include: wingdi.h > > Log message: > 2001-12-21 Robert Collins <[EMAIL PROTECT

[W32API] att getrandomrgn

2001-12-20 Thread Robert Collins
I've checked this in. It's needed for setup.exe compilation. Rob 2001-12-21 Robert Collins <[EMAIL PROTECTED]> * include/wingdi.h: Add GetRandomRgn and SYSRGN. Index: include/wingdi.h === RCS file: /cvs/src/src/winsup/w3

[PATCH] Revert lib/Makefile.in to functional version

2001-12-20 Thread Christopher Faylor
The patch below reverts erroneous sections of lib/Makefile.in to functionality. We've gone back and forth about this section of code for a while. The bottom line is that it did not do the right thing for cross toolchains. This has caused me much grief within Red Hat so I need to change this on s

Re: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Robert Collins
- Original Message - From: "Gary R Van Sickle" <[EMAIL PROTECTED]> > > "Once virtual, always virtual", i.e., it isn't necessary to add "virtual" to > any overridden virtual functions, and in fact it's not possible to > "unvirtualize" once virtualized. I do try to maintain them as a stylis

RE: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Gary R Van Sickle
> Having had a good close look, there is a little more that is needed > before committing to CVS. > > 1) You've skipped at least one dialog - IDD_S_FROM_CWD - which is what > was breaking local_dir. Ok, I'll get that fixed tonight. > (Oh, and the functions weren't virtual in some > child classes

Re: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Robert Collins
Having had a good close look, there is a little more that is needed before committing to CVS. 1) You've skipped at least one dialog - IDD_S_FROM_CWD - which is what was breaking local_dir. (Oh, and the functions weren't virtual in some child classes :}). 2) See download.cc - is next_dialog still

Re: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Robert Collins
Last time around hopefully! 1) format your changelog with line wrap at 80 columns. 2) It's a changelog, so if you #if 0 and then remove a function during your local testing, the final change is actually just a remove. Likewise, chooser.[cc|h] should not be mentioned because it never exists (from