Re[2]: Cygwin 1.3.10 Setup.exe 2.194.2.22 Install Problems With MSVCRT.DLL and source code on Win98

2002-04-10 Thread Pavel Tsekov
Hello, there! :) Wednesday, April 10, 2002, 10:11:46 AM, you wrote: Ok, found it - its canonicalize_version() in version.cc. There is a pointer 'v' which is modified and then delete[]'d. A trivial patch is attached :) 2002-04-10 Pavel Tsekov <[EMAIL PROTECTED]> * version.cc (can

[PATCH]setup.exe: delete called for NULL pointer

2002-04-10 Thread Michael A Chase
I don't know if this delete call is a problem, but every other place I found delete called in the setup.exe source, the variable was either confirmed not NULL or the variable was certain to not be NULL. In this case, the variable either must be NULL or the buffer is too small. -- Mac :}) ** I nor

Re: [PATCH]setup.exe: delete called for NULL pointer

2002-04-10 Thread Michael A Chase
I don't know, but many other places where it is called, it's protected by if (var) delete[] var; -- Mac :}) ** I normally forward private questions to the appropriate mail list. ** Ask Smarter: http://www.tuxedo.org/~esr/faqs/smart-questions.html Give a hobbit a fish and he eats fish for

RE: [PATCH]setup.exe: delete called for NULL pointer

2002-04-10 Thread Robert Collins
> -Original Message- > From: Michael A Chase [mailto:[EMAIL PROTECTED]] > Sent: Thursday, April 11, 2002 7:51 AM > To: Pavel Tsekov > Cc: [EMAIL PROTECTED] > Subject: Re: [PATCH]setup.exe: delete called for NULL pointer > > > I don't know, but many other places where it is called, it'

Re: [PATCH]setup.exe: delete called for NULL pointer

2002-04-10 Thread Michael A Chase
From: "Robert Collins" <[EMAIL PROTECTED]> To: "Michael A Chase" <[EMAIL PROTECTED]>; "Pavel Tsekov" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Wednesday, April 10, 2002 16:03 Subject: RE: [PATCH]setup.exe: delete called for NULL pointer > From: Michael A Chase [mailto:[EMAIL PROTECTED]] >