Hi Pierre,
On Wed, Jun 11, 2003 at 11:03:36PM -0400, Pierre A. Humblet wrote:
Corinna,
Here is the patch to preserve the external token.
Looks good. I like especially the deimpersonate/reimpersonate methods.
You will see that cygwin_set_impersonation_token() should
now return a
Corinna Vinschen wrote:
You will see that cygwin_set_impersonation_token() should
now return a success/failure indication, instead of void.
That's not done yet, waiting for your opinion.
How do you intend to use that return value?
If changing the type to return a value is likely to
On Thu, Jun 12, 2003 at 12:01:31PM -0400, Pierre A. Humblet wrote:
If changing the type to return a value is likely to break
existing applications, I would no do it.
I don't think so. Well... it might in case the compiler's optimizer
relied somehow on the fact that the function didn't return a
Corinna Vinschen wrote:
On Thu, Jun 12, 2003 at 12:01:31PM -0400, Pierre A. Humblet wrote:
If changing the type to return a value is likely to break
existing applications, I would no do it.
I don't think so. Well... it might in case the compiler's optimizer
relied somehow on the fact
On Thu, Jun 12, 2003 at 12:56:31PM -0400, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
I don't understand what you mean. The call would nevertheless replace
the old token so what means noop here?
Nope, the old token isn't replaced (in the patch).
Ouch, I misread the patch. I'm not
Corinna,
consider the issue with cygwin_set_impersonation_token()
solved. I found a nice way out, leaving it void. I will
send a patch after the current one is taken care of.
Pierre
On Fri, May 16, 2003 at 02:12:16PM +0200, Thomas Pfaff wrote:
Thomas Pfaff wrote:
While single threaded apps should keep run without problems (_impure_ptr
is still used for the mainthread) multithreaded apps should be recompiled
to get the full power of the thread safe reents. This is due the
