[Patch] *** CreateFileMapping, Win32 error 5. Terminating.

2003-10-15 Thread Pierre A. Humblet
The background for this patch was just explained on the Cygwin mailing list. We must make sure that the user sid is present in the default DACL of impersonation tokens, internal as well as external. Thus the place to do it is in seteuid32(), and it becomes useless to create a default DACL in crea

Re: [Patch]: Ncurses frame drawing

2003-10-15 Thread Micha Nelissen
Corinna Vinschen wrote: On Wed, Oct 15, 2003 at 08:50:09AM +0200, Micha Nelissen wrote: Pierre A. Humblet wrote: FWIW, wouldn't it be cleaner to make "alternate_charset_active" a member of dev_state instead of introducing a new global variable? 1) that alternate_charset check which currently is

Re: [Patch]: Ncurses frame drawing

2003-10-15 Thread Christopher Faylor
On Wed, Oct 15, 2003 at 10:27:24AM +0200, Corinna Vinschen wrote: >On Wed, Oct 15, 2003 at 08:50:09AM +0200, Micha Nelissen wrote: >> Pierre A. Humblet wrote: >> >FWIW, wouldn't it be cleaner to make "alternate_charset_active" a >> >member of dev_state instead of introducing a new global variable?

Re: [Patch]: Ncurses frame drawing

2003-10-15 Thread Corinna Vinschen
On Wed, Oct 15, 2003 at 08:50:09AM +0200, Micha Nelissen wrote: > Pierre A. Humblet wrote: > >FWIW, wouldn't it be cleaner to make "alternate_charset_active" a > >member of dev_state instead of introducing a new global variable? > > Yes, although original_codepage was a viable candidate for a glo

Re: [Patch]: Ncurses frame drawing

2003-10-15 Thread Corinna Vinschen
Good idea, that. I've applied the patch with two small change: On Tue, Oct 14, 2003 at 10:26:27PM +0200, Micha Nelissen wrote: > Index: fhandler_console.cc > === > RCS file: /cvs/src/src/winsup/cygwin/fhandler_console.cc,v > retrievi