Re: [Patch]: Create Global Privilege

2003-11-25 Thread Christopher Faylor
On Tue, Nov 25, 2003 at 10:12:19PM -0500, Pierre A. Humblet wrote: >At 09:47 PM 11/25/2003 -0500, you wrote: >>On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote: >>>Other than that minor point, this looks ok. >> >>Sorry. On rereading this this sounded rather lukewarm. I'm very ha

Re: [Patch]: Create Global Privilege

2003-11-25 Thread Pierre A. Humblet
At 09:47 PM 11/25/2003 -0500, you wrote: >On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote: >>Other than that minor point, this looks ok. > >Sorry. On rereading this this sounded rather lukewarm. I'm very happy >that you are fixing this problem. I should probably let Corinna ha

Re: [Patch]: Create Global Privilege

2003-11-25 Thread Christopher Faylor
On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote: >Other than that minor point, this looks ok. Sorry. On rereading this this sounded rather lukewarm. I'm very happy that you are fixing this problem. I should probably let Corinna have the final word on this, though. Thanks. c

Re: [Patch]: Create Global Privilege

2003-11-25 Thread Christopher Faylor
On Tue, Nov 25, 2003 at 08:55:33PM -0500, Pierre A. Humblet wrote: >This patch will stop the "CreateFileMapping, Win32 error 5. Terminating." >complaints. > >It changes shared_name() to avoid setting the Global\ prefix on file mappings >when the Create Global Object privilege may be required but th

[Patch]: Create Global Privilege

2003-11-25 Thread Pierre A. Humblet
This patch will stop the "CreateFileMapping, Win32 error 5. Terminating." complaints. It changes shared_name() to avoid setting the Global\ prefix on file mappings when the Create Global Object privilege may be required but the user doesn't have it. Note that when running from the console or as