On Dec 14 06:02, Thomas Wolff wrote:
This is an update of my trivial patch that fixes
http://sourceware.org/bugzilla/show_bug.cgi?id=514
I guess the patch is pretty much ok and I'm inclined to let it pass
under the trivial patch rule... iff you change it so that the #ifdef
goes away.
On Thu, Dec 16, 2004 at 09:55:48AM -0500, Pierre A. Humblet wrote:
Here is an untested patch.
I hope Mark can test it (on managed and unmanaged mounts,
including basenames consisting entirely of dots and spaces)
and possibly make adjustments, without having to file the
paperwork.
Pierre
On Thu, Dec 16, 2004 at 07:59:05AM -0700, Mark Paulus wrote:
Other than the way I proposed, I'm not sure how to fix this, since the
issue seems to be that conv_to_win32_path() needs to get the trailing
dot in it's input argument, and check() is stripping it out. The only
way I can see to fix this
On Dec 16 10:00, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 09:55:48AM -0500, Pierre A. Humblet wrote:
Here is an untested patch.
I hope Mark can test it (on managed and unmanaged mounts,
including basenames consisting entirely of dots and spaces)
and possibly make adjustments, without
On Dec 16 10:57, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 04:53:39PM +0100, Corinna Vinschen wrote:
Since the mount code is called from path_conv anyway, wouldn't it be
better to pass the information managed mount or not up to path_conv?
How about just doing the pathname munging in
On Thu, Dec 16, 2004 at 05:03:22PM +0100, Corinna Vinschen wrote:
On Dec 16 10:57, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 04:53:39PM +0100, Corinna Vinschen wrote:
Since the mount code is called from path_conv anyway, wouldn't it be
better to pass the information managed mount or not
On Thu, Dec 16, 2004 at 09:23:56AM -0700, Mark Paulus wrote:
Which is why I did what I did. If you look, my patch allows for
checking to see if . was entered as an
argument, and throws the exception if it was. THEN, if that is not the
case, it passes the FULL name to
* path.cc (path_conv::check): retain trailing dots and spaces
* path.cc (mount_item::build_win32): strip trailing dots and spaces
for
unmanaged filesystems
path.cc.patch
Description: Binary data
Op Thu, 16 Dec 2004 21:02:05 -0500 schreef Christopher Faylor
in [EMAIL PROTECTED]:
: On Fri, Dec 17, 2004 at 02:04:40AM +0100, Buzz wrote:
: Here is another attempt at making eprintf a usable/used function in
: cygcheck. It this time just flushes stdout and stderr before/after
: output on
On Fri, Dec 17, 2004 at 03:51:47AM +0100, Bas van Gompel wrote:
Op Thu, 16 Dec 2004 21:02:05 -0500 schreef Christopher Faylor
in [EMAIL PROTECTED]:
: On Fri, Dec 17, 2004 at 02:04:40AM +0100, Buzz wrote:
: Here is another attempt at making eprintf a usable/used function in
: cygcheck. It this
On Thu, Dec 16, 2004 at 04:48:52PM -0700, Mark Paulus wrote:
* path.cc (path_conv::check): retain trailing dots and spaces
* path.cc (mount_item::build_win32): strip trailing dots and spaces
for
unmanaged filesystems
Thanks for the effort. You're working on some of the
At 11:06 AM 12/16/2004 -0500, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 05:03:22PM +0100, Corinna Vinschen wrote:
On Dec 16 10:57, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 04:53:39PM +0100, Corinna Vinschen wrote:
Since the mount code is called from path_conv anyway, wouldn't it
On Thu, Dec 16, 2004 at 10:26:27PM -0500, Christopher Faylor wrote:
I don't see how it could be correct for the slash checking code not to
be in the loop. Won't this cause a problem if you've done
Ah, nevermind. I see that your patch handles that.
cgf
Op Thu, 16 Dec 2004 21:56:07 -0500 schreef Christopher Faylor
in [EMAIL PROTECTED]:
: On Fri, Dec 17, 2004 at 03:51:47AM +0100, Bas van Gompel wrote:
[...]
: I seem to be making a mess here... The point is to have the error-messages
: appear at about the appropriate point in the output, not
At 10:27 PM 12/16/2004 -0500, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 10:26:27PM -0500, Christopher Faylor wrote:
I don't see how it could be correct for the slash checking code not to
be in the loop. Won't this cause a problem if you've done
Ah, nevermind. I see that your patch
On Thu, Dec 16, 2004 at 10:43:47PM -0500, Pierre A. Humblet wrote:
At 10:27 PM 12/16/2004 -0500, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 10:26:27PM -0500, Christopher Faylor wrote:
I don't see how it could be correct for the slash checking code not to
be in the loop. Won't this cause a
On Fri, Dec 17, 2004 at 04:33:10AM +0100, Bas van Gompel wrote:
Op Thu, 16 Dec 2004 21:56:07 -0500 schreef Christopher Faylor
in [EMAIL PROTECTED]:
: On Fri, Dec 17, 2004 at 03:51:47AM +0100, Bas van Gompel wrote:
[...]
: I seem to be making a mess here... The point is to have the
Here is an untested patch.
I hope Mark can test it (on managed and unmanaged mounts,
including basenames consisting entirely of dots and spaces)
and possibly make adjustments, without having to file the
paperwork.
Pierre
* path.cc (path_conv::check): Do not strip trailing dots and
On Thu, Dec 16, 2004 at 04:53:39PM +0100, Corinna Vinschen wrote:
On Dec 16 10:00, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 09:55:48AM -0500, Pierre A. Humblet wrote:
Here is an untested patch.
I hope Mark can test it (on managed and unmanaged mounts,
including basenames consisting
On Thu, Dec 16, 2004 at 11:06:07AM -0500, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 05:03:22PM +0100, Corinna Vinschen wrote:
On Dec 16 10:57, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 04:53:39PM +0100, Corinna Vinschen wrote:
Since the mount code is called from path_conv anyway,
cgf wrote:
Is it correct to assume that only fhandler_base::open cares about
trailing dots?
Good point. This bring back memories.
The initial motivation was to fix problems introduced by the
use of NtCreateFile
http://www.cygwin.com/ml/cygwin/2004-04/msg01250.html
and there were successive
On Thu, 16 Dec 2004 11:37:32 -0500, Christopher Faylor wrote:
On Thu, Dec 16, 2004 at 09:23:56AM -0700, Mark Paulus wrote:
Which is why I did what I did. If you look, my patch allows for
checking to see if . was entered as an
argument, and throws the exception if it
22 matches
Mail list logo
