[PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Igor Pechtchanski
As mentioned in , I noticed something strange in the "cygcheck -s" output: /usr/bin/cygrunsrv: Exactly one of --install, --remove, --start, --stop, --query, or --list is required Try `/usr/bin/cygrunsrv --help' for more information. strace shows

Re: [PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Brian Dessent
Igor Pechtchanski wrote: > As mentioned in , I > noticed something strange in the "cygcheck -s" output: This fix was part of my patch from June in but since it was grouped with the unrel

Re: [PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Brian Dessent
Brian Dessent wrote: > > why not simply run "cygrunsrv --list --verbose" in verbose mode, instead > > of actually going through one iteration of the loop? Simply to reuse the > > "copy output" code? Brian? > > The reason I did it that way is because if I had run "cygrunsrv --list Now that I re

Re: [PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Igor Pechtchanski
On Tue, 16 Aug 2005, Brian Dessent wrote: > Igor Pechtchanski wrote: > > > As mentioned in , I > > noticed something strange in the "cygcheck -s" output: > > This fix was part of my patch from June in >

Re: [PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Christopher Faylor
On Tue, Aug 16, 2005 at 07:17:17PM -0400, Igor Pechtchanski wrote: >Hmm, you should ping the list about it, then -- it's been what, two >months? There's no need to ping anybody. I do read this list and I haven't forgotten about the patch. If it didn't require changs to a file on sourceware.org,

Re: [PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Brian Dessent
Brian Dessent wrote: > Now that I re-read what you said I think I misunderstood. You're right, > it could have simply done Here is a patch that fixes both issues. Brian 2005-08-16 Brian Dessent <[EMAIL PROTECTED]> * cygcheck.cc (dump_sysinfo_services): Properly null-terminate 'buf'.

Re: [PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Christopher Faylor
On Tue, Aug 16, 2005 at 05:30:02PM -0700, Brian Dessent wrote: >Brian Dessent wrote: >>Now that I re-read what you said I think I misunderstood. You're >>right, it could have simply done > >Here is a patch that fixes both issues. > >2005-08-16 Brian Dessent <[EMAIL PROTECTED]> > >* cygcheck.cc (du

Re: [PATCH] Fix cygrunsrv invocation in cygcheck

2005-08-16 Thread Brian Dessent
Christopher Faylor wrote: > Go ahead and check this in. Thanks. Ok. > Thanks, Igor, for bringing this up (again). Thanks Igor, I had meant to bring this up but forgot. > There's no need to ping anybody. I do read this list and I haven't > forgotten about the patch. If it didn't require chan