Re: select.cc exitsock error cleanup

2006-05-23 Thread Lev Bishop
On 5/23/06, Christopher Faylor wrote: You're right. Stupid mistake on my part. I don't see any patch here You're right. Stupid mistake on my part. but I will make the appropriate changes to this function. Looks good now. L

Re: fhandler_base::readv

2006-05-23 Thread Christopher Faylor
On Tue, May 23, 2006 at 10:23:38PM -0400, Lev Bishop wrote: >On 5/23/06, Lev Bishop wrote: > >>It does make sense. Try this version. > >Sorry, no. I'm stupid - ignore that version. There's not much point in >doing assert(len>=0) given that len is unsigned, it's pretty much a >given :-) How about ju

Re: select.cc exitsock error cleanup

2006-05-23 Thread Christopher Faylor
On Tue, May 23, 2006 at 10:28:51PM -0400, Lev Bishop wrote: >On 5/23/06, Christopher Faylor wrote: >>I've checked in a variation of this patch but I've used si->exitsock >>for consistency. > >I'm sure that's wrong. With your version, the next time select() is >called, the thread-local socket will s

Re: select.cc exitsock error cleanup

2006-05-23 Thread Lev Bishop
On 5/23/06, Christopher Faylor wrote: I've checked in a variation of this patch but I've used si->exitsock for consistency. I'm sure that's wrong. With your version, the next time select() is called, the thread-local socket will still look like a valid socket, even though it has been closed and

Re: fhandler_base::readv

2006-05-23 Thread Lev Bishop
On 5/23/06, Lev Bishop wrote: It does make sense. Try this version. Sorry, no. I'm stupid - ignore that version. There's not much point in doing assert(len>=0) given that len is unsigned, it's pretty much a given :-) How about just removing the assert()? So here's the 3rd attempt. 2006-05-23

Re: fhandler_base::readv

2006-05-23 Thread Lev Bishop
On 5/23/06, Christopher Faylor wrote: At this point in the code, tot is only used in the subsequent assert. If that is the rationale for this change wouldn't it make more sense to just check len in the assert? It does make sense. Try this version. 2006-05-23 Lev Bishop <[EMAIL PROTECTED]>

Re: fhandler_base::readv

2006-05-23 Thread Christopher Faylor
On Tue, May 23, 2006 at 08:28:58PM -0400, Lev Bishop wrote: >2006-05-23 Lev Bishop <[EMAIL PROTECTED]> > > * fhandler.cc (readv): Deal with tot not precalculated. >Index: fhandler.cc >=== >RCS file: /cvs/src/src/winsup/cygwin/

Re: select.cc exitsock error cleanup

2006-05-23 Thread Christopher Faylor
On Tue, May 23, 2006 at 08:04:31PM -0400, Lev Bishop wrote: >2006-05-23 Lev Bishop <[EMAIL PROTECTED]> > > * select.cc (start_thread_socket): Clean up exitsock in case of > error. >Index: select.cc >=== >RCS file: /cvs/

fhandler_base::readv

2006-05-23 Thread Lev Bishop
2006-05-23 Lev Bishop <[EMAIL PROTECTED]> * fhandler.cc (readv): Deal with tot not precalculated. Index: fhandler.cc === RCS file: /cvs/src/src/winsup/cygwin/fhandler.cc,v retrieving revision 1.251 diff -u -p -r1.251 fhandl

select.cc exitsock error cleanup

2006-05-23 Thread Lev Bishop
2006-05-23 Lev Bishop <[EMAIL PROTECTED]> * select.cc (start_thread_socket): Clean up exitsock in case of error. Index: select.cc === RCS file: /cvs/src/src/winsup/cygwin/select.cc,v retrieving revision 1.124 diff -u -p -r1

Re: Using newer autoconf in src/winsup directory

2006-05-23 Thread Christopher Faylor
On Tue, May 23, 2006 at 07:45:32PM +1200, Danny Smith wrote: >RE: http://cygwin.com/ml/cygwin-patches/2006-q2/msg00051.html > >I am not subscribed to cygwin-patches so I'm posting here. Forgive me >if I've transgressed boundares, but I've always considered mingw as a >cygwin-dependent app. > >Appl