Re: [1.7] rename/renameat error

2009-09-25 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher Faylor on 9/25/2009 9:11 AM: >> >+ /* POSIX says mkdir("symlink-to-missing/") should create the >> >+ directory "missing", but Linux rejects it with EEXIST. Copy >> >+ Linux behavior for now. */ >> >+ >> >+ dlen = s

Re: [1.7] Support for CJK Character Sets

2009-09-25 Thread Corinna Vinschen
On Sep 25 18:27, Thomas Wolff wrote: > >> Btw., it's not only 20932/EUC-JP. The full list is 932/SJIS, >> 936/EUC-KR, 949/GBK, 950/Big5, 20932/EUC-JP. Probably it makes sense >> to note all of them. >> > I think, looking at other information, two have been interchanged here: > 936 should be GB

Re: [1.7] Support for CJK Character Sets

2009-09-25 Thread Thomas Wolff
Btw., it's not only 20932/EUC-JP. The full list is 932/SJIS, 936/EUC-KR, 949/GBK, 950/Big5, 20932/EUC-JP. Probably it makes sense to note all of them. I think, looking at other information, two have been interchanged here: 936 should be GBK 949 should be EUC-KR

Re: [1.7] rename/renameat error

2009-09-25 Thread Christopher Faylor
On Thu, Sep 24, 2009 at 09:31:45PM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >According to Christopher Faylor on 9/23/2009 10:41 AM: >>> Also less risky would be to make changes locally in mkdir, link, and >>> rename for now. > >Done - this patch narrows the scope o

Re: [1.7] bugs in faccessat

2009-09-25 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 9/25/2009 2:11 AM: >> +int __stdcall check_file_access (path_conv &, int, bool effective = true); >> +int __stdcall check_registry_access (HANDLE, int, bool effective = true); > > Can you please drop the default values

Re: [1.7] Support for CJK Character Sets

2009-09-25 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 9/25/2009 4:06 AM: >>> 2009-09-24 Eric Blake >>> >>> * setup2.sgml (setup-locale-problems): Document how to install >>> non-default charsets. >> Shoot. > > Btw., it's not only 20932/EUC-JP. The full list is

Re: [1.7] Support for CJK Character Sets

2009-09-25 Thread Corinna Vinschen
On Sep 25 10:36, Corinna Vinschen wrote: > On Sep 24 21:45, Eric Blake wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > According to Corinna Vinschen on 4/6/2009 5:04 AM: > > > Please note that eucJP does not work by default on Windows XP and > > > earlier OSes! At least not o

Re: [1.7] Support for CJK Character Sets

2009-09-25 Thread Corinna Vinschen
On Sep 24 21:45, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Corinna Vinschen on 4/6/2009 5:04 AM: > > Please note that eucJP does not work by default on Windows XP and > > earlier OSes! At least not on the so-called "western languages" > > installations,

Re: new exports

2009-09-25 Thread Corinna Vinschen
On Sep 24 21:40, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Followup to my faccessat patch. Here's several functions exported by > Linux which are trivial to support in cygwin, and which coreutils would > like to use. POSIX allows us to copy Linux' behavior about ref

Re: [1.7] rename/renameat error

2009-09-25 Thread Corinna Vinschen
On Sep 24 21:31, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Christopher Faylor on 9/23/2009 10:41 AM: > >> Also less risky would be to make changes locally in mkdir, link, and > >> rename for now. > > Done - this patch narrows the scope of the changes to

Re: [1.7] bugs in faccessat

2009-09-25 Thread Corinna Vinschen
Hi Eric, thanks for the patch. Basically it looks ok, I have just two cosmetic comments inline. On Sep 24 21:35, Eric Blake wrote: > diff --git a/winsup/cygwin/security.cc b/winsup/cygwin/security.cc > index 00a8c32..8c67fc9 100644 > --- a/winsup/cygwin/security.cc > +++ b/winsup/cygwin/security