On Wed, Jan 08, 2014 at 06:00:54PM -, James Johnston wrote:
>The function I modified is fhandler_pipe::create(fhandler_pipe**, unsigned,
>int). This function is a thin wrapper around a more specific
>fhandler_pipe::create(LPSECURITY_ATTRIBUTES, PHANDLE, PHANDLE, DWORD, const
>char*, DWORD open
> -Original Message-
> From: Christopher Faylor
> Sent: Wednesday, December 25, 2013 04:13
>
> On Tue, Dec 24, 2013 at 11:01:21PM -, James Johnston wrote:
> >Hi,
> >
> >As I have recently mentioned on the main Cygwin mailing list, Cygwin by
> >default creates FILE_FLAG_OVERLAPPED named
On Wed, Jan 8, 2014 at 2:38 PM, Christopher Faylor wrote:
> On Wed, Jan 08, 2014 at 11:00:14AM +, Ray Donnelly wrote:
>>On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote:
>>> On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote:
- PWCHAR p;
+ PWCHAR p = NULL;
>
On Wed, Jan 08, 2014 at 11:00:14AM +, Ray Donnelly wrote:
>On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote:
>> On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote:
>>>- PWCHAR p;
>>>+ PWCHAR p = NULL;
>>
>> AFAICT, that would result in a NULL dereference. I've chec
On Jan 8 10:49, Ray Donnelly wrote:
> On Wed, Jan 8, 2014 at 9:20 AM, Corinna Vinschen wrote:
> > On Jan 7 18:15, Ray Donnelly wrote:
> >> On Tue, Jan 7, 2014 at 3:12 PM, Corinna Vinschen wrote:
> >> > On Dec 22 01:03, Ray Donnelly wrote:
> >> >> I hope this is OK and I've done it in the best pla
On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote:
> On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote:
>>- PWCHAR p;
>>+ PWCHAR p = NULL;
>
> AFAICT, that would result in a NULL dereference. I've checked in
> a different change to handle this.
Thanks,
A NULL derefer
On Wed, Jan 8, 2014 at 9:20 AM, Corinna Vinschen wrote:
> On Jan 7 18:15, Ray Donnelly wrote:
>> On Tue, Jan 7, 2014 at 3:12 PM, Corinna Vinschen wrote:
>> > On Dec 22 01:03, Ray Donnelly wrote:
>> >> I hope this is OK and I've done it in the best place. Please advise if
>> >> it needs any changes
On Jan 7 18:15, Ray Donnelly wrote:
> On Tue, Jan 7, 2014 at 3:12 PM, Corinna Vinschen wrote:
> > On Dec 22 01:03, Ray Donnelly wrote:
> >> I hope this is OK and I've done it in the best place. Please advise if
> >> it needs any changes.
> >
> > I have no idea if this is ok. This is a patch to a
