Re: Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

2019-04-18 Thread Corinna Vinschen
On Apr 18 21:00, Ken Brown wrote: > On 4/18/2019 3:04 PM, Corinna Vinschen wrote: > > Ken, you have an account on sware and check-in rights to the cygwin repo > > anyway, so you don't really need me to push patches. > > > > If you feel up to the task, you can also go ahead and review and > >

Re: Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

2019-04-18 Thread Ken Brown
On 4/18/2019 3:04 PM, Corinna Vinschen wrote: > Ken, you have an account on sware and check-in rights to the cygwin repo > anyway, so you don't really need me to push patches. > > If you feel up to the task, you can also go ahead and review and > ultimately push patches from others. This also

Re: Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

2019-04-18 Thread Corinna Vinschen
On Apr 18 21:34, Achim Gratz wrote: > Corinna Vinschen writes: > >> No testing will be possible for me in the next two weeks, sorry. > > > > I'll be afk all of March, too. > > So, the past month? :-D s/March/May/ Sorry, Corinna -- Corinna Vinschen Cygwin Maintainer signature.asc

Re: Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

2019-04-18 Thread Achim Gratz
Corinna Vinschen writes: >> No testing will be possible for me in the next two weeks, sorry. > > I'll be afk all of March, too. So, the past month? :-D Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation for Waldorf Blofeld V1.15B11:

Cygwin patches (was Re: [PATCH 00/14] FIFO bug fixes and code simplifications)

2019-04-18 Thread Corinna Vinschen
On Apr 18 20:29, Achim Gratz wrote: > Ken Brown writes: > >> Take your time and thanks for working in that area. > > > > I've just sent an attempted fix. There may still be more changes needed; I > > just > > made a minimal change to make my STC succeed. > > No testing will be possible for me

Re: [PATCH 00/14] FIFO bug fixes and code simplifications

2019-04-18 Thread Achim Gratz
Ken Brown writes: >> Take your time and thanks for working in that area. > > I've just sent an attempted fix. There may still be more changes needed; I > just > made a minimal change to make my STC succeed. No testing will be possible for me in the next two weeks, sorry. Regards, Achim. --

Re: [PATCH] Cygwin: FIFO: avoid hang after exec

2019-04-18 Thread Corinna Vinschen
On Apr 18 15:39, Ken Brown wrote: > Define fhandler:fifo::fixup_after_exec, which sets listen_client_thr > and lct_termination_evt to NULL. This forces the listen_client thread > to restart on the first attempt to read after an exec. Previously the > exec'd process could hang in

Re: [PATCH 00/14] FIFO bug fixes and code simplifications

2019-04-18 Thread Ken Brown
On 4/17/2019 2:58 PM, Achim Gratz wrote: > Ken Brown writes: >> Thanks for testing. I have STCs for fork and exec that I used when first >> writing the code, and I forgot to retest those after the recent changes. I >> just >> tried, and the fork test succeeds but the exec test fails. I'll try

[PATCH] Cygwin: FIFO: avoid hang after exec

2019-04-18 Thread Ken Brown
Define fhandler:fifo::fixup_after_exec, which sets listen_client_thr and lct_termination_evt to NULL. This forces the listen_client thread to restart on the first attempt to read after an exec. Previously the exec'd process could hang in fhandler_fifo::raw_read. --- winsup/cygwin/fhandler.h