Re: /proc/partitions: add some space to avoid ragged output format

2020-03-02 Thread Thomas Wolff
Am 03.03.2020 um 00:26 schrieb Brian Inglis: Hi Thomas, In this industry, you plan ahead a bit further and longer: you need to go for at least a three digit increase (below) or more; legacy 8TB HDDs are cheap and common, 20TB are available, 100TB SSDs are available now (#blocks 9765625 - 11

Re: [PATCH 1/1] Collect handling of wpixput and wpbuf into a helper class.

2020-03-02 Thread Takashi Yano
Hi Hans, Thanks for the patch. On Tue, 3 Mar 2020 00:07:25 +0100 Hans-Bernhard Bröker wrote: > + inline void sendOut(HANDLE , DWORD *wn) { WriteConsoleA > (handle, buf, ixput, wn, 0); }; The second argument DWORD *wn of sendOut() is not used outside sendOut(), so it can be covered up like:

Re: /proc/partitions: add some space to avoid ragged output format

2020-03-02 Thread Brian Inglis
Hi Thomas, In this industry, you plan ahead a bit further and longer: you need to go for at least a three digit increase (below) or more; legacy 8TB HDDs are cheap and common, 20TB are available, 100TB SSDs are available now (#blocks 9765625 - 11 digits), capacity is expanding *faster* than

[PATCH 1/1] Collect handling of wpixput and wpbuf into a helper class.

2020-03-02 Thread Hans-Bernhard Bröker
Replace direct access to a pair of co-dependent variables by calls to methods of a class that encapsulates their relation. Also replace C #define by C++ class constant. --- winsup/cygwin/fhandler_console.cc | 135 -- 1 file changed, 70 insertions(+), 65 deletions(-)

[PATCH 0/1] Handle wpbuf in a more C++ style

2020-03-02 Thread Hans-Bernhard Bröker
Replace a relatively C-styled co-dependent pair of variables, a #define, and an inline function by a helper class containing their relation, because that is more in the C++ style. Hans-Bernhard Broeker (1): Collect handling of wpixput and wpbuf into a helper class.

Copyright License waiver

2020-03-02 Thread Hans-Bernhard Bröker
To whom it may concern, I hereby grant anyone the rights to any use code I send here under the standard 2-clause BSD license statement as found, among other places, in winsup/cygwin/CONTRIBUTORS. Hans-Bernhard Bröker

/proc/partitions: add some space to avoid ragged output format

2020-03-02 Thread Thomas Wolff
From 2e33b27e7d4683062f21a3082ec634a440ff9387 Mon Sep 17 00:00:00 2001 From: Thomas Wolff Date: Mon, 2 Mar 2020 22:36:56 +0100 Subject: [PATCH] avoid ragged output of /proc/partitions --- winsup/cygwin/fhandler_proc.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v2 1/4] Cygwin: console: Add workaround for broken IL/DL in xterm mode.

2020-03-02 Thread Jon Turney
On 02/03/2020 19:54, Corinna Vinschen wrote: On Mar 2 18:03, Corinna Vinschen wrote: On Mar 1 15:38, Takashi Yano wrote: Hi Hans, [...] I pushed wpbuf_put as a simple inline function as a stop-gap measure so Cygwin builds on gcc 9.2.0. \o/

Re: [PATCH v2 1/4] Cygwin: console: Add workaround for broken IL/DL in xterm mode.

2020-03-02 Thread Corinna Vinschen
On Mar 2 18:03, Corinna Vinschen wrote: > On Mar 1 15:38, Takashi Yano wrote: > > Hi Hans, > > > > On Sat, 29 Feb 2020 19:10:02 +0100 > > Hans-Bernhard Bröker wrote: > > > One more important note: the current implementation has a potential > > > buffer overrun issue, because it writes first,

Re: [PATCH 0/4] Cygwin: console: Some fixes for console in xterm mode.

2020-03-02 Thread Corinna Vinschen
On Mar 2 10:12, Takashi Yano wrote: > Takashi Yano (4): > Cygwin: console: Revise the code to fix tab position. > Cygwin: console: Fix setting/unsetting xterm mode for input. > Cygwin: console: Prevent buffer overrun. > Cygwin: console: Add a workaround for "ESC 7" and "ESC 8". > >

Re: [PATCH v2 1/4] Cygwin: console: Add workaround for broken IL/DL in xterm mode.

2020-03-02 Thread Corinna Vinschen
On Mar 1 15:38, Takashi Yano wrote: > Hi Hans, > > On Sat, 29 Feb 2020 19:10:02 +0100 > Hans-Bernhard Bröker wrote: > > One more important note: the current implementation has a potential > > buffer overrun issue, because it writes first, and only then checks > > whether that may have overrun