Re: [PATCH 0/8] Fix dumper for x86_64

On 02/07/2020 08:44, Corinna Vinschen wrote: On Jul 1 22:29, Jon Turney wrote: This needs to be aligned with some changes to gdb to consume the dumps it produces, so it's probably best to hold off applying this until it's more obvious what's going to happen with those. Random notes: -

[PATCH 12/8] Don't dump non-writable image regions

After this, we will end up dumping memory regions where: - state is MEM_COMMIT (i.e. is not MEM_RESERVE or MEM_FREE), and -- type is MEM_PRIVATE and protection allows reads (i.e. not a guardpage), or -- type is MEM_IMAGE and protection allows writes Making this decision based on the current

[PATCH 11/8] Drop excluded regions list from dumper

Drop excluded regions, now it's always empty --- winsup/utils/dumper.cc | 51 -- winsup/utils/dumper.h | 17 -- 2 files changed, 4 insertions(+), 64 deletions(-) diff --git a/winsup/utils/dumper.cc b/winsup/utils/dumper.cc index

[PATCH 9/8] Add all memory regions details to dumper debug output

--- winsup/utils/dumper.cc | 101 - 1 file changed, 80 insertions(+), 21 deletions(-) diff --git a/winsup/utils/dumper.cc b/winsup/utils/dumper.cc index fa3fe1fbc..04b7aa638 100644 --- a/winsup/utils/dumper.cc +++ b/winsup/utils/dumper.cc @@ -292,6 +292,25

[PATCH 10/8] Remove PE reading for section flags from dumper

--- winsup/utils/Makefile.in | 6 +- winsup/utils/dumper.cc | 2 - winsup/utils/dumper.h| 2 - winsup/utils/parse_pe.cc | 124 --- 4 files changed, 3 insertions(+), 131 deletions(-) delete mode 100644 winsup/utils/parse_pe.cc diff --git