[PATCH] Cygwin: fchmodat: add limited support for AT_SYMLINK_NOFOLLOW

2021-01-26 Thread Ken Brown via Cygwin-patches
Allow fchmodat with the AT_SYMLINK_NOFOLLOW flag to succeed on non-symlinks. Previously it always failed, as it does on Linux. But POSIX permits it to succeed on non-symlinks even if it fails on symlinks. The reason for following POSIX rather than Linux is to make gnulib report that fchmodat

[PATCH v6 4/4] Cygwin: pty: Allow multiple apps to enable pseudo console simultaneously.

2021-01-26 Thread Takashi Yano via Cygwin-patches
- After commit bb428520, there has been the disadvantage: 7) Pseudo console cannot be activated if it is already activated for another process on same pty. This patch clears this disadvantage. --- winsup/cygwin/fhandler.h | 7 +- winsup/cygwin/fhandler_tty.cc | 344

[PATCH v6 3/4] Cygwin: pty: Make apps using console APIs be able to debug with gdb.

2021-01-26 Thread Takashi Yano via Cygwin-patches
- After commit bb428520, there has been the disadvantage: 2) The apps which use console API cannot be debugged with gdb. This is because pseudo console is not activated since gdb uses CreateProcess() rather than exec(). Even with this limitation, attaching gdb to native app, in

[PATCH v6 2/4] Cygwin: pty: Keep code page between non-cygwin apps.

2021-01-26 Thread Takashi Yano via Cygwin-patches
- After commit bb428520, there has been the disadvantage: 4) Code page cannot be changed by chcp.com. Acctually, chcp works itself and changes code page of its own pseudo console. However, since pseudo console is recreated for another process, it cannot inherit the code page.

[PATCH v6 1/4] Cygwin: pty: Inherit typeahead data between two input pipes.

2021-01-26 Thread Takashi Yano via Cygwin-patches
- PTY has a problem that the key input, which is typed during windows native app is running, disappears when it returns to shell. This is beacuse pty has two input pipes, one is for cygwin apps and the other one is for native windows apps. The key input during windows native program is

[PATCH v6 0/4] Improve pseudo console support.

2021-01-26 Thread Takashi Yano via Cygwin-patches
The new implementation of pseudo console support by commit bb428520 provides the important advantages, while there also has been several disadvantages compared to the previous implementation. These patches overturn some of them. The disadvantage: 1) The cygwin program which calls console API

Re: [PATCH] Cygwin: chown: make sure ctime gets updated when necessary

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
On Jan 25 14:16, Ken Brown via Cygwin-patches wrote: > On 1/25/2021 1:57 PM, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 25 12:24, Ken Brown via Cygwin-patches wrote: > > > Following POSIX, ensure that ctime is updated if chown succeeds, > > > unless the new owner is specified as

Re: [PATCH v2 7/8] dir.cc: Try unlink_nt first

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 17:10, Ben Wijen wrote: > Speedup deletion of directories. > --- > winsup/cygwin/dir.cc | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc > index 7762557d6..470f83aee 100644 > --- a/winsup/cygwin/dir.cc >

Re: [PATCH v2 6/8] syscalls.cc: Expose shallow-pathconv unlink_nt

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 17:10, Ben Wijen wrote: > Not having to query file information improves unlink speed. > --- > winsup/cygwin/syscalls.cc | 78 ++- > 1 file changed, 52 insertions(+), 26 deletions(-) > > diff --git a/winsup/cygwin/syscalls.cc

Re: [PATCH v2 4/8] syscalls.cc: Implement non-path_conv dependent _unlink_nt

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
Hi Ben, ok, this is strong stuff, and apart from a couple of formatting issues, we should really discuss if a couple of things are feasible at all. On Jan 20 17:10, Ben Wijen wrote: > Implement _unlink_nt: wich does not depend on patch_conv > --- > winsup/cygwin/fhandler_disk_file.cc | 4 +- >

Re: [PATCH v5 0/4] Improve pseudo console support.

2021-01-26 Thread Takashi Yano via Cygwin-patches
On Tue, 26 Jan 2021 12:52:25 +0900 Takashi Yano wrote: > The new implementation of pseudo console support by commit bb428520 > provides the important advantages, while there also has been several > disadvantages compared to the previous implementation. > > These patches overturn some of them. >