Re: [PATCH 0/1] Fix fstat on FIFOs, part 1

2021-02-09 Thread Corinna Vinschen via Cygwin-patches
On Feb 9 10:11, Ken Brown via Cygwin-patches wrote: > Commit 76dca77f04 had a careless blunder, so this patch reverts it. > > Nevertheless, fstat(2) can be made more efficient on FIFOs, and I'm > working on a separate patchset to do this right. It's worth doing, > because every call to open(2)

Re: [PATCH] Cygwin: Have tmpfile(3) use O_TMPFILE

2021-02-09 Thread Corinna Vinschen via Cygwin-patches
Hi Mark, On Feb 9 02:50, Mark Geisert wrote: > Per discussion on cygwin-developers, a Cygwin tmpfile(3) implementation > has been added to syscalls.cc. This overrides the one supplied by > newlib. Then the open(2) flag O_TMPFILE was added to the open call that > tmpfile internally makes. > ---

[PATCH 1/1] Revert "Cygwin: fstat_helper: always use handle in call to get_file_attribute"

2021-02-09 Thread Ken Brown via Cygwin-patches
This reverts commit 76dca77f049271e2529c25de8a396e65dbce615d. That commit was based on the incorrect assumption that get_stat_handle, when called on a FIFO in fstat_helper, would always return a handle that is safe to use for getting the file information. That assumption is true in many cases

[PATCH 0/1] Fix fstat on FIFOs, part 1

2021-02-09 Thread Ken Brown via Cygwin-patches
Commit 76dca77f04 had a careless blunder, so this patch reverts it. Nevertheless, fstat(2) can be made more efficient on FIFOs, and I'm working on a separate patchset to do this right. It's worth doing, because every call to open(2) on a FIFO leads to a call chain device_access_denied -->

[PATCH] Cygwin: Have tmpfile(3) use O_TMPFILE

2021-02-09 Thread Mark Geisert
Per discussion on cygwin-developers, a Cygwin tmpfile(3) implementation has been added to syscalls.cc. This overrides the one supplied by newlib. Then the open(2) flag O_TMPFILE was added to the open call that tmpfile internally makes. --- winsup/cygwin/release/3.2.0 | 4