[PATCH 8/8] Cygwin: CI: Run cygserver for tests

2023-01-10 Thread Jon Turney
Note that cygserver must be run using the same cygwin1.DLL as test programs, as they communicate over a named pipe whose name contains the 'installation key' (which is a hash of the cygwin1.dll's path). We run cygserver via 'cmd' to avoid the special code which handles a cygwin parent process star

[PATCH 7/8] Cygwin: testsuite: Drop appending 'ntsec' to CYGWIN in cygrun wrapper

2023-01-10 Thread Jon Turney
Don't append 'ntsec' to the CYGWIN env var in the cygrun wrapper. It doesn't have any effect anymore. --- winsup/testsuite/cygrun.c | 16 1 file changed, 16 deletions(-) diff --git a/winsup/testsuite/cygrun.c b/winsup/testsuite/cygrun.c index 65d859d59..e6c4aa705 100644 --- a/win

[PATCH 6/8] Cygwin: testsuite: Update pthread tests for default SCHED_FIFO

2023-01-10 Thread Jon Turney
Update for default (and only) thread scheduler policy is SCHED_FIFO. --- winsup/testsuite/winsup.api/pthread/inherit1.c | 8 winsup/testsuite/winsup.api/pthread/priority1.c | 6 +++--- winsup/testsuite/winsup.api/pthread/priority2.c | 8 3 files changed, 11 insertions(+), 11 del

[PATCH 5/8] Cygwin: testsuite: Update mutex tests for changed default mutex type

2023-01-10 Thread Jon Turney
Default mutex type is PTHREAD_MUTEX_NORMAL. Attempting to unlock an unowned mutex of that type is specified as undefined behaviour, not returning EPERM. mutex7e verfies that attempting to unlock an unowned mutex of type PTHREAD_MUTEX_ERRORCHECK returns EPERM. --- winsup/testsuite/winsup.api/pthr

[PATCH 4/8] Cygwin: testsuite: 64-bit fixes in pthread testcases

2023-01-10 Thread Jon Turney
Fix warnings and 64-bit issues in pthread testcases. See pthread-win32 commit 1183e5ac etc. --- winsup/testsuite/winsup.api/pthread/cancel2.c | 10 - winsup/testsuite/winsup.api/pthread/cancel3.c | 10 - winsup/testsuite/winsup.api/pthread/cancel4.c | 10 - winsup/testsuit

[PATCH 2/8] Cygwin: testsuite: Build testcases using automake

2023-01-10 Thread Jon Turney
Build all the testcase executables directly using automake, rather than passing the compiler information into DejaGnu to have it build them. (This means you get build avoidance for these executables, so they only get built once, rather than every time you run the test, and makes it much easier to

[PATCH 3/8] Cygwin: testsuite: Fix compilation warnings

2023-01-10 Thread Jon Turney
Fix the warnings the previous change surfaces. See ltp commit d5c2112f for mmap fixes. --- winsup/testsuite/libltp/include/usctest.h | 2 +- winsup/testsuite/winsup.api/ltp/execv01.c | 2 +- winsup/testsuite/winsup.api/ltp/execve01.c | 2 +- winsup/testsuite/winsup.api/ltp/execvp01.c | 2 +-

[PATCH 1/8] Cygwin: testsuite: automake doesn't define objdir

2023-01-10 Thread Jon Turney
objdir isn't a predefined output variable in Automake (any more?), so this was just using the absolute path /testsuite as the test's temporary directory. Use builddir instead. --- winsup/testsuite/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/testsuite/Mak

[PATCH 0/8] Further testsuite fixes

2023-01-10 Thread Jon Turney
This gets us from: > FAIL: cygload (execute) > FAIL: devdsp.c (execute) > FAIL: ltp/access05.c (execute) > FAIL: ltp/fcntl07.c (execute) > FAIL: ltp/fcntl07B.c (execute) > FAIL: ltp/fork09.c (execute) > FAIL: ltp/link04.c (execute) > FAIL: ltp/symlink03.c (execute) > FAIL: msgtest.c (execute) > FA

Re: [PATCH] Cygwin: pinfo: Additional fix for CTTY behavior.

2023-01-10 Thread Corinna Vinschen
On Jan 10 22:37, Takashi Yano wrote: > On Mon, 9 Jan 2023 10:25:33 +0100 > Corinna Vinschen wrote: > > Also, given this was a "kludge" from 10 years ago, is it really still > > needed? > > Ah, do you mean the "kludge": > winsup/cygwin/syscalls.cc: 1455: > /* This is a temporary kludge until

Re: [newlib-cygwin] Cygwin: ctty: Add comments for the special values: -1 and -2.

2023-01-10 Thread Corinna Vinschen
On Jan 10 13:15, Takashi Yano via Cygwin-cvs wrote: > https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=3b7df69aaa5752f78537eafa5838f65a1ddfc938 > > commit 3b7df69aaa5752f78537eafa5838f65a1ddfc938 > Author: Takashi Yano > Date: Tue Jan 10 22:04:40 2023 +0900 > > Cygwin: ctty: Add

Re: [PATCH] Cygwin: pinfo: Additional fix for CTTY behavior.

2023-01-10 Thread Takashi Yano
On Mon, 9 Jan 2023 10:25:33 +0100 Corinna Vinschen wrote: > Also, given this was a "kludge" from 10 years ago, is it really still > needed? Ah, do you mean the "kludge": winsup/cygwin/syscalls.cc: 1455: /* This is a temporary kludge until all utilities can catch up with a change in

Re: [PATCH] Cygwin: pinfo: Additional fix for CTTY behavior.

2023-01-10 Thread Corinna Vinschen
On Jan 10 18:52, Takashi Yano wrote: > On Mon, 9 Jan 2023 10:25:33 +0100 > Corinna Vinschen wrote: > > On Dec 28 17:35, Takashi Yano wrote: > > > The commit 25c4ad6ea52f did not fix the CTTY behavior enough. For > > > example, in the following test case, TTY will be associated as > > > a CTTY on th

Re: [PATCH] Cygwin: pinfo: Additional fix for CTTY behavior.

2023-01-10 Thread Takashi Yano
On Mon, 9 Jan 2023 10:25:33 +0100 Corinna Vinschen wrote: > On Dec 28 17:35, Takashi Yano wrote: > > The commit 25c4ad6ea52f did not fix the CTTY behavior enough. For > > example, in the following test case, TTY will be associated as > > a CTTY on the second open() call even though the TTY is alrea