Re: [PATCH 0/3] fix unlink/rename failure in hyper-v container

2023-03-17 Thread Yoshinao Muramatsu
Hi Corinna. I'm Yoshinao Muramatsu. Thank you for your thoughtful guidance. I have not modified the patch yet, but I have made some observations and post the results. I forgot to mention in my first post that there is a workaround for this issue, which is to use process isolation unless hyper-v i

Re: [PATCH 0/3] fix unlink/rename failure in hyper-v container

2023-03-17 Thread Corinna Vinschen
Hi, On Mar 17 23:43, YO4 wrote: > Hello, cygwin developers. > I am using msys2 and it is based on the cygwin codebase. > I was working inside a windows container and encountered rm.exe and mv.exe > failures. > I would be honored if you could merge my patch into upstream. The patchset looks basic

[PATCH 3/3] log disabling posix semantics

2023-03-17 Thread YO4
--- winsup/cygwin/syscalls.cc | 8 1 file changed, 8 insertions(+) diff --git a/winsup/cygwin/syscalls.cc b/winsup/cygwin/syscalls.cc index 69699c8aa..ca40681cd 100644 --- a/winsup/cygwin/syscalls.cc +++ b/winsup/cygwin/syscalls.cc @@ -736,6 +736,9 @@ _unlink_nt (path_conv &pc, bool shar

[PATCH 2/3] fix rename in container

2023-03-17 Thread YO4
Renaming files returns STATUS_INVALID_PARAMETE on a bind mounted file system in hyper-v container with FILE_RENAME_POSIX_SEMANTICS. Disable the use_posix_semantics flag and retry. --- winsup/cygwin/syscalls.cc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/winsup/cygwin/syscalls

[PATCH 1/3] fix unlink in container

2023-03-17 Thread YO4
Deleting files returns STATUS_INVALID_PARAMETE on a bind mounted file system in hyper-v container with FILE_DISPOSITION_POSIX_SEMANTICS. Therefore fall back to default method. This code is suggeted by dscho and I change it more simple. --- winsup/cygwin/syscalls.cc | 5 - 1 file changed, 4 i

[PATCH 0/3] fix unlink/rename failure in hyper-v container

2023-03-17 Thread YO4
Hello, cygwin developers. I am using msys2 and it is based on the cygwin codebase. I was working inside a windows container and encountered rm.exe and mv.exe failures. I would be honored if you could merge my patch into upstream. How to reproduce: Use a version of windows that supports POSIX unli