Re: [PATCH] fix(libc): Fix handle of %E & %O modifiers at end of format string

2023-11-13 Thread Brian Inglis
On 2023-11-13 09:42, Corinna Vinschen wrote: Hi Pedro, On Nov 11 18:29, Pedro Luis Castedo Cepeda wrote: OK. It's not a newlib problem but a GLib one as it is relaying on common but non-standard strftime implementation details. I attach a short program more focused in g_date_strftime

Re: [PATCH] Cygwin: Fix profiler error() definition and usage

2023-11-13 Thread Corinna Vinschen
Hi Mark, On Nov 13 01:46, Mark Geisert wrote: > Minor updates to profiler and gmondump, which share some code: > - fix operation of error() so it actually works as intended > - resize 4K-size auto buffer reservations to BUFSIZ (==1K) > - remove trailing '\n' from 2nd arg on error() calls

Re: [PATCH] fix(libc): Fix handle of %E & %O modifiers at end of format string

2023-11-13 Thread Corinna Vinschen
Hi Pedro, On Nov 11 18:29, Pedro Luis Castedo Cepeda wrote: > OK. It's not a newlib problem but a GLib one as it is relaying on common but > non-standard strftime implementation details. > > I attach a short program more focused in g_date_strftime implementation so > it can be evaluated if it

[PATCH] Cygwin: Fix profiler error() definition and usage

2023-11-13 Thread Mark Geisert
Minor updates to profiler and gmondump, which share some code: - fix operation of error() so it actually works as intended - resize 4K-size auto buffer reservations to BUFSIZ (==1K) - remove trailing '\n' from 2nd arg on error() calls everywhere - provide consistent annotation of Windows error

Re: Which git hash to supply on Fixes: line -- never mind

2023-11-13 Thread Mark Geisert
On Sun, 12 Nov 2023, Mark Geisert wrote: Hi folks, I want to submit a patch that fixes 'profiler'. The Fixes: line of the patch commentary should reference the original addition of profiler to the Cygwin source tree. Using the gitweb interface, the commit display of profiler.cc shows: