Re: [PATCH 1/4] Cygwin: introduce constexpr errmap_size and errmap[] consistency checks

2024-02-26 Thread Corinna Vinschen
On Feb 26 15:21, Christian Franke wrote: > From 947daa02b0b64131626c2ecedb74ca6893aab6c6 Mon Sep 17 00:00:00 2001 > From: Christian Franke > Date: Mon, 26 Feb 2024 13:37:33 +0100 > Subject: [PATCH 1/4] Cygwin: introduce constexpr errmap_size and errmap[] > consistency checks > > Use constexpr in

[PATCH 4/4] Cygwin: errmap[]: update comments using current winerror.h

2024-02-26 Thread Christian Franke
From 66a9c2d35a836017e52c8ce73b76b2070c3b6a95 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 26 Feb 2024 15:15:18 +0100 Subject: [PATCH 4/4] Cygwin: errmap[]: update comments using current winerror.h Signed-off-by: Christian Franke --- winsup/cygwin/local_includes/errmap.h | 1701

[PATCH 2/4] Cygwin: errmap[]: reduce value size from 32 to 8 bits

2024-02-26 Thread Christian Franke
From bebc11c2a9022e61cdc7544ed2cb5101a170ae92 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 26 Feb 2024 14:01:54 +0100 Subject: [PATCH 2/4] Cygwin: errmap[]: reduce value size from 32 to 8 bits Overflow would be detected at compile time. Signed-off-by: Christian Franke --- winsu

[PATCH 1/4] Cygwin: introduce constexpr errmap_size and errmap[] consistency checks

2024-02-26 Thread Christian Franke
From 947daa02b0b64131626c2ecedb74ca6893aab6c6 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 26 Feb 2024 13:37:33 +0100 Subject: [PATCH 1/4] Cygwin: introduce constexpr errmap_size and errmap[] consistency checks Use constexpr instead of const for errmap[] to allow static_assert ch

Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-26 Thread Corinna Vinschen
On Feb 26 12:14, Christian Franke wrote: > Corinna Vinschen wrote: > > Why so many? I used winerror.h to populate the list not too long ago, > > so I wonder why it suddenly has so many more error codes? > > "Required for mozilla-central." - 850 insertions: > https://sourceforge.net/p/mingw-w64/mi

Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-26 Thread Christian Franke
Corinna Vinschen wrote: On Feb 25 10:12, Christian Franke wrote: Corinna Vinschen wrote: So the default was EPERM at first and has been changed to EACCES because it "is better for the unknown error case". I'm open to ideas for an improved error mapping. I have no better suggestion for a defau

Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-26 Thread Corinna Vinschen
On Feb 25 10:12, Christian Franke wrote: > Corinna Vinschen wrote: > > So the default was EPERM at first and has been changed to EACCES > > because it "is better for the unknown error case". > > > > I'm open to ideas for an improved error mapping. > > I have no better suggestion for a default err