Re: [PATCH] Cygwin: pipe: Restore non-blocking mode which was reset for non-cygwin app.

2024-03-11 Thread Corinna Vinschen
Hi Takashi, On Mar 10 19:31, Takashi Yano wrote: > @@ -590,6 +591,10 @@ child_info_spawn::worker (const char *prog_arg, const > char *const *argv, > { > fhandler_pipe *pipe = (fhandler_pipe *)(fhandler_base *) cfd; > pipe->set_pipe_non_blocking (false); > +

Re: [PATCH] Cygwin: pipe: Restore non-blocking mode which was reset for non-cygwin app.

2024-03-11 Thread Takashi Yano
On Mon, 11 Mar 2024 11:47:32 +0100 Corinna Vinschen wrote: > Hi Takashi, > > On Mar 10 19:31, Takashi Yano wrote: > > @@ -590,6 +591,10 @@ child_info_spawn::worker (const char *prog_arg, const > > char *const *argv, > > { > > fhandler_pipe *pipe = (fhandler_pipe *)(fhandler_

Re: [PATCH] Cygwin: pipe: Restore non-blocking mode which was reset for non-cygwin app.

2024-03-11 Thread Takashi Yano
On Mon, 11 Mar 2024 20:42:37 +0900 Takashi Yano wrote: > On Mon, 11 Mar 2024 11:47:32 +0100 > Corinna Vinschen wrote: > > Hi Takashi, > > > > On Mar 10 19:31, Takashi Yano wrote: > > > @@ -590,6 +591,10 @@ child_info_spawn::worker (const char *prog_arg, > > > const char *const *argv, > > >

Re: [PATCH] Cygwin: pipe: Restore non-blocking mode which was reset for non-cygwin app.

2024-03-11 Thread Corinna Vinschen
Hi Takashi, this looks much better. Just one question and a few comment changes... On Mar 11 22:18, Takashi Yano wrote: > Subject: [PATCH v2] Cygwin: pipe: Make sure to set read pipe non-blocking for > cygwin apps. > > If pipe reader is a non-cygwin app first, and cygwin process reads > the s

Re: [PATCH] Cygwin: pipe: Restore non-blocking mode which was reset for non-cygwin app.

2024-03-11 Thread Takashi Yano
On Mon, 11 Mar 2024 21:33:04 +0100 Corinna Vinschen wrote: > this looks much better. Just one question and a few comment > changes... > > On Mar 11 22:18, Takashi Yano wrote: > > Subject: [PATCH v2] Cygwin: pipe: Make sure to set read pipe non-blocking > > for > > cygwin apps. > > > > If pipe

Re: [PATCH] Cygwin: pipe: Restore non-blocking mode which was reset for non-cygwin app.

2024-03-11 Thread Takashi Yano
On Tue, 12 Mar 2024 08:03:16 +0900 Takashi Yano wrote: > + /* Set read pipe itself always non-blocking for cygwin process. > + Blocking/non-blocking is simulated in raw_read(). For write > + pipe, follow is_nonblocking(). */ > + int fd; > + cygheap_fdenum cfd (false); > + while ((fd = c