Re: [patch] Don't append extra NUL to registry-strings.

Op Mon, 29 Aug 2005 10:21:19 +0200 schreef Corinna Vinschen in [EMAIL PROTECTED]: : On Aug 28 22:49, Bas van Gompel wrote: : Hi, : : When RegQueryValueEx returns a string-type, the final NUL is included : in the returned size. I suggest dropping it. : : I see what you're up

Re: [Patch] readdir_r: fix sense of error-test.

Op Sun, 28 Aug 2005 13:16:44 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Sat, Aug 27, 2005 at 09:58:47PM +0200, Bas van Gompel wrote: : If you want to see why this really does not require a copyright- : assignment, view the diff with testsuite/winsup.api/ltp/readdir01.c

Re: [Patch] cygcheck: eprintf + display_error: Do /something/.

Op Fri, 17 Dec 2004 01:19:32 -0500 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Fri, Dec 17, 2004 at 04:33:10AM +0100, Bas van Gompel wrote: [...] : * cygcheck.cc (eprintf): Flush stdout before, and stderr after output, : when stdout and stderr both don't refer to ttys

Re: [Patch] cygcheck: eprintf + display_error: Do /something/.

, that would be preferable. No test at all is also an option...) ChangeLog-entry: 2004-12-17 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (eprintf): Flush stdout before, and stderr after output, when stdout and stderr both refer to tty's, or both don't. (display_error

Re: [Patch] cygcheck: eprintf + display_error: Do /something/.

Op Thu, 16 Dec 2004 21:56:07 -0500 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Fri, Dec 17, 2004 at 03:51:47AM +0100, Bas van Gompel wrote: [...] : I seem to be making a mess here... The point is to have the error-messages : appear at about the appropriate point in the output

Re: [Patch] fhandler.cc (pust_readahead): end-condition off.

Op Sat, 11 Dec 2004 09:53:19 +0100 schreef Corinna Vinschen in [EMAIL PROTECTED]: : On Dec 6 02:45, Bas van Gompel wrote: [...] : * fhandler.cc (fhandler_base::puts_readahead): Fix end-condition. : Yes, that looks better. I'd say the patch is correct. Please apply. Thanks, Done. L8r

Re: [Patch] fhandler.cc (pust_readahead): end-condition off.

Op Mon, 6 Dec 2004 10:16:19 -0500 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Mon, Dec 06, 2004 at 02:45:10AM +0100, Bas van Gompel wrote: [...] : * fhandler.cc (fhandler_base::puts_readahead): Fix end-condition. : : This patch changes things so that len characters are always

[Patch] fhandler.cc (pust_readahead): end-condition off.

ought to fix it. ChangeLog-entry: 2004-12-06 Bas van Gompel [EMAIL PROTECTED] * fhandler.cc (fhandler_base::puts_readahead): Fix end-condition. --- src/winsup/cygwin-mmod/fhandler.cc 5 Dec 2004 07:28:27 - 1.209 +++ src/winsup/cygwin-mmod/fhandler.cc 6 Dec 2004 01:14:14 -

[Patch] fhandler.cc: Don't worry about SPC in __small_printf-format

Hi, Three lines up from the previous patch there is a check to decide which format to use. This is not needed, an equivalent test is already done in __small_vsprintf. (Trivial) patch follows. ChangeLog-entry: 2004-12-05 Bas van Gompel [EMAIL PROTECTED] * fhandler.cc (fhandler_base

Re: [Patch] fhandler.cc: Don't worry about SPC in __small_printf-format

Op Sun, 5 Dec 2004 00:37:33 -0500 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Sun, Dec 05, 2004 at 05:44:24AM +0100, Bas van Gompel wrote: : 2004-12-05 Bas van Gompel [EMAIL PROTECTED] : : * fhandler.cc (fhandler_base::read): Remove superfluous check in : __small_sprintf

[Patch] cygcheck: Unset show_error and print_failed in some places.

Hi, More trivia, I'd say. This sets print_failed to false in places where printing failed makes no sense. In some of those places show_error is also cleared. ChangeLog-entry. 2004-11-16 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (find_on_path): Clear show_error

[Patch] cygcheck: Make keyeprint more versatile.

Hi, Another (trivial, I hope) patch. It will add some optional parameters to keyeprint, so errormessages can be made more appropriate. When the options are not supplied, output will remain as is. ChangeLog-entry: 2004-11-11 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (keyeprint

Re: [Patch] cygcheck: Make keyeprint more versatile.

Op Wed, 10 Nov 2004 19:35:51 -0500 schreef Christopher Faylor in [EMAIL PROTECTED]: [...] : * cygcheck.cc (keyeprint): New optional parameters: show_error and : print_failed. : : Please check in. Thanks. Done. : Have I mentioned that I don't like the name 'keyeprint'? It seems

Re: [Patch] cygcheck: Make keyeprint more versatile.

Op Wed, 10 Nov 2004 20:57:36 -0500 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Thu, Nov 11, 2004 at 02:49:35AM +0100, Bas van Gompel wrote: : Op Wed, 10 Nov 2004 19:35:51 -0500 schreef Christopher Faylor : Have I mentioned that I don't like the name 'keyeprint'? It seems like

Re: [Patch] cygcheck: Don't use keyeprint if GetLastError is irrelevant.

Op Sat, 30 Oct 2004 19:42:16 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Sat, Oct 30, 2004 at 11:32:27PM +0200, Bas van Gompel wrote: : 2004-10-28 Bas van Gompel [EMAIL PROTECTED] : : * cygcheck.cc (get_dword): Fix errormessage. : (cygwin_info): Ditto

Re: [Patch] cygcheck: Don't use keyeprint if GetLastError is irrelevant.

Op Fri, 29 Oct 2004 11:22:38 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Fri, Oct 29, 2004 at 06:31:11AM +0200, Bas van Gompel wrote: : Following (trivial, once more, I hope) patch cleans up some of the : (IMO) inappropriate ``keyeprint'' usage in cygcheck. It (keyeprint

[Patch] cygcheck: Don't use keyeprint if GetLastError is irrelevant.

failed''. While doing this I caught a typo in get_dword. ChangeLog-entry: 2004-10-28 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (add_path): Don't use keyeprint when GetLastError is irrelevant. (find_on_path): Ditto. (rva_to_offset): Ditto. (cygwin_info

Re: [Patch] cygcheck: More complete helptext on drive-list.

Op Mon, 25 Oct 2004 17:28:07 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Mon, Oct 25, 2004 at 06:25:16PM +0200, Bas van Gompel wrote: : Op Mon, 25 Oct 2004 11:51:32 -0400 schreef Christopher Faylor [Messed up ChangeLog-entry] : : I fixed this and checked it in. In general

[Patch] cygcheck: Warn about multiple or missing cygwin1.dlls.

Hi, Another (trivial, I think) patch, this time to warn about one of the more common pitfalls: multiple or missing cygwin1.dlls. 2004-10-26 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (dump_sysinfo): Warn about missing or multiple cygwin1 dlls. --- src/winsup/utils-3

Re: [Patch] cygcheck: Warn about multiple or missing cygwin1.dlls.

Op Tue, 26 Oct 2004 19:03:00 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Tue, Oct 26, 2004 at 11:34:13PM +0200, Bas van Gompel wrote: : 2004-10-26 Bas van Gompel [EMAIL PROTECTED] : : * cygcheck.cc (dump_sysinfo): Warn about missing or multiple cygwin1 : dlls

Re: [Patch] cygcheck: More complete helptext on drive-list.

Op Mon, 25 Oct 2004 11:51:32 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Sat, Oct 23, 2004 at 10:17:02PM +0200, Bas van Gompel wrote: : Op Fri, 22 Oct 2004 04:34:05 +0200 (MET DST) schreef Bas van Gompel : in [EMAIL PROTECTED]: : [...] : : : D**n, the leading newline

Re: [Patch] cygcheck: More complete helptext on drive-list.

Op Fri, 22 Oct 2004 04:34:05 +0200 (MET DST) schreef Bas van Gompel in [EMAIL PROTECTED]: [...] : D**n, the leading newline was lost... ...and I checked in CRLF's in the Changelog... ...Ain't I doing great. :( ChangeLog-entry: 2004-10-23 Bas van Gompel [EMAIL PROTECTED

[Patch] cygcheck: Allow for larger drives. ``Used'', not ``Free''.

''. ChangeLog-entry: 2004-10-20 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (dump_sysinfo): Allow for larger drives in drive-list. Change ``Used'' to ``Free'' in helptext-title for drive-list. --- src/winsup/utils/cygcheck.cc18 Oct 2004 10:25:38 - 1.53 +++ src

Re: [Patch] cygcheck: pretty_id misbehaving.

ChangeLog-entry as well). Remaining items... (I missed these last time around.) ChangeLog-entry: 2004-10-18 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (pretty_id): Don't let i become negative. Fix printf-format. --- src/winsup/utils/cygcheck.cc18 Oct 2004 01:44:55 -

Re: [Patch] cygcheck: pretty_id misbehaving.

Op Thu, 14 Oct 2004 13:36:21 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Thu, Oct 14, 2004 at 05:31:16PM +0200, Bas van Gompel wrote: [...] : * cygcheck.cc (pretty_id): Correct layout. : : Thanks for the patch but I think it's possible to do this and make : things

Re: [Patch] testsuite and newlib's signal.h.

Op Thu, 14 Oct 2004 11:55:59 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Thu, Oct 14, 2004 at 05:31:31PM +0200, Bas van Gompel wrote: : Another trivial patch, a bit kludgy... : : ATM the testsuite does not build, because : newlib/libc/include/sys/signal.h includes newlib/libc

[Patch] cygheap.cc: Allow _crealloc to shrink memory-block.

, this patch is useless.) (I did test this, and it WJFFM.) ChangeLog-entry: 20040-10-13 Bas van Gompel [EMAIL PROTECTED] * cygheap.cc (_crealloc): Allow memory-block to shrink. --- src/winsup/cygwin/cygheap.cc2 Jun 2004 21:20:53 - 1.103 +++ src/winsup/cygwin

Re: [Patch] cygcheck: warn about empty path-components

Op Thu, 7 Oct 2004 20:17:55 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Fri, Oct 08, 2004 at 01:42:05AM +0200, Bas van Gompel wrote: : : : Why are we bothering with this? : : : : If I may attempt to answer this one... Many people may not know of : : this usage, yet may

Re: [Patch] cygcheck: warn about empty path-components

Op Wed, 6 Oct 2004 22:15:58 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Thu, Oct 07, 2004 at 04:05:14AM +0200, Bas van Gompel wrote: [...] : s/-v/-h/. (I'm waiting for the other (trailing slash) patch to be : applied or rejected, before submitting this.) : : I missed

Re: [Patch] cygcheck: warn about trailing (back)slash on mount entries

Op Wed, 06 Oct 2004 12:00:15 -0400 schreef Pierre A. Humblet in [EMAIL PROTECTED]: : : : Christopher Faylor wrote: : : On Wed, Oct 06, 2004 at 11:30:17AM -0400, Pierre A. Humblet wrote: : : Christopher Faylor wrote: : : On Wed, Oct 06, 2004 at 03:12:45PM +0200, Bas van Gompel wrote

Re: [Patch] cygcheck: warn about empty path-components

Op Wed, 6 Oct 2004 11:49:39 +0200 schreef Corinna Vinschen in [EMAIL PROTECTED]: : On Oct 6 10:49, Bas van Gompel wrote: : Op Tue, 5 Oct 2004 16:46:49 +0200 schreef Corinna Vinschen : in [EMAIL PROTECTED]: : : [Empty path-components resolving to current dir.] [...] : Are you applying

Re: [Patch] pinfo.cc: second CreatePipe, not first.

Op Mon, 4 Oct 2004 22:10:43 -0400 schreef Christopher Faylor in [EMAIL PROTECTED]: : On Tue, Oct 05, 2004 at 03:49:20AM +0200, Bas van Gompel wrote: [...] : * pinfo.cc (_pinfo::commune_send): Make debugging output less ambiguous. : : I've applied this patch. Thanks. : : I used

[Patch] cygcheck: warn about empty path-components

Hi, This little patch makes cygcheck warn about empty path-components (leading/trailing/double ':'/';' in $PATH). ChangeLog-entry: 2004-10-05 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (dump_sysinfo): Warn about empty path-components. --- src/winsup/utils/cygcheck.cc4

[Patch] cygcheck: ``pclose'' what was ``popen''ed.

Hi, Another trivial (IMO) patch. What was opened by ``popen'', needs closing by ``pclose''. ChangeLog-entry: 2004-09-29 Bas van Gompel [EMAIL PROTECTED] * cygcheck.cc (pretty_id): Close pipe. --- src/winsup/utils/cygcheck.cc21 Mar 2004 17:58:14 - 1.43 +++ src

Re: [Patch] Trailing spaces in cygcheck -cd or -s output.

Op Wed, 22 Sep 2004 13:54:53 +0200 schreef Corinna Vinschen in [EMAIL PROTECTED]: : On Sep 16 07:26, Bas van Gompel wrote: [dump_setup.cc (dump_setup): Avoid trailing spaces on package-list.] : Thanks for the patch. I've applied the patch plus an additional patch which : adds

[Patch] getfacl -n layout not upto spec.

Hi, I noticed, getfacl -n ... returns badly formatted output like: ... group:544 rwx .. instead of: ... group:544:rwx ... This (trivial, I think) patch fixes that. --- src/winsup/utils/getfacl.c 11 Sep 2003 07:55:51 - 1.11 +++ src/winsup/utils/getfacl.c 14 Sep 2004 21:21:45 -