Hi Takashi,
I think you should push your original patch to the 3.5 branch for now,
and we test the big change in the main branch first.
Thanks,
Corinna
On Sep 5 22:18, Takashi Yano wrote:
> Hi Corinna, Ken and Johannes
>
> On Mon, 2 Sep 2024 23:33:13 +0900
> Takashi Yano wrote:
> > On Mon, 2
Hi Takashi,
thanks for this patch. Two points:
On Sep 5 22:18, Takashi Yano wrote:
> cannot read the pipe correctly after that. Similarly, if a non-
> cygwin app is executed from a cygwin app and the non-cygwin app
> exits, the read pipe mode remains on blocking mode although cygwin
> read pipe
On Aug 30 23:15, Takashi Yano wrote:
> If a cygwin app is executed from a non-cygwin app and the cygwin
> app exits, read pipe remains on non-blocking mode because of the
> commit fc691d0246b9. Due to this behaviour, the non-cygwin app
> cannot read the pipe correctly after that. With this patch, t
On Sep 1 04:46, Takashi Yano wrote:
> After the commit 7f3c22532577, writing to pipe extremely slows down.
> This is because cygwait(select_sem, 10, cw_cancel) is called even
> when write operation is already completed. With this patch, the
> cygwait() is called only if the write operation is not
On Aug 6 20:03, Jon Turney wrote:
> On 04/08/2024 22:48, Jon Turney wrote:
> > Supress new use-after-free warnings about realloc(), seen with gcc 12, e.g.:
> >
> > > In function ‘void rebase_locale_buf(const void*, const void*, const
> > > char*, const char*, const char*)’,
> > > inlined fr
On Aug 6 19:58, Jon Turney wrote:
> On 05/08/2024 11:22, Corinna Vinschen wrote:
> > On Aug 4 22:48, Jon Turney wrote:
> > > Fix gcc 12 warnings about narrowing conversions of socket ioctl constants
> > > when used as case labels, e.g:
> > > [...]
> &g
On Aug 4 22:48, Jon Turney wrote:
> Fix gcc 12 warnings about narrowing conversions of socket ioctl constants
> when used as case labels, e.g:
>
> > ../../../../src/winsup/cygwin/net.cc: In function ‘int get_ifconf(ifconf*,
> > int)’:
> > ../../../../src/winsup/cygwin/net.cc:1940:18: error: narr
On Aug 4 22:48, Jon Turney wrote:
> Fix a gcc 12 warning about a narrowing conversion in case labels for
> tape options.
>
> > In file included from /wip/cygwin/src/winsup/cygwin/include/sys/mtio.h:14,
> > from ../../../../src/winsup/cygwin/fhandler/tape.cc:13:
> > ../../../../sr
On Aug 4 22:48, Jon Turney wrote:
> Fix a gcc 12 warning about an address known to be non-NULL in
> format_proc_locale_proc().
>
> > ../../../../src/winsup/cygwin/fhandler/proc.cc: In function ‘BOOL
> > format_proc_locale_proc(LPWSTR, DWORD, LPARAM)’:
> > ../../../../src/winsup/cygwin/fhandler/p
On Aug 4 22:48, Jon Turney wrote:
> Fix warnings with gcc 12 about narrowing conversions of NTSTATUS
> constants when used as case labels, e.g:
>
> > ../../../../src/winsup/cygwin/exceptions.cc: In static member function
> > ‘static int exception::handle(EXCEPTION_RECORD*, void*, CONTEXT*,
> >
On Aug 4 22:48, Jon Turney wrote:
> This disables a warning seen with gcc 12 caused by intrinsics used by
> the inline implementation of NtCurrentTeb() inside w32api headers.
>
> > In function ‘long long unsigned int __readgsqword(unsigned int)’,
> > inlined from ‘_TEB* NtCurrentTeb()’ at
>
On Jul 18 10:27, Brian Inglis wrote:
> Linux 6.10 "Baby Opossum Posse" added cpuinfo feature flags for output.
>
> Linux cpuinfo follows output for each processor with a blank line,
> so we output newlines to get a blank line.
>
> Linux 6.10 changed the content of cpufeatures.h to require explic
On Apr 9 10:38, Brian Inglis wrote:
> On 2024-04-09 07:08, Corinna Vinschen wrote:
> > That's typically a permission problem. On Linux you get something like
> >
> >ls: cannot read symbolic link '/proc/1/cwd': Permission denied
>
> Thanks Corinna,
On Apr 7 13:34, Brian Inglis wrote:
> ISTM anomalous that for cygrunsrv, daemons, cron processes, and shells
> /proc//{cwd,root} have bad symlinks to "", normally a process
> or exe status:
>
> /proc/732/exe -> /usr/bin/cygrunsrv
> /proc/732/root ->
> /proc/732/cwd ->
> | /proc/733/exe
On Mar 18 11:21, Brian Inglis wrote:
> On 2024-03-18 09:45, Corinna Vinschen wrote:
> > I see. I just don't understands the difference between, say,
> >
> >ftcprint (features1, 21, "avx512ifma"); /* vec int FMA */
> > + /* ftcprint (features1, 22,
On Mar 18 08:10, Brian Inglis wrote:
> On 2024-03-18 03:33, Corinna Vinschen wrote:
> > Hi Brian,
> >
> > On Mar 16 10:44, Brian Inglis wrote:
> > > add Linux 6.8 cpuinfo flags:
> > > Intel 0x0007:1 eax:17 fredFlexible Return and Event
>
Hi Brian,
On Mar 16 10:44, Brian Inglis wrote:
> add Linux 6.8 cpuinfo flags:
> Intel 0x0007:1 eax:17 fredFlexible Return and Event
> Delivery;
> AMD 0x801f eax:4 sev_snp SEV secure nested paging;
> document unused and some unprinted bits that could look like omis
On Mar 14 10:10, Brian Inglis wrote:
> Hi folks,
>
> During newlib-cygwin build to test patches, with latest current stable
> packages as of last weekend, and yesterday's repo main/master, get a
> warning, then errors building dumper:
>
> ...
>
> CC libc/reent/libc_a-getentropyr.o
> /usr
ixes: 9e4d308cd592 ("Cygwin: pipe: Adopt FILE_SYNCHRONOUS_IO_NONALERT flag
> for read pipe.")
> Reported-by: wh
> Reviewed-by: Corinna Vinschen
> Signed-off-by: Takashi Yano
> ---
> winsup/cygwin/fhandler/pipe.cc | 63 +
> winsup/cy
d.
>
> Addresses: https://cygwin.com/pipermail/cygwin/2024-March/255644.html
> Fixes: 9e4d308cd592 ("Cygwin: pipe: Adopt FILE_SYNCHRONOUS_IO_NONALERT flag
> for read pipe.")
> Reported-by: wh
> Reviewed-by: Corinna Vinschen
> Signed-off-by: Takashi Yano
Hi Takashi,
On Mar 10 19:31, Takashi Yano wrote:
> @@ -590,6 +591,10 @@ child_info_spawn::worker (const char *prog_arg, const
> char *const *argv,
> {
> fhandler_pipe *pipe = (fhandler_pipe *)(fhandler_base *) cfd;
> pipe->set_pipe_non_blocking (false);
> +
On Mar 6 03:42, Takashi Yano wrote:
> On Tue, 5 Mar 2024 17:54:19 +0100
> Corinna Vinschen wrote:
> > On Mar 5 23:47, Takashi Yano wrote:
> > > On Tue, 5 Mar 2024 11:14:46 +0100
> > > Corinna Vinschen wrote:
> > > > This doesn't affec
On Mar 5 23:47, Takashi Yano wrote:
> On Tue, 5 Mar 2024 11:14:46 +0100
> Corinna Vinschen wrote:
> > This doesn't affect your patch, but while looking into this, what
> > strikes me as weird is that fhandler_pipe::temporary_query_hdl() calls
> > NtQueryObject() an
; Addresses: https://github.com/msys2/msys2-runtime/issues/202
>
> Fixes: b531d6b06eeb ("Cygwin: pipe: Introduce temporary query_hdl.")
> Reported-by: Alisa Sireneva, Johannes Schindelin
> Reviewed-by: Corinna Vinschen
> Signed-off-by: Takashi Yano
&
On Mar 5 09:06, Takashi Yano wrote:
> On Mon, 4 Mar 2024 18:38:07 +0100
> Corinna Vinschen wrote:
> > On Mar 4 16:45, ASSI wrote:
> > > Corinna Vinschen writes:
> > > > Right you are. We always said that independent Cygwin installations
> >
On Mar 4 16:45, ASSI wrote:
> Corinna Vinschen writes:
> > Right you are. We always said that independent Cygwin installations
> > are supposed to *stay* independent.
> >
> > Keep in mind that they don't share the same shared objects in the native
> > NT
On Mar 3 20:36, Takashi Yano wrote:
> On Sun, 03 Mar 2024 11:39:40 +0100
> ASSI wrote:
> > Takashi Yano writes:
> > >> After noticing that we enumerate all the processes (which is an expensive
> > >> operation) just to skip all of the non-Cygwin ones anyway, I wonder if it
> > >> wouldn't be smart
On Feb 27 17:26, Christian Franke wrote:
> Hi Corinna,
>
> Corinna Vinschen wrote:
> > On Feb 27 13:18, Christian Franke wrote:
> > > ...
> > >
> > > diff --git a/winsup/cygwin/errno.cc b/winsup/cygwin/errno.cc
> > > index 7d58e62ec..
Hi Christian,
On Feb 27 13:18, Christian Franke wrote:
> From f495fb0e7c2bd3a42f16f81af18c64ffaba9a860 Mon Sep 17 00:00:00 2001
> From: Christian Franke
> Date: Tue, 27 Feb 2024 13:05:36 +0100
> Subject: [PATCH 2/2] Cygwin: remove ENOSHARE and ECASECLASH from
> _sys_errlist[]
>
> These errno va
On Feb 26 15:21, Christian Franke wrote:
> From 947daa02b0b64131626c2ecedb74ca6893aab6c6 Mon Sep 17 00:00:00 2001
> From: Christian Franke
> Date: Mon, 26 Feb 2024 13:37:33 +0100
> Subject: [PATCH 1/4] Cygwin: introduce constexpr errmap_size and errmap[]
> consistency checks
>
> Use constexpr in
On Feb 26 12:14, Christian Franke wrote:
> Corinna Vinschen wrote:
> > Why so many? I used winerror.h to populate the list not too long ago,
> > so I wonder why it suddenly has so many more error codes?
>
> "Required for mozilla-central." - 850 insertions:
> h
On Feb 25 10:12, Christian Franke wrote:
> Corinna Vinschen wrote:
> > So the default was EPERM at first and has been changed to EACCES
> > because it "is better for the unknown error case".
> >
> > I'm open to ideas for an improved error mapping.
>
On Feb 23 19:14, Christian Franke wrote:
> Experiments with damaged USB flash drives and ddrescue revealed that the
> current mapping of these Win32 errors to the fallback EACCES could be
> improved.
>
> BTW: I wonder why EACCES was selected as the fallback. Source code control
> forensics suggest
On Feb 4 00:04, Takashi Yano wrote:
> On Sat, 3 Feb 2024 15:27:06 +0100 (CET)
> Johannes Schindelin wrote:
> > On IRC, you reported that the thread would crash if `cons` was not fixed
> > up. The symptom was that that crash would apparently prevent the exit code
> > from being read, and it would b
On Jan 27 15:12, Jon Turney wrote:
> On 26/01/2024 11:52, Corinna Vinschen wrote:
> > > - Create a named mutex with a reproducible name (no need to use
> > >the name as parameter) and immediately grab it.
> > > - Call CreateProcess to start the debugger with
On Jan 26 12:12, Corinna Vinschen wrote:
> On Jan 25 20:03, Jon Turney wrote:
> > On 25/01/2024 18:21, Corinna Vinschen wrote:
> > > On Jan 25 14:50, Jon Turney wrote:
> > > > On 24/01/2024 14:39, Corinna Vinschen wrote:
> > > > > On Jan 24 13:28, Jon
On Jan 25 20:03, Jon Turney wrote:
> On 25/01/2024 18:21, Corinna Vinschen wrote:
> > On Jan 25 14:50, Jon Turney wrote:
> > > On 24/01/2024 14:39, Corinna Vinschen wrote:
> > > > On Jan 24 13:28, Jon Turney wrote:
> > > > > On 23/01/2024 14:29, Corinn
On Jan 25 14:50, Jon Turney wrote:
> On 24/01/2024 14:39, Corinna Vinschen wrote:
> > On Jan 24 13:28, Jon Turney wrote:
> > > On 23/01/2024 14:29, Corinna Vinschen wrote:
> > > > On Jan 23 14:20, Jon Turney wrote:
> > > >
> > > > > Even
On Jan 24 23:48, Takashi Yano wrote:
> On Wed, 24 Jan 2024 15:40:22 +0100
> Corinna Vinschen wrote:
> > (You don't have to CC me, btw., I only get the same mail twice then
> > and I look into this mailing list constantly anyway)
>
> Perhaps, CC: is added autom
init_routine.
>
> Reviewed-by: Corinna Vinschen
> Signed-off-by: Takashi Yano
> ---
> winsup/cygwin/thread.cc | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/winsup/cygwin/thread.cc b/winsup/cygwin/thread.cc
> index 7bb4f9fc8..0f8327831 100644
> --- a/win
On Jan 24 13:28, Jon Turney wrote:
> On 23/01/2024 14:29, Corinna Vinschen wrote:
> > On Jan 23 14:20, Jon Turney wrote:
> >
> > > Even then this is clearly not totally bullet-proof. Maybe the right thing
> > > to
> > > do is add a suitable time
On Jan 23 14:20, Jon Turney wrote:
> On 12/01/2024 14:09, Jon Turney wrote:
> > Pre-format a command to be executed on a fatal error to run 'dumper'
> > (using an absolute path).
> >
> > Factor out executing a pre-formatted command, so we can use that for
> > invoking the JIT debugger in try_to_de
On Jan 16 13:52, Jon Turney wrote:
> On 15/01/2024 14:28, Corinna Vinschen wrote:
> > On Jan 15 13:27, Jon Turney wrote:
> > > On 15/01/2024 09:46, Corinna Vinschen wrote:
> > > > On Jan 13 14:20, Jon Turney wrote:
> > > &g
On Jan 15 13:27, Jon Turney wrote:
> On 15/01/2024 09:46, Corinna Vinschen wrote:
> > On Jan 13 14:20, Jon Turney wrote:
> > > On 12/01/2024 14:09, Jon Turney wrote:
> > > > +
> > > > + PWCHAR cp = dumper_command;
> > > > + cp = w
On Jan 15 13:41, Christian Franke wrote:
> Corinna Vinschen wrote:
> > On Jan 15 13:07, Corinna Vinschen wrote:
> > > Sorry Christian, but..
> > >
> > > I was just going to push this patch when I realized that we now have
> > > two lines
On Jan 15 13:07, Corinna Vinschen wrote:
> Sorry Christian, but..
>
> I was just going to push this patch when I realized that we now have
> two lines of debug output per affected file descriptor:
>
> On Jan 15 12:19, Christian Franke wrote:
> > + for (unsigned int
Sorry Christian, but..
I was just going to push this patch when I realized that we now have
two lines of debug output per affected file descriptor:
On Jan 15 12:19, Christian Franke wrote:
> + for (unsigned int i = firstfd; i < size; i++)
> +{
> + cygheap_fdget cfd ((int) i, false, fals
Hi Christian,
On Jan 15 09:56, Christian Franke wrote:
> Christian Franke wrote:
> > Jon Turney wrote:
> > > On 14/01/2024 16:07, Christian Franke wrote:
> > > > Recently I learned about the existence and usefulness of close_range():
> > > > https://github.com/smartmontools/smartmontools/issues/23
On Jan 14 19:53, Christian Franke wrote:
> Jon Turney wrote:
> > On 14/01/2024 16:07, Christian Franke wrote:
> > > Recently I learned about the existence and usefulness of close_range():
> > > https://github.com/smartmontools/smartmontools/issues/235
> > >
> > > https://man.freebsd.org/cgi/man.cg
On Jan 13 14:20, Jon Turney wrote:
> On 12/01/2024 14:09, Jon Turney wrote:
> > +
> > + PWCHAR cp = dumper_command;
> > + cp = wcpcpy (cp, L"\"");
> > + cp = wcpcpy (cp, dll_dir);
> > + cp = wcpcpy (cp, L"\\dumper.exe");
> > + cp = wcpcpy (cp, L"\" ");
> > + cp = wcpcpy (cp, L"\"");
> > + cp
On Jan 12 14:09, Jon Turney wrote:
> ---
> winsup/doc/misc-funcs.xml | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/winsup/doc/misc-funcs.xml b/winsup/doc/misc-funcs.xml
> index 7463942e6..55c5cac94 100644
> --- a/winsup/doc/misc-funcs.xml
> +++ b/winsup/doc/misc-funcs.xml
> @@ -106
On Jan 12 14:09, Jon Turney wrote:
> Write a coredump under 'ulimit -c' control and related changes.
>
> The idea here is to make debugging using a coredump work as usual on a unix,
> e.g.:
>
> $ ulimit -c unlimited
>
> $ ./segv-program
> *** starting '"C:\cygwin64\bin\dumper.exe"
> "C:\cygwin6
On Jan 12 14:09, Jon Turney wrote:
> On 11/01/2024 09:42, Corinna Vinschen wrote:
> > I see. It's a bit unfortunate though, if dumper tries to create
> > a 2 Gigs file which is later truncated, if we're low on disk space.
> > But yeah, disk space isn't m
On Jan 10 17:38, Jon Turney wrote:
> On 10/01/2024 15:30, Corinna Vinschen wrote:
> > On Jan 10 13:57, Jon Turney wrote:
> [...]
> > >
> > > Also: Fix the (deprecated) cygwin_dumpstack() function so it will now
> > > write a .stackdump file,
On Jan 10 13:57, Jon Turney wrote:
> ---
> winsup/doc/utils.xml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/doc/utils.xml b/winsup/doc/utils.xml
> index 8261e7ebd..692dae38f 100644
> --- a/winsup/doc/utils.xml
> +++ b/winsup/doc/utils.xml
> @@ -210,7 +210,7 @@
On Jan 10 13:57, Jon Turney wrote:
> Change the default core limit from unlimited to 0 (disabled)
> ---
> winsup/cygwin/mm/cygheap.cc | 2 +-
> winsup/doc/new-features.xml | 6 ++
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/mm/cygheap.cc b/winsup/cygwin/mm
On Jan 10 13:57, Jon Turney wrote:
> Factor out pre-formatting a command to be executed on a fatal signal,
> and use that for both error_start (if present in the CYGWIN env var) and
> for 'dumper'.
>
> Factor out executing that command, so we can use it from try_to_debug()
> and when a fatal signa
On Nov 24 17:06, Jon Turney wrote:
> Add '--names-only' flag to cygcheck, to output just the bare package
> names.
Push it!
> ---
>
> Notes:
> Rather than more hacky aftermarket solutions, let's make cygcheck output
> something more useful for feeding into setup.
>
> Next step w
On Nov 22 17:31, Christian Franke wrote:
> Hi Corinna,
>
> Corinna Vinschen wrote:
> > Hi Christian,
> >
> >
> > On second thought...
> >
> > I had a bad night tonight and was thinking a long time about this and
> > that. It suddenly occured
; which is on a
fixed disk. So you get something like this:
$ ls -l /dev/disk/by-label
total 0
lrwxrwxrwx 1 corinna vinschen 0 Nov 22 10:09 VOLUME -> ../../sdb1
lrwxrwxrwx 1 corinna vinschen 0 Nov 22 10:10 root -> ../../sda3
Now you insert an USB Stick with a FAT32 filesyst
On Nov 21 19:31, Christian Franke wrote:
> Corinna Vinschen wrote:
> > Hi Christian,
> >
> > Looks good, but I just realized that I was already wondering about the
> > sanitization and forgot to talk about it:
> >
> > On Nov 21 12:24, Christian Franke
Hi Christian,
Looks good, but I just realized that I was already wondering about the
sanitization and forgot to talk about it:
On Nov 21 12:24, Christian Franke wrote:
> diff --git a/winsup/cygwin/fhandler/dev_disk.cc
> b/winsup/cygwin/fhandler/dev_disk.cc
> index c5d72816f..d12ac52fa 100644
> -
On Nov 20 15:54, Christian Franke wrote:
> From: Christian Franke
> Date: Mon, 20 Nov 2023 15:40:42 +0100
> Subject: [PATCH] Cygwin: /dev/disk/by-uuid: Fix NTFS serial number print
> format
>
> Signed-off-by: Christian Franke
> ---
> winsup/cygwin/fhandler/dev_disk.cc | 2 +-
> 1 file changed,
On Nov 20 10:40, Corinna Vinschen wrote:
> Hi Christian,
>
> This puzzles me:
>
> On Nov 17 21:25, Christian Franke wrote:
> > @@ -610,7 +607,7 @@ get_by_id_table (by_id_entry * &table,
> > fhandler_dev_disk::dev_disk_location loc)
> >if (!table
Hi Christian,
This puzzles me:
On Nov 17 21:25, Christian Franke wrote:
> @@ -610,7 +607,7 @@ get_by_id_table (by_id_entry * &table,
> fhandler_dev_disk::dev_disk_location loc)
>if (!table)
> return (errno_set ? -1 : 0);
>
> - /* Sort by name and remove duplicates. */
> + /* Sort by
On Nov 17 18:53, Christian Franke wrote:
> Corinna Vinschen wrote:
> > On Nov 17 17:45, Christian Franke wrote:
> > > Corinna Vinschen wrote:
> > > > On Nov 17 15:39, Christian Franke wrote:
> > > > > The last two /dev/disk subdirectories :-)
> >
On Nov 17 17:45, Christian Franke wrote:
> Corinna Vinschen wrote:
> > On Nov 17 15:39, Christian Franke wrote:
> > > The last two /dev/disk subdirectories :-)
> > >
> > > Note a minor difference: On Linux, empty /dev/disk subdirectories
> > > apparen
Agreed. This is really great. I just pushed your patch.
However, there's something strange in terms of by-label:
I have two partitions with labels:
$ ls -l /dev/disk/by-label
total 0
lrwxrwxrwx 1 corinna vinschen 0 Nov 17 17:18 blub -> ../../sda3
lrwxrwxrwx 1 corinna vinsch
On Nov 16 18:02, Christian Franke wrote:
> Corinna Vinschen wrote:
> > On Nov 16 12:50, Christian Franke wrote:
> > ...
> > > > I also tried an NTFS partition and the output looks like this:
> > > >
> > > > 0FD4F62866CFBF09 -> ../../
On Nov 16 12:50, Christian Franke wrote:
> Corinna Vinschen wrote:
> > Hi Christian,
> >
> > On Nov 15 18:23, Christian Franke wrote:
> > > This is the next (and possibly last for now) extension to the /dev/disk
> > > directory. Limited to disk related
Hi Christian,
On Nov 15 18:23, Christian Franke wrote:
> This is the next (and possibly last for now) extension to the /dev/disk
> directory. Limited to disk related entries which allowed a straightforward
> extension of the existing code.
>
> My original idea was to add also other drive letters
On Nov 14 00:58, Mark Geisert wrote:
> Minor updates to profiler and gmondump, which share some code:
> - fix operation of error() so it actually works as intended
> - resize 4K-size auto buffer reservations to BUFSIZ (==1K)
> - remove trailing '\n' from 2nd arg on error() calls everywhere
> - prov
Hi Mark,
On Nov 13 01:46, Mark Geisert wrote:
> Minor updates to profiler and gmondump, which share some code:
> - fix operation of error() so it actually works as intended
> - resize 4K-size auto buffer reservations to BUFSIZ (==1K)
> - remove trailing '\n' from 2nd arg on error() calls everywher
Hi Pedro,
On Nov 11 18:29, Pedro Luis Castedo Cepeda wrote:
> OK. It's not a newlib problem but a GLib one as it is relaying on common but
> non-standard strftime implementation details.
>
> I attach a short program more focused in g_date_strftime implementation so
> it can be evaluated if it wor
On Nov 9 23:17, Brian Inglis wrote:
> On 2023-11-09 12:04, Pedro Luis Castedo Cepeda wrote:
> > - Prevent strftime to parsing format string beyond its end when
> >it finish with "%E" or "%O".
> > ---
> > newlib/libc/time/strftime.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff -
On Nov 8 17:40, Christian Franke wrote:
> Minor improvement, avoids "/dev/disk/by-id/sata-VENDOR_MODEL___SERIAL".
Pushed.
Thanks,
Corinna
On Nov 7 15:30, Christian Franke wrote:
> Corinna Vinschen wrote:
> > ..
> > Looking forward to it. We'll just need an entry for the release text
> > in winsup/cygwin/release/3.5.0 and doc/new-features.xml in the end :)
>
> Attached for now as implementing
On Nov 7 11:10, Christian Franke wrote:
> Corinna Vinschen wrote:
> > Hi Christian,
> >
> > On Nov 5 16:45, Christian Franke wrote:
> > > ...
> > > Old IOCTL dropped and code simplified.
> > Great. I pushed your patch.
>
> Thanks.
>
>
Hi Christian,
On Nov 5 16:45, Christian Franke wrote:
> Corinna Vinschen wrote:
> > Do we really still need IOCTL_DISK_GET_DRIVE_LAYOUT w/o _EX?
>
> Possibly not. I borrowed this code from code behind /proc/partitions.
>
> > fhandler_proc still uses it, too, but the E
Hi Christian,
patch looks pretty good to me. Just two minor points:
> + /* Traverse \Device directory ... */
> + bool errno_set = false;
> + HANDLE devhdl = INVALID_HANDLE_VALUE;
INVALID_HANDLE_VALUE is a Win32 API concept and is only returned by
CreateFile and friends. The native NT API do
On Nov 4 10:34, Corinna Vinschen wrote:
> On Nov 3 18:54, Christian Franke wrote:
> > Corinna Vinschen wrote:
> > > On Nov 3 17:27, Corinna Vinschen wrote:
> > > > On Nov 3 17:09, Christian Franke wrote:
> > > > > Unlike (S)ATA and NVMe, the serial
On Nov 3 18:54, Christian Franke wrote:
> Corinna Vinschen wrote:
> > On Nov 3 17:27, Corinna Vinschen wrote:
> > > On Nov 3 17:09, Christian Franke wrote:
> > > > Unlike (S)ATA and NVMe, the serial number
> > > > is not available for free in the device
On Nov 3 17:27, Corinna Vinschen wrote:
> On Nov 3 17:09, Christian Franke wrote:
> > Unlike (S)ATA and NVMe, the serial number
> > is not available for free in the device identify data block but requires an
> > extra command (SCSI INQUIRY of VPD page 0x80). This might no
On Nov 3 17:09, Christian Franke wrote:
> Corinna Vinschen wrote:
> > I haven't found out where the UUID is coming from, yet, but based on the
> > description from
> > https://learn.microsoft.com/en-us/windows-hardware/drivers/storage/device-unique-identifiers--duids-
On Nov 3 12:10, Corinna Vinschen wrote:
> On Nov 3 11:09, Corinna Vinschen wrote:
> > On Nov 3 10:55, Corinna Vinschen wrote:
> > > On Oct 3 14:39, Christian Franke wrote:
> > > > According to NtQueryObject(., ObjectBasicInformation, ...), using
> &g
On Nov 3 12:06, Christian Franke wrote:
> Corinna Vinschen wrote:
> > > I ran this on Windows 11 and Windows 2K19 in a QEMU/KVM VM. A
> > > \Device\Harddisk0\Partition0 symlink pointing to \Device\Harddisk0\DR0
> > > exists in both cases. I straced it, and found th
On Nov 3 11:09, Corinna Vinschen wrote:
> On Nov 3 10:55, Corinna Vinschen wrote:
> > On Oct 3 14:39, Christian Franke wrote:
> > > According to NtQueryObject(., ObjectBasicInformation, ...), using
> > > NtOpenFile(., MAXIMUM_ALLOWED, ...) without admin rights sets
&
On Nov 3 10:55, Corinna Vinschen wrote:
> Hi Christian,
>
> On Oct 3 14:39, Christian Franke wrote:
> > Christian Franke wrote:
> > > This is a first attempt to partly emulate the Linux directory
> > > /dev/disk/by-id. Useful to make sure the correct device is a
Hi Christian,
On Oct 3 14:39, Christian Franke wrote:
> Christian Franke wrote:
> > This is a first attempt to partly emulate the Linux directory
> > /dev/disk/by-id. Useful to make sure the correct device is accessed in
> > conjunction with dd, ddrescue, fdisk,
>
> Attached is the second a
On Sep 7 22:36, Mark Geisert wrote:
> Add a missing "void" to the prototype for __cpuset_zero_s().
>
> Reported-by: Marco Mason
> Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
> Signed-off-by: Mark Geisert
> Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-speci
Jon,
you did all the latest work in terms of the build machinery.
Would you mind to review this patch, please?
Thanks,
Corinna
On Sep 5 19:01, Christian Franke wrote:
> This patch enables reproducible builds of cygwin package in conjunction with
> this cygport patch:
> https://sourceware.org/p
On Sep 7 22:36, Mark Geisert wrote:
> Add a missing "void" to the prototype for __cpuset_zero_s().
>
> Reported-by: Marco Mason
> Addresses: https://cygwin.com/pipermail/cygwin/2023-September/254423.html
> Signed-off-by: Mark Geisert
> Fixes: c6cfc99648d6 (Cygwin: sys/cpuset.h: add cpuset-speci
On Sep 1 11:42, Brian Inglis wrote:
> add AMD 0x801f EAX 14 debug_swap SEV-ES full debug state swap
>
> Signed-off-by: Brian Inglis
> ---
> winsup/cygwin/fhandler/proc.cc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/winsup/cygwin/fhandler/proc.cc b/winsup/cygwin
On Sep 1 19:04, Takashi Yano wrote:
> This patch adds implementation of OSS-based sound mixer device. This
> allows applications to change the sound playing volume.
Cool! Go ahead, that's a nice addition.
> NOTE: Currently, the recording volume cannot be changed.
I guess you're already hacking
Hi Brian,
nothing against the patch as such, but your subject line is not so nice.
As it becomes the commit message first line, it should be shorter. Add
more descriptive text instead, please, and make sure that it tells the
reader what you're really doing, i. e.:
You write "add ", but your patc
From: Corinna Vinschen
Before commit 44f73c5a6206 ("Cygwin: Fix segfalt when too many command
line args are specified.") we had no actual argument size limit, except
for the fact that the child process created another copy of the argv
array on the stack, which could result in a stac
On Aug 28 13:09, Corinna Vinschen wrote:
> On Aug 28 12:57, Corinna Vinschen wrote:
> > On Aug 28 18:46, Takashi Yano wrote:
> > > Previously, the number of command line args was not checked for
> > > cygwin process. Due to this, segmentation fault was caused if too
&
On Aug 28 12:57, Corinna Vinschen wrote:
> On Aug 28 18:46, Takashi Yano wrote:
> > Previously, the number of command line args was not checked for
> > cygwin process. Due to this, segmentation fault was caused if too
> > many command line args are specified.
> > h
On Aug 28 18:21, Takashi Yano wrote:
> Signed-off-by: Takashi Yano
> ---
> winsup/cygwin/fhandler/termios.cc | 18 --
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git a/winsup/cygwin/fhandler/termios.cc
> b/winsup/cygwin/fhandler/termios.cc
> index 789ae0179..d1
On Aug 28 18:46, Takashi Yano wrote:
> Previously, the number of command line args was not checked for
> cygwin process. Due to this, segmentation fault was caused if too
> many command line args are specified.
> https://cygwin.com/pipermail/cygwin/2023-August/254333.html
>
> Since char *argv[argc
1 - 100 of 2645 matches
Mail list logo
