test

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
please ignore

Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
On Mar 23 21:42, Takashi Yano via Cygwin-patches wrote: > On Tue, 23 Mar 2021 21:32:12 +0900 > Takashi Yano wrote: > > I try to check run.exe behaviour and noticed that > > run cmd.exe > > and > > run cat.exe > > does not work with cygwin 3.0.7 and 3.2.0 (TEST) while these > > work in 3.1.7. > >

Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
On Mar 23 21:32, Takashi Yano via Cygwin-patches wrote: > On Tue, 23 Mar 2021 13:17:16 +0100 > Corinna Vinschen wrote: > > On Mar 23 20:57, Takashi Yano via Cygwin-patches wrote: > > > Corinna Vinschen wrote: > > > > > > On Mar 22 08:07, Takashi Yano via Cygwin-patches wrote: > > > > > > > > And

Re: [PATCH] Cygwin: pty: Rename input/output named pipes.

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
On Mar 23 20:50, Takashi Yano via Cygwin-patches wrote: > - Currently, names of output pipes are "pty%d-to-master" and "pty%d- > to-master-cyg" and names of input pipes are "pty%d-to-slave" and > "pty%d-from-master". With this patch, these pipes are renamed to > "pty%d-to-master-nat",

Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
On Mar 23 20:57, Takashi Yano via Cygwin-patches wrote: > Corinna Vinschen wrote: > > > > On Mar 22 08:07, Takashi Yano via Cygwin-patches wrote: > > > > > > And also, following cygwin apps/dlls call GetStdHandle(): > > > > > > ccmake.exe > > > > > > cmake.exe > > > > > > cpack.exe > > > > > >

Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
[CC Marco, CC Jan] On Mar 22 13:02, Ken Brown via Cygwin-patches wrote: > [Still CC Marco] > > On 3/22/2021 7:43 AM, Corinna Vinschen via Cygwin-patches wrote: > > [CC Marco] > > > > On Mar 22 08:07, Takashi Yano via Cygwin-patches wrote: > > > On Sun, 21 M

Re: [PATCH] Cygwin: pty: Rename input named pipes.

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
On Mar 23 09:38, Takashi Yano via Cygwin-patches wrote: > On Mon, 22 Mar 2021 12:49:20 +0100 > Corinna Vinschen wrote: > > Hi Takashi, > > > > On Mar 21 12:59, Takashi Yano via Cygwin-patches wrote: > > > - Currently, the name of input pipe is "pty-from-master" for > > > cygwin process, and

Re: [PATCH 1/2] Treat Windows Store's "app execution aliases" as symbolic links

2021-03-23 Thread Corinna Vinschen via Cygwin-patches
On Mar 22 22:54, Hans-Bernhard Bröker wrote: > Am 22.03.2021 um 16:22 schrieb Johannes Schindelin: > > One of those under-documented reparse point types is the WSL symbolic > > link, which you will notice are supported in Cygwin, removing quite some > > sway from your argument... > > I notice no

Re: [PATCH] Cygwin: pty: Rename input named pipes.

2021-03-22 Thread Corinna Vinschen via Cygwin-patches
Hi Takashi, On Mar 21 12:59, Takashi Yano via Cygwin-patches wrote: > - Currently, the name of input pipe is "pty-from-master" for > cygwin process, and "pty-to-slave" for non-cygwin process. > These are not only inconsistent with output pipes but also very > confusing. > With

Re: [PATCH 0/2] Return appropriate handle by _get_osfhandle() and GetStdHandle().

2021-03-22 Thread Corinna Vinschen via Cygwin-patches
[CC Marco] On Mar 22 08:07, Takashi Yano via Cygwin-patches wrote: > On Sun, 21 Mar 2021 17:44:27 +0900 > Takashi Yano wrote: > > On Sun, 21 Mar 2021 13:01:24 +0900 > > Takashi Yano wrote: > > > Takashi Yano (2): > > > Cygwin: syscalls.cc: Make _get_osfhandle() return appropriate handle. > > >

Re: [PATCH 1/2] Treat Windows Store's "app execution aliases" as symbolic links

2021-03-15 Thread Corinna Vinschen via Cygwin-patches
Hi Johannes, I'm not opposed to treat these applinks as symlinks. I have a suggestion and a style nit, though. On Mar 12 16:11, Johannes Schindelin via Cygwin-patches wrote: > When the Windows Store version of Python is installed, so-called "app > execution aliases" are put into the `PATH`.

Re: [PATCH 1/2] Treat Windows Store's "app execution aliases" as symbolic links

2021-03-15 Thread Corinna Vinschen via Cygwin-patches
On Mar 13 19:41, Joe Lowe via Cygwin-patches wrote: > Hi Johannes, > > I agree on the usefulness to the user of showing appexec target executable > as symlink target. But I am uncertain about the effect on code. > > One example: Any app that is able to archive/copy posix symlinks will > convert

Re: [PATCH] Cygwin: pty: Transfer input only if the stdin is a pty.

2021-03-09 Thread Corinna Vinschen via Cygwin-patches
On Mar 9 12:23, Takashi Yano via Cygwin-patches wrote: > - The commit 12325677f73a did not fix enough. With this patch, more > transfer_input() calls are skipped if stdin is redirected or piped. > --- > winsup/cygwin/fhandler_tty.cc | 10 -- > winsup/cygwin/spawn.cc| 9

Re: [PATCH] Cygwin: pty: Transfer input for native app only if the stdin is pcon.

2021-03-09 Thread Corinna Vinschen via Cygwin-patches
On Mar 9 12:22, Takashi Yano via Cygwin-patches wrote: > On Mon, 8 Mar 2021 21:52:37 +0100 > Corinna Vinschen wrote: > > On Mar 9 00:48, Takashi Yano via Cygwin-patches wrote: > > > On Mon, 8 Mar 2021 16:32:16 +0100 > > > Corinna Vinschen wrote: > > > > Hi Takashi, > > > > > > > > On Mar 8

Re: [PATCH] winsup/doc/dll.xml: update MinGW/.org to MinGW-w64/.org

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 8 15:20, Ken Brown via Cygwin-patches wrote: > On 3/8/2021 2:09 PM, Achim Gratz wrote: > > Brian Inglis writes: > > > It's normally a merge conflict which will not be satisfied by regular > > > commands to restore the working files to upstream. > > > > So you're pulling on an unclean work

Re: [PATCH 0/2] cygwin-htdocs: update MinGW references

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 8 09:17, Brian Inglis wrote: > update MinGW.org references and update package categories to remove MinGW > > Brian Inglis (2): > cygwin-htdocs/links.html: update MinGW.org reference > cygwin-htdocs/packaging-hint-files.html: update categories > > links.html| 4 ++-- >

Re: [PATCH] Cygwin: pty: Transfer input for native app only if the stdin is pcon.

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 9 00:48, Takashi Yano via Cygwin-patches wrote: > On Mon, 8 Mar 2021 16:32:16 +0100 > Corinna Vinschen wrote: > > Hi Takashi, > > > > On Mar 8 23:55, Takashi Yano via Cygwin-patches wrote: > > > - Currently, transfer input is triggered even if the stdin of native > > > app is not a

Re: [PATCH] Cygwin: pty: Transfer input for native app only if the stdin is pcon.

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 8 23:55, Takashi Yano via Cygwin-patches wrote: > - Currently, transfer input is triggered even if the stdin of native > app is not a pseudo console. With this patch it is triggered only > if the stdin is a pseudo console. > --- > winsup/cygwin/fhandler_tty.cc | 18 ++

Re: [PATCH] Cygwin: pty: Transfer input for native app only if the stdin is pcon.

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
Hi Takashi, On Mar 8 23:55, Takashi Yano via Cygwin-patches wrote: > - Currently, transfer input is triggered even if the stdin of native > app is not a pseudo console. With this patch it is triggered only > if the stdin is a pseudo console. do you have more patches in the loop? I wonder

Re: [PATCH] Cygwin: pty: Attach to stub process when non-cygwin app inherits pcon.

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 8 22:14, Takashi Yano via Cygwin-patches wrote: > - If two non-cygwin apps are started simultaneously, attaching to > pseudo console sometimes fails. This is because the second app > trys to attach to the process not started yet. This patch avoids > the issue by attaching to the stub

Re: [PATCH] winsup/doc/dll.xml: update MinGW/.org to MinGW-w64/.org

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 7 13:26, Brian Inglis wrote: > On 2021-03-07 12:15, Jon Turney wrote: > > On 07/03/2021 16:31, Brian Inglis wrote: > > > --- > > >   winsup/doc/dll.xml | 5 +++-- > > >   1 file changed, 3 insertions(+), 2 deletions(-) > > > I don't think the link here actually has much value, and would be

Re: [PATCH] winsup/doc/dll.xml: update MinGW/.org to MinGW-w64/.org

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 7 19:15, Jon Turney wrote: > On 07/03/2021 16:31, Brian Inglis wrote: > > --- > > winsup/doc/dll.xml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > I don't think the link here actually has much value, and would be inclined > to drop it, as far as I can tell it's

Re: [PATCH] Cygwin: console, pty: Stop ignoring Ctrl-C by IGNBRK.

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 7 10:41, Takashi Yano via Cygwin-patches wrote: > - Perhaps current code misunderstand meaning of the IGNBRK. As far > as I investigated, IGNBRK is concerned with break signal in serial > port but there is no evidence that it has effect to ignore Ctrl-C. > This patch stops ignoring

Re: [PATCH] Cygwin: pty: Discard input already accepted on interrupt.

2021-03-08 Thread Corinna Vinschen via Cygwin-patches
On Mar 5 18:01, Takashi Yano via Cygwin-patches wrote: > - Currently, input already accepted is not discarded on interrupt > by VINTR, VQUIT and VSUSP keys. This patch fixes the issue. > --- > winsup/cygwin/fhandler.h | 2 ++ > winsup/cygwin/fhandler_termios.cc | 5 - >

Re: [PATCH v2] Cygwin: console: Fix restoring console mode failure.

2021-03-05 Thread Corinna Vinschen via Cygwin-patches
On Mar 4 19:11, Takashi Yano via Cygwin-patches wrote: > - Restoring console mode fails in the following scenario. >1) Start cygwin shell in command prompt. >2) Run 'exec chcp.com'. > This patch fixes the issue. > --- > winsup/cygwin/fhandler.h | 1 + > winsup/cygwin/spawn.cc | 14

Re: [PATCH] Cygwin: pty: Fix a race issue in startup of pseudo console.

2021-03-05 Thread Corinna Vinschen via Cygwin-patches
On Mar 4 17:56, Takashi Yano via Cygwin-patches wrote: > - If two non-cygwin apps are started simultaneously and this is the > first execution of non-cygwin apps in the pty, these occasionally > hang up. The cause is the race issue between term_has_pcon_cap(), > reset_switch_to_pcon() and

Re: [PATCH] cygwin-htdocs/lists.html: add note about attachment size limits

2021-03-05 Thread Corinna Vinschen via Cygwin-patches
On Mar 3 20:55, Brian Inglis wrote: > committer please adjust based on actual size limits if different: > (256KB - 8KB email text)/1.37 overhead ~ 180KB > 180KB * 1.37 overhead + 8KB email text ~ 256KB > --- > lists.html | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 0/7] Fix some system calls on sockets

2021-03-01 Thread Corinna Vinschen via Cygwin-patches
On Feb 25 17:48, Ken Brown via Cygwin-patches wrote: > Several of the fhandler_socket_local and fhandler_socket_unix methods > that support system calls are written as though they are operating on > socket files unless the socket is an abstract socket. This patchset > (except for the last patch)

Re: [PATCH] Cygwin: AF_UNIX: allow opening with the O_PATH flag

2021-02-24 Thread Corinna Vinschen via Cygwin-patches
On Feb 23 12:44, Ken Brown via Cygwin-patches wrote: > This was done for the fhandler_socket_local class in commits > 3a2191653a, 141437d374, and 477121317d, but the fhandler_socket_unix > class was overlooked. > --- > winsup/cygwin/fhandler.h | 1 + >

Re: [PATCH 0/1] Fix facl on files opened with O_PATH

2021-02-24 Thread Corinna Vinschen via Cygwin-patches
On Feb 23 17:49, Ken Brown via Cygwin-patches wrote: > I'm not sure if this patch is right. Should facl fail on all commands > or just on SETACL? If the command is GETACL, for example, should this > fail like fgetxattr(2) or should it succeed like fstat(2)? > > Cygwin may be the only platform

Re: [PATCH] index.html: update Cygwin home page to show version 3.1.7

2021-02-24 Thread Corinna Vinschen via Cygwin-patches
On Feb 23 13:48, Brian Inglis wrote: > --- > index.html | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/index.html b/index.html > index 037a9d87c968..7aafecea8c2e 100755 > --- a/index.html > +++ b/index.html > @@ -50,7 +50,7 @@ > > > The most recent version

Re: [PATCH] Cygwin: console: Prevent NULL pointer access in close().

2021-02-22 Thread Corinna Vinschen via Cygwin-patches
On Feb 22 22:30, Takashi Yano via Cygwin-patches wrote: > - There seems to be a case that shared_console_info is not set yet > when close() is called. This patch adds guard for such case. > --- > winsup/cygwin/fhandler_console.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] Cygwin: pty: Fix segfault caused when tcflush() is called.

2021-02-22 Thread Corinna Vinschen via Cygwin-patches
On Feb 22 22:28, Takashi Yano via Cygwin-patches wrote: > On Mon, 22 Feb 2021 20:41:00 +0900 > Takashi Yano wrote: > > On Mon, 22 Feb 2021 10:51:19 +0100 > > Corinna Vinschen wrote: > > > So, what do you think is the state of the console code, Takashi? > > > Shall we start a release cycle next

Re: [PATCH] Cygwin: pty: Fix segfault caused when tcflush() is called.

2021-02-22 Thread Corinna Vinschen via Cygwin-patches
On Feb 22 20:41, Takashi Yano via Cygwin-patches wrote: > On Mon, 22 Feb 2021 10:51:19 +0100 > Corinna Vinschen wrote: > > So, what do you think is the state of the console code, Takashi? > > Shall we start a release cycle next week? > > I think all the fixes and improvements that come to mind at

Re: [PATCH] Cygwin: pty: Fix segfault caused when tcflush() is called.

2021-02-22 Thread Corinna Vinschen via Cygwin-patches
On Feb 21 07:45, Takashi Yano via Cygwin-patches wrote: > - After commit 253352e796ff9ec9a447e5375f5bc3e2b92b5293, mc (midnight > commander) crashes with segfault if the shell is bash. This is due > to NULL pointer access in read(). This patch fixes the issue. > Addresses:: >

Re: [PATCH 0/2] Cygwin: pty, console: Make FLUSHO and Ctrl-O work.

2021-02-19 Thread Corinna Vinschen via Cygwin-patches
On Feb 19 17:44, Takashi Yano via Cygwin-patches wrote: > - With these patches, FLUSHO and Ctrl-O (VDISCARD) get working. > > Takashi Yano (2): > Cygwin: pty: Make FLUSHO and Ctrl-O work. > Cygwin: console: Add support for FLUSHO and Ctrl-O. > > winsup/cygwin/fhandler.h | 1 + >

Re: [PATCH 0/3] Fix fstat on FIFOs, part 2

2021-02-19 Thread Corinna Vinschen via Cygwin-patches
On Feb 18 12:13, Ken Brown via Cygwin-patches wrote: > The first patch fixes a bug, in which fstat on FIFOs sometimes used > pipe handles instead of file handles. > > The second and third patches should improve the efficiency of fstat > and open on FIFOs. > > Ken Brown (3): > Cygwin: define

Re: [PATCH] Cygwin: pty: Make tty setting NOFLSH work.

2021-02-19 Thread Corinna Vinschen via Cygwin-patches
On Feb 18 18:07, Takashi Yano via Cygwin-patches wrote: > - With this patch, "stty noflsh" gets working in pty. > --- > winsup/cygwin/fhandler_termios.cc | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/winsup/cygwin/fhandler_termios.cc >

Re: [PATCH] Cygwin: pty: Reflect tty settings to pseudo console mode.

2021-02-19 Thread Corinna Vinschen via Cygwin-patches
On Feb 18 18:05, Takashi Yano via Cygwin-patches wrote: > - With this patch, tty setting such as echo, icanon, isig and onlcr > are reflected to pseudo console mode. > --- > winsup/cygwin/fhandler_tty.cc | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git

Re: [PATCH] Cygwin: Add console fix regarding Ctrl-Z etc. to release notes.

2021-02-19 Thread Corinna Vinschen via Cygwin-patches
On Feb 18 18:02, Takashi Yano via Cygwin-patches wrote: > --- > winsup/cygwin/release/3.2.0 | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/winsup/cygwin/release/3.2.0 b/winsup/cygwin/release/3.2.0 > index d02d16863..d69ed446c 100644 > --- a/winsup/cygwin/release/3.2.0 > +++

Re: [PATCH 0/2] Console fixes for Win7.

2021-02-19 Thread Corinna Vinschen via Cygwin-patches
On Feb 18 18:01, Takashi Yano via Cygwin-patches wrote: > Takashi Yano (2): > Cygwin: console: Fix SIGWINCH handling in Win7. > Cygwin: console: Fix handling of Ctrl-S in Win7. > > winsup/cygwin/fhandler.h | 9 +- > winsup/cygwin/fhandler_console.cc | 306

Re: [PATCH v2 0/2] cpuinfo: fix check; add AVX features; move SME, SEV/_ES features

2021-02-18 Thread Corinna Vinschen via Cygwin-patches
On Feb 17 09:28, Brian Inglis wrote: > Brian Inglis (2): > fix check for cpuid 0x8007 support > add AVX features; move SME, SEV/_ES features > > winsup/cygwin/fhandler_proc.cc | 46 ++ > 1 file changed, 24 insertions(+), 22 deletions(-) > > -- > 2.30.0

Re: [PATCH] cpuinfo: fix check; add AVX features; move SME, SEV/_ES features

2021-02-17 Thread Corinna Vinschen via Cygwin-patches
Hi Brian, On Feb 16 09:00, Brian Inglis wrote: > > fix cpuid 0x8007 supported check; > Linux 5.11  Valentine's Day Edition  added features and changes: > add Intel 0x0007 EDX:23 avx512_fp16 and 0x0007:1 EAX:4 avx_vnni; > group scattered AMD 0x801f EAX Secure Mem/Encrypted Virt

Re: [PATCH v2] Cygwin: console: Introduce new thread which handles input signal.

2021-02-17 Thread Corinna Vinschen via Cygwin-patches
On Feb 16 20:37, Takashi Yano via Cygwin-patches wrote: > - Currently, Ctrl-Z, Ctrl-\ and SIGWINCH does not work in console > if the process does not call read() or select(). This is because > these are processed in process_input_message() which is called > from read() or select(). This is a

Re: [PATCH v2] winsup/doc/posix.xml: add note for getrlimit, setrlimit, xrefs to notes

2021-02-17 Thread Corinna Vinschen via Cygwin-patches
On Feb 16 10:00, Brian Inglis wrote: > On 2021-02-16 09:51, Brian Inglis wrote: > > On 2021-02-16 04:30, Corinna Vinschen via Cygwin-patches wrote: > > > On Feb 15 15:35, Brian Inglis wrote: > > > > change notes to see "Implementation Notes" to xref to

Re: [PATCH v2] winsup/doc/posix.xml: add note for getrlimit, setrlimit, xrefs to notes

2021-02-16 Thread Corinna Vinschen via Cygwin-patches
Hi Brian, On Feb 15 15:35, Brian Inglis wrote: > > change notes to see "Implementation Notes" to xref to std-notes; > add xref to std-notes to getrlimit, setrlimit; > add note to document limitations of getrlimit, setrlimit resources support > --- > winsup/doc/posix.xml | 101

Re: [PATCH v2] Cygwin: console: Abort read() on signal if SA_RESTART is not set.

2021-02-15 Thread Corinna Vinschen via Cygwin-patches
On Feb 15 22:08, Takashi Yano via Cygwin-patches wrote: > On Mon, 15 Feb 2021 13:04:41 +0100 > Corinna Vinschen wrote: > > On Feb 14 18:42, Takashi Yano via Cygwin-patches wrote: > > > - Currently, console read() keeps reading after SIGWINCH is sent > > > even if SA_RESTART flag is not set. With

Re: [PATCH] Cygwin: pty: Fix a bug in input transfer for GDB.

2021-02-15 Thread Corinna Vinschen via Cygwin-patches
On Feb 15 03:47, Takashi Yano via Cygwin-patches wrote: > - With this patch, not only NL but also CR is treated as a line end > in the code checking if input transfer is necessary. > --- > winsup/cygwin/fhandler_tty.cc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] Cygwin: console: Abort read() on signal if SA_RESTART is not set.

2021-02-15 Thread Corinna Vinschen via Cygwin-patches
Hi Takashi, On Feb 14 18:42, Takashi Yano via Cygwin-patches wrote: > - Currently, console read() keeps reading after SIGWINCH is sent > even if SA_RESTART flag is not set. With this patch, read() > returns EINTR on SIGWINCH if SA_RESTART flag is not set. > The same problem for SIGQUIT and

Re: [PATCH] winsup/doc/posix.xml: add note for getrlimit, setrlimit, links to notes

2021-02-15 Thread Corinna Vinschen via Cygwin-patches
Hi Brian, On Feb 12 18:06, Brian Inglis wrote: > > change notes to see "Implementation Notes" to links to std-notes.html; > links work in html docs but appear as text in info docs; > add link to std-notes.html to getrlimit, setrlimit; > add note to document limitations of getrlimit, setrlimit

Re: [PATCH v2] Cygwin: pty: Reduce unecessary input transfer.

2021-02-12 Thread Corinna Vinschen via Cygwin-patches
On Feb 11 18:09, Takashi Yano via Cygwin-patches wrote: > - Currently, input transfer is performed every time one line is read(), > if the non-cygwin app is running in the background. With this patch, > transfer is triggered by setpgid() rather than read() so that the > unnecessary input

Re: [PATCH v2] Cygwin: Have tmpfile(3) use O_TMPFILE

2021-02-12 Thread Corinna Vinschen via Cygwin-patches
On Feb 10 22:53, Mark Geisert wrote: > Per discussion on cygwin-developers, a Cygwin tmpfile(3) implementation > has been added to syscalls.cc. This overrides the one supplied by > newlib. Then the open(2) flag O_TMPFILE was added to the open call that > tmpfile internally makes. > > This v2

Re: [PATCH] Cygwin: Have tmpfile(3) use O_TMPFILE

2021-02-10 Thread Corinna Vinschen via Cygwin-patches
On Feb 10 01:07, Mark Geisert wrote: > Hi Corinna, > > Corinna Vinschen via Cygwin-patches wrote: > > Hi Mark, > > > > On Feb 9 02:50, Mark Geisert wrote: > > > Per discussion on cygwin-developers, a Cygwin tmpfile(3) implementation > > > has been

Re: [PATCH 0/1] Fix fstat on FIFOs, part 1

2021-02-09 Thread Corinna Vinschen via Cygwin-patches
On Feb 9 10:11, Ken Brown via Cygwin-patches wrote: > Commit 76dca77f04 had a careless blunder, so this patch reverts it. > > Nevertheless, fstat(2) can be made more efficient on FIFOs, and I'm > working on a separate patchset to do this right. It's worth doing, > because every call to open(2)

Re: [PATCH] Cygwin: Have tmpfile(3) use O_TMPFILE

2021-02-09 Thread Corinna Vinschen via Cygwin-patches
Hi Mark, On Feb 9 02:50, Mark Geisert wrote: > Per discussion on cygwin-developers, a Cygwin tmpfile(3) implementation > has been added to syscalls.cc. This overrides the one supplied by > newlib. Then the open(2) flag O_TMPFILE was added to the open call that > tmpfile internally makes. > ---

Re: [PATCH 09/11] mount.cc: Implement poor-man's cache

2021-02-04 Thread Corinna Vinschen via Cygwin-patches
On Feb 3 12:38, Ben wrote: > > > On 18-01-2021 12:51, Corinna Vinschen via Cygwin-patches wrote: > > Ok, so hash_prefix reduces the path to a drive letter or the UNC path > > prefix and hashes it. However, what about partitions mounted to a > > subdir of,

Re: [PATCH v2 4/8] syscalls.cc: Implement non-path_conv dependent _unlink_nt

2021-02-04 Thread Corinna Vinschen via Cygwin-patches
On Feb 3 12:03, Ben wrote: > On 26-01-2021 12:34, Corinna Vinschen via Cygwin-patches wrote: > >> + static bool has_posix_unlink_semantics = > >> + wincap.has_posix_unlink_semantics (); > >> + static bool has_posix_unlink_

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-02-02 Thread Corinna Vinschen via Cygwin-patches
On Feb 1 22:26, Marek Smetana via Cygwin-patches wrote: > I'm Sorry, this is my first patch using the mailing list. No worries. Patch pushed. Thanks, Corinna

Re: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Feb 1 15:46, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: > > Except, the value has no meaning for ipv6. > > It'll print all 0's :-) But: > > minires does not make use of the _ext field. It does use the conventional > nsaddr_list (which is IPv4), > but only if Windows

Re: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Feb 1 14:23, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: > > Please use %ls, %S is non-standard. > > Sure. > > > For instance, write_record appears to handle DNS_TYPE_A, > > but not DNS_TYPE_. > > I can add that, it's not a problem. But indeed, reparsing of Windows

Re: [PATCH 0/4] getdtablesize, OPEN_MAX, etc.

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 29 14:24, Ken Brown via Cygwin-patches wrote: > This patchset is an extension of the patch submitted here: > > https://cygwin.com/pipermail/cygwin-patches/2021q1/011060.html > > That patch is included as the first patch in this set. The change to > OPEN_MAX still needs testing to see

Re: [PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Feb 1 10:50, Corinna Vinschen via Cygwin-patches wrote: > On Jan 28 15:33, Ken Brown via Cygwin-patches wrote: > > On 1/28/2021 11:07 AM, Corinna Vinschen via Cygwin-patches wrote: > > > One problem is that there are some applications in the wild which run > > >

Re: [PATCH] CYGWIN: Fix resolver debugging output

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
Hi Anton, On Jan 29 14:29, Anton Lavrentiev via Cygwin-patches wrote: > - Use %S (instead of %s) when a wide-character output is due; Please use %ls, %S is non-standard. > - Use native byte order for host and add port when doing I/O with DNS server; This puzzeled me a bit so I took another

Re: [PATCH] Cygwin: exceptions.cc: Suspend all threads in sig_handle_tty_stop().

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 29 12:46, Takashi Yano via Cygwin-patches wrote: > - Currently, thread created by pthread_create() is not suspended by > the signal SIGTSTP. For example, even if a process with a thread > is suspended by Ctrl-Z, the thread continues running. This patch > fixes the issue. > --- >

Re: [PATCH] Cygwin: console: Align the behaviour against signal with pty.

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 29 12:45, Takashi Yano via Cygwin-patches wrote: > - Currently, read() returns -1 with EINTR if the process is suspended > by Ctrl-Z and resumed by fg command, while pty continues to read. > For example, xxd command stops with error "Interrupted system call" > after Ctrl-Z and fg.

Re: [PATCH v3 0/2] Make terminal read() thread-safe.

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 28 23:11, Takashi Yano via Cygwin-patches wrote: > Currently read() for console and pty slave are somehow > not thread-safe. These patches fix the issue. > > Takashi Yano (2): > Cygwin: console: Make read() thread-safe. > Cygwin: pty: Make slave read() thread-safe. > >

Re: [PATCH 0/1] Recognizing native Windows AF_UNIX sockets

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 30 11:34, Ken Brown via Cygwin-patches wrote: > This patch attempts to fix the problem reported here: > > https://cygwin.com/pipermail/cygwin/2020-September/246362.html > > See also the followup here: > > https://cygwin.com/pipermail/cygwin/2021-January/247666.html > > The problem,

Re: [PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 28 15:33, Ken Brown via Cygwin-patches wrote: > On 1/28/2021 11:07 AM, Corinna Vinschen via Cygwin-patches wrote: > > One problem is that there are some applications in the wild which run > > loops up to either sysconf(_SC_OPEN_MAX) or OPEN_MAX to handle open > > desc

Re: [PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 29 14:23, Ken Brown via Cygwin-patches wrote: > On 1/28/2021 5:28 PM, Ken Brown via Cygwin-patches wrote: > > > ...ideally by adding a file include/cygwin/limits.h included by > > > include/limits.h, which defines __OPEN_MAX et al, as required. > > > > I'm not completely sure I follow.  Do

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-02-01 Thread Corinna Vinschen via Cygwin-patches
On Jan 29 23:06, Marek Smetana via Cygwin-patches wrote: > Hi, > > I have modified the patch as recommended and am sending it as an attachment. Great, but can you please attach the entire output of `git format-patch -1' including the commit message? Thanks, Corinna

Re: [PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
On Jan 28 17:07, Corinna Vinschen via Cygwin-patches wrote: > On Jan 28 08:42, Ken Brown via Cygwin-patches wrote: > > On 1/28/2021 5:20 AM, Corinna Vinschen via Cygwin-patches wrote: > > > On Jan 27 21:51, Ken Brown via Cygwin-patches wrote: > > > > A

Re: [PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
On Jan 28 08:42, Ken Brown via Cygwin-patches wrote: > On 1/28/2021 5:20 AM, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 27 21:51, Ken Brown via Cygwin-patches wrote: > > > According to the Linux man page for getdtablesize(3), the latter is > > > supposed to

Re: [PATCH v7 0/4] Improve pseudo console support.

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
On Jan 28 12:26, Takashi Yano via Cygwin-patches wrote: > The new implementation of pseudo console support by commit bb428520 > provides the important advantages, while there also has been several > disadvantages compared to the previous implementation. > > These patches overturn some of them. >

Re: [PATCH] Cygwin: getdtablesize: always return OPEN_MAX_MAX

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
On Jan 27 21:51, Ken Brown via Cygwin-patches wrote: > According to the Linux man page for getdtablesize(3), the latter is > supposed to return "the maximum number of files a process can have > open, one more than the largest possible value for a file descriptor." > The constant OPEN_MAX_MAX is

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
Oh, btw... On Jan 28 11:08, Corinna Vinschen via Cygwin-patches wrote: > Hi Marek, > > thanks for the patch. [...] > > index 17e8d83a3..933851c21 100644 > > --- a/winsup/cygwin/include/sys/termios.h > > +++ b/winsup/cygwin/include/sys/termios.h > > @

Re: fhandler_serial.cc: MARK and SPACE parity for serial port

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
Hi Marek, thanks for the patch. This is a patch adding functionality so it's not trivial. Would you mind to express your willingness to put this patch as well as further patches under 2-clause BSD license per the "Before you get started" section of https://cygwin.com/contrib.html? A few minor

Re: [PATCH v2] Cygwin: fchmodat: add limited support for AT_SYMLINK_NOFOLLOW

2021-01-28 Thread Corinna Vinschen via Cygwin-patches
On Jan 27 13:53, Ken Brown via Cygwin-patches wrote: > Allow fchmodat with the AT_SYMLINK_NOFOLLOW flag to succeed on > non-symlinks. Previously it always failed, as it does on Linux. But > POSIX permits it to succeed on non-symlinks even if it fails on > symlinks. > > The reason for following

Re: [PATCH] Cygwin: fchmodat: add limited support for AT_SYMLINK_NOFOLLOW

2021-01-27 Thread Corinna Vinschen via Cygwin-patches
On Jan 27 08:22, Ken Brown via Cygwin-patches wrote: > On 1/27/2021 7:40 AM, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 26 16:30, Ken Brown via Cygwin-patches wrote: > > > Allow fchmodat with the AT_SYMLINK_NOFOLLOW flag to succeed on > > > non-symlinks.

Re: [PATCH] Cygwin: fchmodat: add limited support for AT_SYMLINK_NOFOLLOW

2021-01-27 Thread Corinna Vinschen via Cygwin-patches
On Jan 26 16:30, Ken Brown via Cygwin-patches wrote: > Allow fchmodat with the AT_SYMLINK_NOFOLLOW flag to succeed on > non-symlinks. Previously it always failed, as it does on Linux. But > POSIX permits it to succeed on non-symlinks even if it fails on > symlinks. > > The reason for following

Re: [PATCH] Cygwin: chown: make sure ctime gets updated when necessary

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
On Jan 25 14:16, Ken Brown via Cygwin-patches wrote: > On 1/25/2021 1:57 PM, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 25 12:24, Ken Brown via Cygwin-patches wrote: > > > Following POSIX, ensure that ctime is updated if chown succeeds, > > > unless the new o

Re: [PATCH v2 7/8] dir.cc: Try unlink_nt first

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 17:10, Ben Wijen wrote: > Speedup deletion of directories. > --- > winsup/cygwin/dir.cc | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/winsup/cygwin/dir.cc b/winsup/cygwin/dir.cc > index 7762557d6..470f83aee 100644 > --- a/winsup/cygwin/dir.cc >

Re: [PATCH v2 6/8] syscalls.cc: Expose shallow-pathconv unlink_nt

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 17:10, Ben Wijen wrote: > Not having to query file information improves unlink speed. > --- > winsup/cygwin/syscalls.cc | 78 ++- > 1 file changed, 52 insertions(+), 26 deletions(-) > > diff --git a/winsup/cygwin/syscalls.cc

Re: [PATCH v2 4/8] syscalls.cc: Implement non-path_conv dependent _unlink_nt

2021-01-26 Thread Corinna Vinschen via Cygwin-patches
Hi Ben, ok, this is strong stuff, and apart from a couple of formatting issues, we should really discuss if a couple of things are feasible at all. On Jan 20 17:10, Ben Wijen wrote: > Implement _unlink_nt: wich does not depend on patch_conv > --- > winsup/cygwin/fhandler_disk_file.cc | 4 +- >

Re: [PATCH v3 2/8] syscalls.cc: Deduplicate remove

2021-01-25 Thread Corinna Vinschen via Cygwin-patches
On Jan 22 16:47, Ben Wijen wrote: > The remove code is already in the _remove_r function. > So, just call the _remove_r function. > --- > winsup/cygwin/syscalls.cc | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) Pushed. Thanks, Corinna

Re: [PATCH] Cygwin: chown: make sure ctime gets updated when necessary

2021-01-25 Thread Corinna Vinschen via Cygwin-patches
On Jan 25 12:24, Ken Brown via Cygwin-patches wrote: > Following POSIX, ensure that ctime is updated if chown succeeds, > unless the new owner is specified as (uid_t)-1 and the new group is > specified as (gid_t)-1. Previously, ctime was unchanged whenever the > owner and group were both

Re: [PATCH] Cygwin: console: Add missing guard regarding attach_mutex.

2021-01-25 Thread Corinna Vinschen via Cygwin-patches
On Jan 25 18:18, Takashi Yano via Cygwin-patches wrote: > - The commit a545 did not fix the problem enough. This patch > provides additional guard for the issue. > --- > winsup/cygwin/fhandler_console.cc | 27 +++ > 1 file changed, 27 insertions(+) Pushed. Thanks,

Re: [PATCH v2 2/8] syscalls.cc: Deduplicate remove

2021-01-22 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 17:10, Ben Wijen wrote: > The remove code is already in the _remove_r function. > So, just call the _remove_r function. > --- > winsup/cygwin/syscalls.cc | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/winsup/cygwin/syscalls.cc

Re: [PATCH v2 0/4] Improve pseudo console support.

2021-01-22 Thread Corinna Vinschen via Cygwin-patches
Hi Takashi, On Jan 22 05:58, Takashi Yano via Cygwin-patches wrote: > The new implementation of pseudo console support by commit bb428520 > provides the important advantages, while there also has been several > disadvantages compared to the previous implementation. > > These patches overturn

Re: [PATCH v2 0/4] Improve pseudo console support.

2021-01-22 Thread Corinna Vinschen via Cygwin-patches
On Jan 22 05:58, Takashi Yano via Cygwin-patches wrote: > The new implementation of pseudo console support by commit bb428520 > provides the important advantages, while there also has been several > disadvantages compared to the previous implementation. > > These patches overturn some of them. >

Re: [PATCH] Cygwin: normalize_posix_path: fix error handling when .. is encountered

2021-01-22 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 10:40, Ken Brown via Cygwin-patches wrote: > When .. is in the source path and the path prefix exists but is not a > directory, return ENOTDIR instead of ENOENT. This fixes a failing > gnulib test of realpath(3). > > Addresses:

Re: [PATCH] Cygwin: ptsname_r: always return an error number on failure

2021-01-22 Thread Corinna Vinschen via Cygwin-patches
On Jan 21 17:48, Ken Brown via Cygwin-patches wrote: > On 1/20/2021 1:00 PM, Ken Brown via Cygwin-patches wrote: > > Following Linux, return ENOTTY on a bad file descriptor and also set > > errno to ENOTTY. > > > > Previously 0 was returned and errno was set to EBADF. Returning 0 > > violates

Re: [PATCH] Cygwin: pty: Reduce buffer size in get_console_process_id().

2021-01-20 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 19:40, Takashi Yano via Cygwin-patches wrote: > On Wed, 20 Jan 2021 10:50:24 +0100 > Corinna Vinschen wrote: > > On Jan 20 09:57, Takashi Yano via Cygwin-patches wrote: > > > - The buffer used in get_console_process_id(), introduced by commit > > > 72770148, is too large and

Re: [PATCH] Cygwin: console: Fix "Bad file descriptor" error in script command.

2021-01-20 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 18:16, Takashi Yano via Cygwin-patches wrote: > - After the commit 72770148, script command exits occasionally with > the error "Bad file descriptor" if it is started in console on Win7 > and non-cygwin process is executed. This patch fixes the issue. > --- >

Re: [PATCH] Cygwin: pty: Reduce buffer size in get_console_process_id().

2021-01-20 Thread Corinna Vinschen via Cygwin-patches
On Jan 20 09:57, Takashi Yano via Cygwin-patches wrote: > - The buffer used in get_console_process_id(), introduced by commit > 72770148, is too large and ERROR_NOT_ENOUGH_MEMORY occurs in Win7. Huh, funny! Will we ever be happy with just 8192 processes per console? :) > Therefore, the

Re: [PATCH] Cygwin: pty: Lessen the side effect of workaround for rlwarp.

2021-01-19 Thread Corinna Vinschen via Cygwin-patches
On Jan 19 18:27, Takashi Yano via Cygwin-patches wrote: > - This patch lessens the side effect of the workaround for rlwrap > introduced by commit 4e16b033. > --- > winsup/cygwin/fhandler_tty.cc | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH] Cygwin: spawn.cc: Fix typo in comment by commit 974e6d76.

2021-01-19 Thread Corinna Vinschen via Cygwin-patches
On Jan 19 03:45, Takashi Yano via Cygwin-patches wrote: > --- > winsup/cygwin/spawn.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc > index 42044ab53..d03492ee6 100644 > --- a/winsup/cygwin/spawn.cc > +++

Re: [PATCH 11/11] dir.cc: Try unlink_nt first

2021-01-19 Thread Corinna Vinschen via Cygwin-patches
On Jan 18 18:07, Ben wrote: > > > On 18-01-2021 13:13, Corinna Vinschen via Cygwin-patches wrote: > > > > Your code is skipping the safety checks and the has_dot_last_component() > > check. The latter implements a check required by POSIX. Skipping > > it intro

Re: [PATCH 08/11] path.cc: Allow to skip filesystem checks

2021-01-19 Thread Corinna Vinschen via Cygwin-patches
On Jan 18 18:15, Ben wrote: > > > On 18-01-2021 12:36, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 15 14:45, Ben Wijen wrote: > > > > Without any code setting the flag, this doesn't seem to make any > > sense. At least the commit mess

Re: [PATCH] Cygwin: pty: Set input_available_event only for cygwin pipe.

2021-01-18 Thread Corinna Vinschen via Cygwin-patches
On Jan 19 00:00, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Fri, 15 Jan 2021 18:26:31 +0900 > Takashi Yano wrote: > > - cat exits immediately in the following senario. > > 1) Execute env CYGWIN=disable_pcon script > > 2) Execute cmd.exe > > 3) Execute cat in cmd.exe.

Re: [PATCH 05/11] Cygwin: Move post-dir unlink check

2021-01-18 Thread Corinna Vinschen via Cygwin-patches
On Jan 18 15:31, Ben wrote: > On 18-01-2021 12:08, Corinna Vinschen via Cygwin-patches wrote: > > On Jan 15 14:45, Ben Wijen wrote: > >> Move post-dir unlink check from > >> fhandler_disk_file::rmdir to _unlink_nt > > > > Why? It's not much of a pr

  1   2   >