RE: [EXTERNAL] Re: [PATCH] Cygwin: spawn: Treat empty path as the current directory.

>However, use of this feature is deprecated, and POSIX >notes that a conforming application shall use an explicit >pathname (e.g., .) to specify the current working >directory. Since "SHALL" does not mean "MUST", I think this patch i

RE: [PATCH] Cygwin: resolver: A few fixes for cygwin_query(), part 2

> Great, thanks! I pushed all your resolver patches. Thank you! I'll be submitting the last tiny little one in a sec :-) Anton Lavrentiev Contractor NIH/NLM/NCBI

RE: [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)

> Thanks for the description. Would you mind to recreate your patch with > a matching commit message text explaining the debug flag setting? Okay, just did. Anton Lavrentiev Contractor NIH/NLM/NCBI

RE: [EXTERNAL] Re: [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)

> I pushed patches 1 and 3 to 5. I fixed the consitency typo > throughout. Thanks! (and oops :-) > Right now, the debug flag gets set in several places throughout the > code. Given you set the debug flag above, doesn't that mean several > code snippets setting the debug flag later in the code

RE: [EXTERNAL] Re: [PATCH] Cygwin: Conditionally build documentation

> It is reported by 'configure --help', at the appropriate level (although > since enable is the default, I probably should have written > '--disable-doc' here). Can you please make it show as --disable-doc ? Also, can you please make it visible in the top-level configure? Thanks, Anton Lavrent

RE: resolver //Was: [PATCH 3/7] Debug output to show both IP and port # in native b.o., a few little cosmetic improvements for consistency

Hi Corinna, > Other than that, the remaining patches look good, except, adding a short > description what patch 7 does to the commit message would be great for > later readers of the git log. I resubmitted the patches with a little improvement and a better description to the #7 (now #5) as reques

RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

> Just the suggestion that as all standards support using %#08x to prefix > with 0x (prefix output capitalization follows format letter > capitalization) and would be preferable to hacking the text 0x onto the > format %08X, doing all of the formatting work with the format flags. First off, I am p

RE: [EXTERNAL] Re: [PATCH] Cygwin: Conditionally build documentation

> It is reported by 'configure --help', at the appropriate level (although > since enable is the default, I probably should have written > '--disable-doc' here). I'm sorry if I'm missing anything, but I updated y'day and this is what I see regarding the doc in configure: $ ./configure --help | g

RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

So? With %X (capital X) the alternate form has the prefix 0X capital, too; and it's really hard to read. IDK what is exactly your point that you are trying to make, is my patch somehow incorrect, or what? Anton Lavrentiev Contractor NIH/NLM/NCBI > -Original Message- > From: Brian Ingl

RE: [PATCH] Cygwin: Conditionally build documentation

> > Add a configure option '--disable-doc' to disable building of the > documentation by the 'all' target. > Can you please also add --disable-doc to "configure --help"? It took me awhile to figure out which option I should use to skip the doc from building because it does no longer ignore doc

RE: Fix nanosleep returning negative rem

> I can get it easily get this on my desktop (AMD Ryzen Threadripper 3990X) but > not at all on my laptop (Intel Core i7-8650U) Not sure if that's really related but: Have you checked what is your default Windows timer resolution? Some applications change it from the default 100HZ to 1000HZ (b

RE: [PATCH] CYGWIN: Fix resolver debugging output

> with some customizations, and not noticed any issues so far. Should I be wary > in future? Have you used the / APIs, or low-level DNS other than with getXbyY(), or maybe debugged DNS? The changes are not to remove any existing functionality -- I don't see how that was not clear -- but to mak

RE: [PATCH] CYGWIN: Fix resolver debugging output

> Except, the value has no meaning for ipv6. It'll print all 0's :-) But: minires does not make use of the _ext field. It does use the conventional nsaddr_list (which is IPv4), but only if Windows native DNS API is not used: "osquery"(aka use_os)=0. For debugging purposes, that is enough and

RE: [PATCH] CYGWIN: Fix resolver debugging output

> Please use %ls, %S is non-standard. Sure. > For instance, write_record appears to handle DNS_TYPE_A, > but not DNS_TYPE_. I can add that, it's not a problem. But indeed, reparsing of Windows packets, does miss (as well as some other types, such as URI -- not sure if Windows has it, t

RE: [PATCH] format_proc_cpuinfo: add microcode registry lookup values

Hi, This is shifting up, IMO: + microcode <<= 32; /* shift them down */ Thanks, Anton > -Original Message- > From: Brian Inglis > Sent: Tuesday, July 07, 2020 1:34 PM > To: cygwin-patches@cygwin.com > Subject: [PATCH] format_proc_cpuinfo: add microcode regis

RE: [PATCH] Cygwin: console: Ignore 0x00 on write().

JFYI: Both 0x00 (NUL) and 0x7F (DEL) used to be the filler characters, and were ignored by most (hardware) terminals from the very early days. HTH, Anton > -Original Message- > From: cygwin-patches-ow...@cygwin.com On > Behalf Of Takashi Yano > Sent: Thursday, February 20, 2020 6:52 AM

RE: [PATCH] Cygwin: pty: Fix ESC[?3h and ESC[?3l handling again.

Just noticed that in the patch below and couldn't help it, sorry.. Things like char* p0; and later: isdigit(*p0)) or isalpha(*p0) are usually not a good (correct) way of coding, because of possible sign extension of *p0 which you normally wouldn't want to have (remember the ctype calls/macr

RE: cygrunsrv patch

> git://sourceware.org/git/cygwin-apps/cygrunsrv.git Thanks, that worked. I was using a static source archive (cygrunsrv-1.62) to make all the changes, so didn't need git until now.

cygrunsrv patch

Hi, Looks like I finally prepared a patch for cygrunsrv that I mentioned as an added feature way back in Feb (I did not need to come around to that since then): https://cygwin.com/ml/cygwin/2019-02/msg00173.html But the GIT URL given in the message does not seem to work for me: https://cygwin

RE: [PATCH] Cygwin: getpriority() consistent with process priority

> Pushed. Thank you! It took me awhile, sorry about that -- was extremely busy with stuff and travel