Re: [PATCH] --std=c89 error in sys/signal.h

2009-10-05 Thread Corinna Vinschen
On Oct 5 09:18, Yaakov S wrote: > On 05/10/2009 03:37, Corinna Vinschen wrote: >> Newlib, methinks. > > OK, I'll send a patch there. > >> I think the newlib kill declaration should be changed to pid_t, since >> that's simply correct per POSIX. >> >> I can;t believe the RTEMS people have a problem

Re: [PATCH] --std=c89 error in sys/signal.h

2009-10-05 Thread Yaakov (Cygwin/X)
On 05/10/2009 03:37, Corinna Vinschen wrote: Newlib, methinks. OK, I'll send a patch there. I think the newlib kill declaration should be changed to pid_t, since that's simply correct per POSIX. I can;t believe the RTEMS people have a problem with that. Did you forget about the ESTRPIPE ep

Re: [PATCH] --std=c89 error in sys/signal.h

2009-10-05 Thread Corinna Vinschen
On Oct 4 20:44, Yaakov S wrote: > On 29/09/2009 20:11, Yaakov (Cygwin/X) wrote: >> On 29/09/2009 19:35, Yaakov (Cygwin/X) wrote: >>> Anyway, to answer the question, AFAICS in glibc, #include >>> unconditionally[1]. ( is just one line: >>> #include [2]) >>> >>> So should I take the first route,

Re: [PATCH] --std=c89 error in sys/signal.h

2009-10-04 Thread Yaakov (Cygwin/X)
On 29/09/2009 20:11, Yaakov (Cygwin/X) wrote: On 29/09/2009 19:35, Yaakov (Cygwin/X) wrote: Anyway, to answer the question, AFAICS in glibc, #include unconditionally[1]. ( is just one line: #include [2]) So should I take the first route, patching newlib instead? OTOH, this comment in the o

Re: [PATCH] --std=c89 error in sys/signal.h

2009-09-29 Thread Yaakov (Cygwin/X)
On 29/09/2009 19:35, Yaakov (Cygwin/X) wrote: Anyway, to answer the question, AFAICS in glibc, #include unconditionally[1]. ( is just one line: #include [2]) So should I take the first route, patching newlib instead? OTOH, this comment in the offending hunk of (which is only for Cygwin an

Re: [PATCH] --std=c89 error in sys/signal.h

2009-09-29 Thread Yaakov (Cygwin/X)
On 29/09/2009 17:33, Christopher Faylor wrote: I see two possible solutions: 1) Unconditionally #include in (newlib), OR 2) #include in. Since this appears to be Cygwin specific, I went for the latter. Patch attached. WDLD? On IRC: cygwinports: cgf: wtf WDLD? cgf: What Does Linux Do? c

Re: [PATCH] --std=c89 error in sys/signal.h

2009-09-29 Thread Christopher Faylor
On Tue, Sep 29, 2009 at 03:50:53PM -0500, Yaakov (Cygwin/X) wrote: >Compiling a file which #include's in C89 mode fails: > >$ echo "#include " > test.c >$ gcc -c test.c >$ gcc -c -std=c89 test.c >In file included from /usr/include/sys/signal.h:107, > from test.c:1: >/usr/include/c

[PATCH] --std=c89 error in sys/signal.h

2009-09-29 Thread Yaakov (Cygwin/X)
Compiling a file which #include's in C89 mode fails: $ echo "#include " > test.c $ gcc -c test.c $ gcc -c -std=c89 test.c In file included from /usr/include/sys/signal.h:107, from test.c:1: /usr/include/cygwin/signal.h:74: error: expected specifier-qualifier-list before 'pthrea