[PATCH] fix build warnings for functions without return value

2010-07-28 Thread Daniel Colascione
Stop warnings about function not returning a value; the value is meaningless anyway, but the compiler can't know that. Index: cygwin-1.7.5-1/winsup/cygwin/fhandler_tty.cc === --- cygwin-1.7.5-1.orig/winsup/cygwin/fhandler_tty.cc +++ cy

Re: [PATCH] fix build warnings for functions without return value

2010-07-28 Thread Christopher Faylor
On Wed, Jul 28, 2010 at 02:11:33PM -0700, Daniel Colascione wrote: >Stop warnings about function not returning a value; the value is meaningless >anyway, but the compiler can't know that. I don't see why this is needed. Cygwin uses -Werror by default so, if gcc 4.3.4 emitted warnings we wouldn't

RE: [PATCH] fix build warnings for functions without return value

2010-07-28 Thread Daniel Colascione
> From: cygwin-patches-ow...@cygwin.com [mailto:cygwin-patches- > > I don't see why this is needed. Cygwin uses -Werror by default so, if gcc 4.3.4 > emitted warnings we wouldn't be able to build a release or make a snapshot. It's because Cygwin uses -Werror that I had to patch the source. I'm co

Re: [PATCH] fix build warnings for functions without return value

2010-07-28 Thread Dave Korn
On 29/07/2010 00:19, Daniel Colascione wrote: >> From: cygwin-patches-ow...@cygwin.com [mailto:cygwin-patches- >> >> I don't see why this is needed. Cygwin uses -Werror by default so, if gcc > 4.3.4 >> emitted warnings we wouldn't be able to build a release or make a > snapshot. > > It's because

Re: [PATCH] fix build warnings for functions without return value

2010-07-28 Thread Christopher Faylor
On Wed, Jul 28, 2010 at 04:19:22PM -0700, Daniel Colascione wrote: >> From: cygwin-patches-owner >> >>I don't see why this is needed. Cygwin uses -Werror by default so, if >>gcc 4.3.4 emitted warnings we wouldn't be able to build a release or >>make a snapshot. > >It's because Cygwin uses -Werror