Re[4]: [PATCH] setup.exe: mkdir.cc. was: setup.exe crash

2002-03-26 Thread Pavel Tsekov
>> Btw. I haven't checked if the new return value is a problem >> for any of the mkdir_p () callers. RC> Oh, it may well be, so I was going to checkin a variant anyway: RC> 1 is failure :}. Uh, yes... Thanks! I was sure I'm missing something :)

Re[2]: [PATCH] setup.exe: mkdir.cc. was: setup.exe crash

2002-03-26 Thread Pavel Tsekov
Hello Robert, Tuesday, March 26, 2002, 12:10:09 PM, you wrote: RC> Pavel, RC> care to supply a changelog? Thanks for tracking this down too. Of course! :) I didn't supply it the first time because I've sent the patch for review. Btw. I haven't checked if the new return value is a prob

RE: Re[2]: [PATCH] setup.exe: mkdir.cc. was: setup.exe crash

2002-03-26 Thread Robert Collins
> -Original Message- > From: Pavel Tsekov [mailto:[EMAIL PROTECTED]] > Sent: Tuesday, March 26, 2002 10:28 PM > To: Robert Collins > Cc: [EMAIL PROTECTED] > Subject: Re[2]: [PATCH] setup.exe: mkdir.cc. was: setup.exe crash > > > Hello Robert, > > Tue

RE: [PATCH] setup.exe: mkdir.cc. was: setup.exe crash

2002-03-26 Thread Robert Collins
Pavel, care to supply a changelog? Thanks for tracking this down too. Rob

[PATCH] setup.exe: mkdir.cc. was: setup.exe crash

2002-03-26 Thread Pavel Tsekov
Here is a solution for this problem. Please, review. To reproduce the crash write manually a path with non-existent drive in the local package directory edit control. The reason for this crash is that mkdir_p tries to create the path recursevly and does not care if its actually a path component