Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Peter Foley
On Sun, Mar 20, 2016 at 5:55 AM, Corinna Vinschen wrote: > There's an assign.txt document you (and potentiall your employer) can > sign and send as PDF. It's usually rather painless. > > > Thanks, > Corinna Copyright assignment form signed and emailed. Thanks, Peter Foley

Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > initial_sp has been unused since commit fbf23e3 back in 2000. > Keep the value, so as to avoid changing the offset of magic_biscuit. > > winsup/cygwin/lib/_cygwin_crt0_common.cc:140:52: > error: calling 'void* __builtin_frame_address(unsigned int)' with a > no

Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Corinna Vinschen
Hi Peter, thanks for the patch series. With the exception of patch 6 all of them are short enough to go in as trivial patches. However, for patch 6 we'd need a copyright assignment from you. Please have a look at the "Before you get started" section on https://cygwin.com/contrib.html There's

[PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-19 Thread Peter Foley
initial_sp has been unused since commit fbf23e3 back in 2000. Keep the value, so as to avoid changing the offset of magic_biscuit. winsup/cygwin/lib/_cygwin_crt0_common.cc:140:52: error: calling 'void* __builtin_frame_address(unsigned int)' with a nonzero argument is unsafe [-Werror=frame-address]