Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-29 Thread Corinna Vinschen
On Jan 27 15:12, Jon Turney wrote: > On 26/01/2024 11:52, Corinna Vinschen wrote: > > > - Create a named mutex with a reproducible name (no need to use > > >the name as parameter) and immediately grab it. > > > - Call CreateProcess to start the debugger with CREATE_SUSPENDED > > >flag. > >

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-27 Thread Jon Turney
On 26/01/2024 11:52, Corinna Vinschen wrote: On Jan 26 12:12, Corinna Vinschen wrote: On Jan 25 20:03, Jon Turney wrote: On 25/01/2024 18:21, Corinna Vinschen wrote: On Jan 25 14:50, Jon Turney wrote: On 24/01/2024 14:39, Corinna Vinschen wrote: On Jan 24 13:28, Jon Turney wrote: On

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-26 Thread Corinna Vinschen
On Jan 26 12:12, Corinna Vinschen wrote: > On Jan 25 20:03, Jon Turney wrote: > > On 25/01/2024 18:21, Corinna Vinschen wrote: > > > On Jan 25 14:50, Jon Turney wrote: > > > > On 24/01/2024 14:39, Corinna Vinschen wrote: > > > > > On Jan 24 13:28, Jon Turney wrote: > > > > > > On 23/01/2024 14:29,

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-26 Thread Corinna Vinschen
On Jan 25 20:03, Jon Turney wrote: > On 25/01/2024 18:21, Corinna Vinschen wrote: > > On Jan 25 14:50, Jon Turney wrote: > > > On 24/01/2024 14:39, Corinna Vinschen wrote: > > > > On Jan 24 13:28, Jon Turney wrote: > > > > > On 23/01/2024 14:29, Corinna Vinschen wrote: > > > > > > On Jan 23 14:20,

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-25 Thread Jon Turney
On 25/01/2024 18:21, Corinna Vinschen wrote: On Jan 25 14:50, Jon Turney wrote: On 24/01/2024 14:39, Corinna Vinschen wrote: On Jan 24 13:28, Jon Turney wrote: On 23/01/2024 14:29, Corinna Vinschen wrote: On Jan 23 14:20, Jon Turney wrote: [...] So this situation with a JIT debugger is

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-25 Thread Corinna Vinschen
On Jan 25 14:50, Jon Turney wrote: > On 24/01/2024 14:39, Corinna Vinschen wrote: > > On Jan 24 13:28, Jon Turney wrote: > > > On 23/01/2024 14:29, Corinna Vinschen wrote: > > > > On Jan 23 14:20, Jon Turney wrote: > > > > > > > > > Even then this is clearly not totally bullet-proof. Maybe the

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-25 Thread Jon Turney
On 24/01/2024 14:39, Corinna Vinschen wrote: On Jan 24 13:28, Jon Turney wrote: On 23/01/2024 14:29, Corinna Vinschen wrote: On Jan 23 14:20, Jon Turney wrote: Even then this is clearly not totally bullet-proof. Maybe the right thing to do is add a suitable timeout here, so even if we fail

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-24 Thread Corinna Vinschen
On Jan 24 13:28, Jon Turney wrote: > On 23/01/2024 14:29, Corinna Vinschen wrote: > > On Jan 23 14:20, Jon Turney wrote: > > > > > Even then this is clearly not totally bullet-proof. Maybe the right thing > > > to > > > do is add a suitable timeout here, so even if we fail to notice the > > >

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-24 Thread Jon Turney
On 23/01/2024 14:29, Corinna Vinschen wrote: On Jan 23 14:20, Jon Turney wrote: Even then this is clearly not totally bullet-proof. Maybe the right thing to do is add a suitable timeout here, so even if we fail to notice the DebugActiveProcess() (or there's a custom JIT debugger which just

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-23 Thread Corinna Vinschen
On Jan 23 14:20, Jon Turney wrote: > On 12/01/2024 14:09, Jon Turney wrote: > > Pre-format a command to be executed on a fatal error to run 'dumper' > > (using an absolute path). > > > > Factor out executing a pre-formatted command, so we can use that for > > invoking the JIT debugger in

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-23 Thread Jon Turney
On 12/01/2024 14:09, Jon Turney wrote: Pre-format a command to be executed on a fatal error to run 'dumper' (using an absolute path). Factor out executing a pre-formatted command, so we can use that for invoking the JIT debugger in try_to_debug() (if error_start is present in the CYGWIN env

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-16 Thread Corinna Vinschen
On Jan 16 13:52, Jon Turney wrote: > On 15/01/2024 14:28, Corinna Vinschen wrote: > > On Jan 15 13:27, Jon Turney wrote: > > > On 15/01/2024 09:46, Corinna Vinschen wrote: > > > > On Jan 13 14:20, Jon Turney wrote: > > > > > On 12/01/2024 14:09, Jon Turney wrote: > > > > > > + > > > > > > +

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-16 Thread Jon Turney
On 15/01/2024 14:28, Corinna Vinschen wrote: On Jan 15 13:27, Jon Turney wrote: On 15/01/2024 09:46, Corinna Vinschen wrote: On Jan 13 14:20, Jon Turney wrote: On 12/01/2024 14:09, Jon Turney wrote: + + PWCHAR cp = dumper_command; + cp = wcpcpy (cp, L"\""); + cp = wcpcpy (cp, dll_dir); +

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-15 Thread Corinna Vinschen
On Jan 15 13:27, Jon Turney wrote: > On 15/01/2024 09:46, Corinna Vinschen wrote: > > On Jan 13 14:20, Jon Turney wrote: > > > On 12/01/2024 14:09, Jon Turney wrote: > > > > + > > > > + PWCHAR cp = dumper_command; > > > > + cp = wcpcpy (cp, L"\""); > > > > + cp = wcpcpy (cp, dll_dir); > > > > +

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-15 Thread Jon Turney
On 15/01/2024 09:46, Corinna Vinschen wrote: On Jan 13 14:20, Jon Turney wrote: On 12/01/2024 14:09, Jon Turney wrote: + + PWCHAR cp = dumper_command; + cp = wcpcpy (cp, L"\""); + cp = wcpcpy (cp, dll_dir); + cp = wcpcpy (cp, L"\\dumper.exe"); + cp = wcpcpy (cp, L"\" "); + cp = wcpcpy

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-15 Thread Corinna Vinschen
On Jan 13 14:20, Jon Turney wrote: > On 12/01/2024 14:09, Jon Turney wrote: > > + > > + PWCHAR cp = dumper_command; > > + cp = wcpcpy (cp, L"\""); > > + cp = wcpcpy (cp, dll_dir); > > + cp = wcpcpy (cp, L"\\dumper.exe"); > > + cp = wcpcpy (cp, L"\" "); > > + cp = wcpcpy (cp, L"\""); > > +

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-13 Thread Jon Turney
On 12/01/2024 14:09, Jon Turney wrote: + + PWCHAR cp = dumper_command; + cp = wcpcpy (cp, L"\""); + cp = wcpcpy (cp, dll_dir); + cp = wcpcpy (cp, L"\\dumper.exe"); + cp = wcpcpy (cp, L"\" "); + cp = wcpcpy (cp, L"\""); + cp = wcpcpy (cp, global_progname); I wonder if this should be

[PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-12 Thread Jon Turney
Pre-format a command to be executed on a fatal error to run 'dumper' (using an absolute path). Factor out executing a pre-formatted command, so we can use that for invoking the JIT debugger in try_to_debug() (if error_start is present in the CYGWIN env var) and to invoke dumper when a fatal error