RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> Just the suggestion that as all standards support using %#08x to prefix > with 0x (prefix output capitalization follows format letter > capitalization) and would be preferable to hacking the text 0x onto the > format %08X, doing all of the formatting work with the format flags. First off, I am p

Re: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Brian Inglis
bject: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and are confident the content is safe. See fprintf(3p) POSIX: # Specifies that the value is

RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
From: Brian Inglis > Sent: Friday, January 14, 2022 11:38 PM > To: cygwin-patches@cygwin.com > Subject: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS > > CAUTION: This email originated from outside of the organization. Do not click > links or > open attachments unl

Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-14 Thread Brian Inglis
See fprintf(3p) POSIX: # Specifies that the value is to be converted to an alternative form. ... For x or X conversion specifiers, a non-zero result shall have 0x (or 0X) prefixed to it. On 2022-01-14 15:10, Anton Lavrentiev via Cygwin-patches wrote: --- winsup/cygwin/libc/minires-os

[PATCH 2/7] Use matching format for NTSTATUS

2022-01-14 Thread Anton Lavrentiev via Cygwin-patches
--- winsup/cygwin/libc/minires-os-if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/winsup/cygwin/libc/minires-os-if.c b/winsup/cygwin/libc/minires-os-if.c index 666a008de..6e17de0b8 100644 --- a/winsup/cygwin/libc/minires-os-if.c +++ b/winsup/cygwin/libc/minires-os-if.