Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-12 Thread Takashi Yano
On Tue, 12 Nov 2019 13:46:04 + Ken Brown wrote: > On 11/11/2019 9:55 PM, Takashi Yano wrote: > > Hi Ken, > > > > On Mon, 11 Nov 2019 19:39:46 + > > Ken Brown wrote: > >> After this commit, the XWin Server Start Menu shortcut no longer works. I > >> think > >> it's

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-12 Thread Ken Brown
On 11/11/2019 9:55 PM, Takashi Yano wrote: > Hi Ken, > > On Mon, 11 Nov 2019 19:39:46 + > Ken Brown wrote: >> After this commit, the XWin Server Start Menu shortcut no longer works. I >> think >> it's /usr/bin/xwin-xdg-menu.exe that fails, but I haven't checked this >> carefully. > >

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-11 Thread Takashi Yano
Hi Ken, On Mon, 11 Nov 2019 19:39:46 + Ken Brown wrote: > After this commit, the XWin Server Start Menu shortcut no longer works. I > think > it's /usr/bin/xwin-xdg-menu.exe that fails, but I haven't checked this > carefully. Could you please check whether the attached patch solves the

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-11 Thread Ken Brown
Hi Takashi, On 11/6/2019 11:29 AM, Takashi Yano wrote: > --- > winsup/cygwin/environ.cc | 2 +- > winsup/cygwin/fhandler.h | 1 + > winsup/cygwin/fhandler_console.cc | 46 --- > winsup/cygwin/fhandler_tty.cc | 14 ++ > 4 files

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-08 Thread Corinna Vinschen
On Nov 8 21:01, Takashi Yano wrote: > Hi Corinna, > > On Fri, 8 Nov 2019 10:22:30 +0100 > Corinna Vinschen wrote: > > Pushed, albeit I'm still missing a bit of description here. Just a one > > liner is a bit low on info during `git log'. I'd really appreciate more > > descriptive log

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-08 Thread Takashi Yano
Hi Corinna, On Fri, 8 Nov 2019 10:22:30 +0100 Corinna Vinschen wrote: > Pushed, albeit I'm still missing a bit of description here. Just a one > liner is a bit low on info during `git log'. I'd really appreciate more > descriptive log messages... Oh! Does "log message" mean git commit message?

Re: [PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-08 Thread Corinna Vinschen
On Nov 7 01:29, Takashi Yano wrote: > --- Pushed, albeit I'm still missing a bit of description here. Just a one liner is a bit low on info during `git log'. I'd really appreciate more descriptive log messages... > winsup/cygwin/environ.cc | 2 +- > winsup/cygwin/fhandler.h

[PATCH v3] Cygwin: console, pty: Prevent error in legacy console mode.

2019-11-06 Thread Takashi Yano
--- winsup/cygwin/environ.cc | 2 +- winsup/cygwin/fhandler.h | 1 + winsup/cygwin/fhandler_console.cc | 46 --- winsup/cygwin/fhandler_tty.cc | 14 ++ 4 files changed, 46 insertions(+), 17 deletions(-) diff --git