[Patch] cygcheck: pretty_id misbehaving.

2004-10-14 Thread Bas van Gompel
Hi, here is yet another (trivial, I hope) patch. It makes pretty_id behave as (I expect) it was supposed to. It involves: Incrementing ``i'' in only one place, skipping over ``groups='' only once, counting ")" (twice), fixing 2 printf-formats and setting ``n'' to 1 if it is 0. ChangeLog-entry:

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-14 Thread Christopher Faylor
On Thu, Oct 14, 2004 at 05:31:16PM +0200, Bas van Gompel wrote: >Hi, > >here is yet another (trivial, I hope) patch. > >It makes pretty_id behave as (I expect) it was supposed to. > >It involves: Incrementing ``i'' in only one place, skipping over >``groups='' only once, counting ")" (twice), fixin

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-15 Thread Bas van Gompel
Op Thu, 14 Oct 2004 13:36:21 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Thu, Oct 14, 2004 at 05:31:16PM +0200, Bas van Gompel wrote: [...] : > * cygcheck.cc (pretty_id): Correct layout. : : Thanks for the patch but I think it's possible to do this and make : things a li

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-15 Thread Christopher Faylor
On Fri, Oct 15, 2004 at 02:03:24PM +0200, Bas van Gompel wrote: >ChangeLog-entry: > >2004-10-15 Bas van Gompel <[EMAIL PROTECTED]> > > * cygcheck.cc (pretty_id): Don't exit, return. Correct layout. Thanks. I've checked in a variation of this patch. I don't see any reason to guard against

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-15 Thread Bas van Gompel
Op Fri, 15 Oct 2004 09:59:04 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Fri, Oct 15, 2004 at 02:03:24PM +0200, Bas van Gompel wrote: : > ChangeLog-entry: : > : > 2004-10-15 Bas van Gompel <[EMAIL PROTECTED]> : > : > * cygcheck.cc (pretty_id): Don't exit, return. Correct la

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-17 Thread Christopher Faylor
On Sat, Oct 16, 2004 at 02:14:33AM +0200, Bas van Gompel wrote: >Op Fri, 15 Oct 2004 09:59:04 -0400 schreef Christopher Faylor >jj: or to negate >: sz repeatedly inside of a loop. > >My plan was to not negate sz at all, use the printf format-flag ``-''. Yes. I get it. This is a difference of o

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-17 Thread Buzz
Op Sun, 17 Oct 2004 19:34:23 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Sat, Oct 16, 2004 at 02:14:33AM +0200, Bas van Gompel wrote: : > Op Fri, 15 Oct 2004 09:59:04 -0400 schreef Christopher Faylor : > jj: or to negate : > : sz repeatedly inside of a loop. : > : > My plan was

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-17 Thread Christopher Faylor
On Mon, Oct 18, 2004 at 03:32:07AM +0200, Buzz wrote: >2004-10-18 Bas van Gompel <[EMAIL PROTECTED]> > > * Cygcheck.cc (pretty_id): Count ')' in ui_len and gui_len. Thanks. Checked in without change. cgf

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-17 Thread Bas van Gompel
Op Sun, 17 Oct 2004 21:46:29 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Mon, Oct 18, 2004 at 03:32:07AM +0200, Buzz wrote: [...] : > * Cygcheck.cc (pretty_id): Count ')' in ui_len and gui_len. : : Thanks. Checked in without change. Thank you (for writing a better Chang

Re: [Patch] cygcheck: pretty_id misbehaving.

2004-10-18 Thread Corinna Vinschen
On Oct 18 07:13, Bas van Gompel wrote: > 2004-10-18 Bas van Gompel <[EMAIL PROTECTED]> > > * cygcheck.cc (pretty_id): Don't let i become negative. Fix > printf-format. Thanks, applied. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Proj