Re: Part 2 of Fixing a security hole in mount table.

2003-09-10 Thread Corinna Vinschen
On Tue, Sep 09, 2003 at 11:54:26PM -0400, Pierre A. Humblet wrote: 2003-09-10 Pierre Humblet [EMAIL PROTECTED] * shared_info.h (shared_info::initialize): Remove argument. * cygheap.h (cygheap_user::init): New declaration. * uinfo.cc (cygheap_user::init): New.

Re: Part 2 of Fixing a security hole in mount table.

2003-09-10 Thread Pierre A. Humblet
Corinna Vinschen wrote: Looks good to me, except for: - char name[UNLEN + 1] = ; + char name[UNLEN 127 ? UNLEN + 1 : 128] = ; Huh? Why that? UNLEN is defined as 256 in lmcons.h so I don't understand the reasoning behind that complexity. Just being paranoid. name can either

Re: Part 2 of Fixing a security hole in mount table.

2003-09-10 Thread Corinna Vinschen
On Wed, Sep 10, 2003 at 09:36:05AM -0400, Pierre A. Humblet wrote: Corinna Vinschen wrote: Looks good to me, except for: - char name[UNLEN + 1] = ; + char name[UNLEN 127 ? UNLEN + 1 : 128] = ; Huh? Why that? UNLEN is defined as 256 in lmcons.h so I don't understand the

Re: Part 2 of Fixing a security hole in mount table.

2003-09-10 Thread Corinna Vinschen
On Wed, Sep 10, 2003 at 12:50:34PM -0400, Pierre A. Humblet wrote: Corinna Vinschen wrote: On Wed, Sep 10, 2003 at 09:36:05AM -0400, Pierre A. Humblet wrote: Corinna Vinschen wrote: Looks good to me, except for: - char name[UNLEN + 1] = ; + char name[UNLEN 127 ?

Re: Fixing a security hole in mount table.

2003-09-09 Thread Corinna Vinschen
On Mon, Sep 08, 2003 at 09:11:34PM -0400, Christopher Faylor wrote: On Mon, Sep 08, 2003 at 08:46:06PM -0400, Pierre A. Humblet wrote: This is the first in a series of patches fixing security holes associated with the file mappings in the core of Cygwin. I hope the explanations below are

Re: Fixing a security hole in mount table.

2003-09-09 Thread Pierre A. Humblet
Christopher Faylor wrote: On Tue, Sep 09, 2003 at 12:12:11AM -0400, Pierre A. Humblet wrote: At 09:11 PM 9/8/2003 -0400, you wrote: On Mon, Sep 08, 2003 at 08:46:06PM -0400, Pierre A. Humblet wrote: This is the first in a series of patches fixing security holes associated with the file

Re: Fixing a security hole in mount table.

2003-09-09 Thread Pierre A. Humblet
Corinna Vinschen wrote: On Mon, Sep 08, 2003 at 09:11:34PM -0400, Christopher Faylor wrote: On Mon, Sep 08, 2003 at 08:46:06PM -0400, Pierre A. Humblet wrote: This is the first in a series of patches fixing security holes associated with the file mappings in the core of Cygwin. I hope

RE: Fixing a security hole in mount table.

2003-09-09 Thread Gary R Van Sickle
Christopher Faylor wrote: I wonder if it is time to bite the bullet and get rid of user-mode mounts entirely. Or maybe disallow them in suid'ed sessions? They are always going to be a security hole AFAICT. I think that would be a bad idea. What if I want to install a private

Fixing a security hole in mount table.

2003-09-08 Thread Pierre A. Humblet
This is the first in a series of patches fixing security holes associated with the file mappings in the core of Cygwin. I hope the explanations below are clear! Background on the mount table: System and user mounts are kept in a FileMapping, shared by all programs started from Windows by a

Re: Fixing a security hole in mount table.

2003-09-08 Thread Christopher Faylor
On Mon, Sep 08, 2003 at 08:46:06PM -0400, Pierre A. Humblet wrote: This is the first in a series of patches fixing security holes associated with the file mappings in the core of Cygwin. I hope the explanations below are clear! Yes they are, thanks. I can't comment on the security stuff but

Re: Fixing a security hole in mount table.

2003-09-08 Thread Pierre A. Humblet
At 09:11 PM 9/8/2003 -0400, you wrote: On Mon, Sep 08, 2003 at 08:46:06PM -0400, Pierre A. Humblet wrote: This is the first in a series of patches fixing security holes associated with the file mappings in the core of Cygwin. I hope the explanations below are clear! Yes they are, thanks. I can't

Re: Fixing a security hole in mount table.

2003-09-08 Thread Christopher Faylor
On Tue, Sep 09, 2003 at 12:12:11AM -0400, Pierre A. Humblet wrote: At 09:11 PM 9/8/2003 -0400, you wrote: On Mon, Sep 08, 2003 at 08:46:06PM -0400, Pierre A. Humblet wrote: This is the first in a series of patches fixing security holes associated with the file mappings in the core of Cygwin. I