- Original Message -
From: "Michael A Chase" <[EMAIL PROTECTED]>
To: "Robert Collins" <[EMAIL PROTECTED]>;
<[EMAIL PROTECTED]>
Sent: Friday, February 01, 2002 22:32
Subject: Re: For the curious: Setup.exe char-> String patch
> I have nearl
I have nearly eliminated concat.cc, concat() and vconcat(). I could
eliminate concat.h as well if I had a place to move SLASH_P() to. The only
file that uses that SLASH_P() is mount.cc, so I'd like to copy the macro to
mount.h. Is that acceptable?
--
Mac :})
** I normally forward private quest
===
- Original Message -
From: "Michael A Chase" <[EMAIL PROTECTED]>
> I'll have to do some thinking on that. I've never tried to create a
class.
> Other changes would be more important at this point. Would a
LOG_PLAIN
> (==LOG_TIMESTAMP) be acceptable to replace 0 in log() calls for no
- Original Message -
From: "Robert Collins" <[EMAIL PROTECTED]>
To: "Michael A Chase" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]>
Sent: Friday, February 01, 2002 18:45
Subject: RE: For the curious: Setup.exe char-> String patch
>> -Origina
> -Original Message-
> From: [EMAIL PROTECTED]
> > > > geturl.cc:
>
> > Weeel, yes it would, yet another typo. Fortunately String copies are
> > very lightweight :}.
> > (One addition, one subtraction, and if test and 4 bytes of storage)
>
> ??? You're doing some sort of ref counting?
> -Original Message-
> From: Robert Collins [mailto:[EMAIL PROTECTED]]
> > -Original Message-
> > From: Gary R Van Sickle [mailto:[EMAIL PROTECTED]]
> >
> > I think it would behoove us greatly to duplicate the semantics of
> > std::string here, and return a zero-based offset on su
> -Original Message-
> From: Gary R Van Sickle [mailto:[EMAIL PROTECTED]]
>
> I think it would behoove us greatly to duplicate the semantics of
> std::string here, and return a zero-based offset on success,
> and an "npos"
> on failure.
Whats a 'npos' defined as?
> > geturl.cc:
> >
> -Original Message-
> From: Michael A Chase [mailto:[EMAIL PROTECTED]]
>
> I only saw two possible real problems. Everything else is a matter of
> consistency which I could send you a patch for after this is
> implemented.
>
> String++.cc:
>
> +// does this character exist in the st
> +// does this character exist in the string?
> +// 0 is false, 1 is the first position...
> +size_t
> +String::find(char aChar) const
> +{
> + for (size_t i=0; i < theData->length; ++i)
> +if (theData->theString[i] == aChar)
> + return i;
> + return 0;
>
> ### Won't this return 0 if a
- Original Message -
From: "Robert Collins" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Friday, February 01, 2002 13:58
Subject: For the curious: Setup.exe char-> String patch
> This is what I'm preparing to commit. I'm mailing it here as a
This is what I'm preparing to commit. I'm mailing it here as a preview,
because doing the changelog is going to take some time. (160Kb diff
to wade through).
The cstr_oneuse() is designed to allow efficient (via caching, not
implemented yet) leak-safe char * usage of a string. An equivalent
w
11 matches
Mail list logo
