Re: [PATCH] Update 2 - Setup.exe property sheet patch

2002-01-07 Thread Robert Collins
I'm sorry Jorg, but I don't have the standard to reference. Do you know of an on-line copy? (Googling for "c++ standard 10.3.2" gave me lots of useless hits :}) I got my info from the C++ FAQS second edition (Cline Lomow & Girou), FAQ 33.09. Rob === - Original Message - From: "Schaible,

RE: [PATCH] Update 2 - Setup.exe property sheet patch

2002-01-07 Thread "Schaible, Jörg"
Hi Robert, >> "Once virtual, always virtual", i.e., it isn't necessary to add >"virtual" to >> any overridden virtual functions, and in fact it's not possible to >> "unvirtualize" once virtualized. I do try to maintain them as a >stylistic >> convention, but even I fall short sometimes ;-). Tha

Re: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Robert Collins
- Original Message - From: "Gary R Van Sickle" <[EMAIL PROTECTED]> > > "Once virtual, always virtual", i.e., it isn't necessary to add "virtual" to > any overridden virtual functions, and in fact it's not possible to > "unvirtualize" once virtualized. I do try to maintain them as a stylis

RE: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Gary R Van Sickle
> Having had a good close look, there is a little more that is needed > before committing to CVS. > > 1) You've skipped at least one dialog - IDD_S_FROM_CWD - which is what > was breaking local_dir. Ok, I'll get that fixed tonight. > (Oh, and the functions weren't virtual in some > child classes

Re: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Robert Collins
Having had a good close look, there is a little more that is needed before committing to CVS. 1) You've skipped at least one dialog - IDD_S_FROM_CWD - which is what was breaking local_dir. (Oh, and the functions weren't virtual in some child classes :}). 2) See download.cc - is next_dialog still

Re: [PATCH] Update 2 - Setup.exe property sheet patch

2001-12-20 Thread Robert Collins
Last time around hopefully! 1) format your changelog with line wrap at 80 columns. 2) It's a changelog, so if you #if 0 and then remove a function during your local testing, the final change is actually just a remove. Likewise, chooser.[cc|h] should not be mentioned because it never exists (from